From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 5B2F79605 for ; Mon, 21 May 2018 08:52:21 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id t16-v6so11654847wrm.9 for ; Sun, 20 May 2018 23:52:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Lxqkc+QtaSW8S7rL9tjQQWRkc5WiFhYsMpcr3QQUEZI=; b=u+WiyH5rUK7waTjppI41ogc5BR39AYAHrMPcvvgNIMbzPs8q5SHVxCbIdRuE4XSYWb myDG2friTvROI2BqeYpqYvE3WNWxh6lRn6ealDWdfkG2xU41xp37oU4H5Lw5SUKWRy0t bBH0TjWjfyk47IWU1eEscANy6oUN4bHBb6M526fiX4TpLEtFPBC4HtKKVxlt3HEUoHwq vK+0vFH56W2NUw7pka7rf9AKr99u7pPphsPDh0vj2/gLoGy33CeEInLCxX9CfPFTDTlw 2Qb1ledp82xw60jySLSkOSelOGe9LVY6zX9t/t/z5T8x5Kh4I/nlsR1j1KGNWYLqgCyF EadQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Lxqkc+QtaSW8S7rL9tjQQWRkc5WiFhYsMpcr3QQUEZI=; b=OB9uIupm8RbNCg3iOw4MVwoCI1nJRqOCxun04bg0knrR5izPX0+JQAzyR63cqCOp3T U1imKITXjHHt7Hwn6p0t3RUCkzDCPZbEIS3U6EuhPEgZ1hTnUkgeNcoomxaVyO18gV7O 6h9cVgLO1HM7L+Ig7S+AVLrR1PpcrgSlvAqxc3lORezo3kQxAOT7ynEZVy8BKuLJZNoB 67Nj5RPJtXvnPE5IVk5KE/pjGEIiDXFNLUpTPOq+27BwEm5/jxNhTrykh9NpjF9vp5zc mjOkeiQI3YcBAQXAIpdc0ZjZMQTwjN7gTNiRkAQve3hG4DCDHcSo9ZE7XBgkoxh6lYsK uTwA== X-Gm-Message-State: ALKqPwet3m/2w6DGnsJI//93RGB030mhnBDR0RZAiBnG+eSN35ofkAYM 08VPmtGdRNekWYwQpRF7qHdG X-Google-Smtp-Source: AB8JxZr2gmCzsNDCQfOKXLopCU5olhX1GSW1ryp1SRyUZWjxnYiCkyxJBKG5gT7E3ZLxyQqwjlUhSg== X-Received: by 2002:adf:aa8c:: with SMTP id h12-v6mr9234537wrc.149.1526885541003; Sun, 20 May 2018 23:52:21 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k23-v6sm16526614wrc.59.2018.05.20.23.52.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 20 May 2018 23:52:20 -0700 (PDT) Date: Mon, 21 May 2018 08:52:14 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: David Marchand Cc: dev@dpdk.org, adrien.mazarguil@6wind.com, yskoh@mellanox.com Message-ID: <20180521065214.4kp72ayjhlizixvz@laranjeiro-vm.dev.6wind.com> References: <1526804038-27137-1-git-send-email-david.marchand@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1526804038-27137-1-git-send-email-david.marchand@6wind.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid count in xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 06:52:21 -0000 On Sun, May 20, 2018 at 10:13:58AM +0200, David Marchand wrote: > With the commit af4f09f28294 ("net/mlx5: prefix all functions with mlx5"), > mlx5_xstats_get() is not compliant any longer with the api. > It always returns the caller max entries count while it should return how > many entries it wrote/wanted to write. > > Fixes: af4f09f28294 ("net/mlx5: prefix all functions with mlx5") > > Signed-off-by: David Marchand Acked-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_stats.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_stats.c b/drivers/net/mlx5/mlx5_stats.c > index 8e427e7..875dd10 100644 > --- a/drivers/net/mlx5/mlx5_stats.c > +++ b/drivers/net/mlx5/mlx5_stats.c > @@ -325,7 +325,7 @@ mlx5_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *stats, > stats[i].value = (counters[i] - xstats_ctrl->base[i]); > } > } > - return n; > + return xstats_n; > } > > /** > -- > 2.7.4 Thanks, -- Nélio Laranjeiro 6WIND