From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id C25BD8E85 for ; Mon, 21 May 2018 10:24:17 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id x12-v6so11125777wmc.0 for ; Mon, 21 May 2018 01:24:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ygqGY+kQBXsn6pcCtlMVLKjJRgHAOTHI9D8ugAhwGxw=; b=F32pgtkSbiuCCKJ0Jt7CKoQYEEUKgsilN3zX5eJ52SFOgYw61zQL1VtPlPEmkh0oPT iXeTOAk0Y4Or1DtSnyAKtIXCK6L0HpXZ9p4mdR1wYID2+pXAdlitNVDTiiWDdi12QReu d4ac4l4cqDz/1NRHoQ0bs6AvDfUyzghp9QfrXJ2ee4OWRcVcjaiUuT3UgbNfKzJOTT2g cFIoAbYvUoa1dg0cbKchPcMZeCnw2Rke5xHrDTaJnCHdW599YcmRfxRYwD7gPRqLbwc3 zreBhyd4oehq4nzdNued5buJnWvjwEJSVtiLh0t79MXuwiFgn8Trpv332UDl53o9lUZ/ XHzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ygqGY+kQBXsn6pcCtlMVLKjJRgHAOTHI9D8ugAhwGxw=; b=Mis3qIHvp1LzGk8oEj5MlVGDu93GxVUEBqS9kXkLXQaUvVJkx+5MQbMHShBCyhWksc scVcHJhRePA9J728o884WhVtWUlW9JSNnlW0DqYwAjfUwZnWhl9G4v3k5CRICv6qutee ftZeOw37OkVW8x8pcwmRrrdVzKLF15D9z2NBfbauKmVxFhOmZP+zR77d38V9NgbkbzMh aDL8PFSmmlv+rqj1y8DAy3E3XxRJIANAmj0deGjqbPK3WZY85oGBucyeYQLQfKikMTDw e59f/AelKwe497SmkvGGMpG0Z7FS+DJB5d2vCNHlmv53l4uw6ZUaCQE88TijMWurLqWl bLbg== X-Gm-Message-State: ALKqPwdPxAnXyxpI9yQ0sdT06OFXprBP/VReNTkD22D1DW/WvX++rQts zVl3KqukeQZxuEOkj9lvPtGFPw== X-Google-Smtp-Source: AB8JxZomKGUlL+XEQTNl1iIFM+X13qQzU4f1tOh3mImtfRUCbanCOcOzIe6uP5ZZ03zqIUs0dcYXdw== X-Received: by 2002:a1c:dc54:: with SMTP id t81-v6mr11171333wmg.90.1526891057501; Mon, 21 May 2018 01:24:17 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 89-v6sm1987325wri.37.2018.05.21.01.24.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 May 2018 01:24:16 -0700 (PDT) Date: Mon, 21 May 2018 10:24:02 +0200 From: Adrien Mazarguil To: Thomas Monjalon Cc: Ferruh Yigit , dev@dpdk.org, stable@dpdk.org, Qi Zhang Message-ID: <20180521082401.GO6497@6wind.com> References: <20180516154052.16836-1-adrien.mazarguil@6wind.com> <20180516154052.16836-2-adrien.mazarguil@6wind.com> <465390c3-5aa9-e015-52bd-cec695d84c4c@intel.com> <58726116.gJB1vlhU96@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58726116.gJB1vlhU96@xps> Subject: Re: [dpdk-dev] [PATCH 2/2] ethdev: fix shallow copy of flow API RAW item X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 08:24:18 -0000 On Sat, May 19, 2018 at 04:25:15PM +0200, Thomas Monjalon wrote: > 18/05/2018 19:06, Ferruh Yigit: > > On 5/16/2018 4:41 PM, Adrien Mazarguil wrote: > > > Like original commit mentioned below, this fix synchronizes flow rule copy > > > function with testpmd's own implementation following "app/testpmd: fix copy > > > of raw flow item (revisited)". > > > > > > Fixes: d0ad8648b1c5 ("ethdev: fix shallow copy of flow API RSS action") > > > Cc: stable@dpdk.org > > > Cc: Qi Zhang > > > > > > Signed-off-by: Adrien Mazarguil > > > > Hi Thomas, > > > > What do you suggest about this one? > > Scope is limited to rte_flow but still many features are now relies on rte_flow, > > what is your comment on getting this in rc5? > > We need to know exactly what is broken. > If nothing serious, it can wait 18.08. > > Adrien, please can you describe the use case, the issue and the impact? A prior patch [1] (applied as "app/testpmd: fix copy of raw flow item"), addresses a crash in testpmd's flow copy function. The first patch of the present series [2] addresses remaining issues with its behavior which is, in fact, what caused the original issue. While both patches focus on testpmd, rte_flow also exposes its own public copy function with the exact same code that breaks when encountering a RAW pattern item. Primary users for this function are bonding and failsafe PMDs. This patch therefore addresses both [1] and [2] at once for rte_flow_copy(). [1] "app/testpmd: fix invalid memory access" http://dpdk.org/ml/archives/dev/2018-May/100364.html [2] "app/testpmd: fix copy of raw flow item (revisited)" http://dpdk.org/ml/archives/dev/2018-May/101994.html -- Adrien Mazarguil 6WIND