DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
To: declan.doherty@intel.com, akhil.goyal@nxp.com, shally.verma@cavium.com
Cc: dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com>
Subject: [dpdk-dev] [PATCH v4 4/6] doc: announce deprecation in crypto queue pair start/stop
Date: Mon, 21 May 2018 12:06:54 +0100	[thread overview]
Message-ID: <20180521110656.42437-5-pablo.de.lara.guarch@intel.com> (raw)
In-Reply-To: <20180521110656.42437-1-pablo.de.lara.guarch@intel.com>

Functions rte_cryptodev_queue_pair_start/stop
are not really used in any of the crypto drivers
(they all just return 0 or -ENOTSUP).
Therefore, this API can be deprecated from 18.05
and removed in 18.08.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 lib/librte_cryptodev/rte_cryptodev.h | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index b5d1cc0d5..66168812c 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -84,3 +84,7 @@ Deprecation Notices
     ``rte_cryptodev_queue_pair_dettach_sym_session()`` will be deprecated from
     18.05 and removed in 18.08, as there are no drivers doing anything useful
     with them.
+  - Functions ``rte_cryptodev_queue_pair_start()`` and
+    ``rte_cryptodev_queue_pair_stop()`` will be deprecated from 18.05
+    and removed in 18.08, as there are no drivers doing anything useful
+    with them.
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index efd3270e5..db367a1f8 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -602,6 +602,7 @@ rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,
 		struct rte_mempool *session_pool);
 
 /**
+ * @deprecated
  * Start a specified queue pair of a device. It is used
  * when deferred_start flag of the specified queue is true.
  *
@@ -615,10 +616,12 @@ rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,
  *   - -EINVAL: The dev_id or the queue_id out of range.
  *   - -ENOTSUP: The function not supported in PMD driver.
  */
+__rte_deprecated
 extern int
 rte_cryptodev_queue_pair_start(uint8_t dev_id, uint16_t queue_pair_id);
 
 /**
+ * @deprecated
  * Stop specified queue pair of a device
  *
  * @param	dev_id		The identifier of the device
@@ -631,6 +634,7 @@ rte_cryptodev_queue_pair_start(uint8_t dev_id, uint16_t queue_pair_id);
  *   - -EINVAL: The dev_id or the queue_id out of range.
  *   - -ENOTSUP: The function not supported in PMD driver.
  */
+__rte_deprecated
 extern int
 rte_cryptodev_queue_pair_stop(uint8_t dev_id, uint16_t queue_pair_id);
 
-- 
2.17.0

  parent reply	other threads:[~2018-05-21 11:06 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-26  9:03 [dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct Pablo de Lara
2018-01-26 10:44 ` Trahe, Fiona
2018-01-26 11:08   ` De Lara Guarch, Pablo
2018-01-29  9:26     ` Akhil Goyal
2018-01-30  7:55       ` Verma, Shally
2018-01-30 11:21         ` De Lara Guarch, Pablo
2018-01-30 11:53           ` Verma, Shally
2018-02-02  9:07             ` De Lara Guarch, Pablo
2018-02-02 10:52               ` Verma, Shally
2018-01-30 11:37 ` Akhil Goyal
2018-01-30 12:14 ` [dpdk-dev] [PATCH v2 0/3] Cryptodev API/ABI deprecation notices Pablo de Lara
2018-01-30 12:14   ` [dpdk-dev] [PATCH v2 1/3] doc: announce ABI change for crypto info struct Pablo de Lara
2018-01-30 12:14   ` [dpdk-dev] [PATCH v2 2/3] doc: announce deprecation for attach/detach crypto session Pablo de Lara
2018-01-30 12:14   ` [dpdk-dev] [PATCH v2 3/3] doc: announce deprecation in crypto queue pair start/stop Pablo de Lara
2018-02-13 11:45   ` [dpdk-dev] [PATCH v2 0/3] Cryptodev API/ABI deprecation notices De Lara Guarch, Pablo
2018-05-17  9:00 ` [dpdk-dev] [PATCH v3 0/4] " Pablo de Lara
2018-05-17  9:00   ` [dpdk-dev] [PATCH v3 1/4] doc: announce ABI change for crypto sym info struct Pablo de Lara
2018-05-18 11:42     ` Akhil Goyal
2018-05-17  9:00   ` [dpdk-dev] [PATCH v3 2/4] doc: announce ABI change for crypto " Pablo de Lara
2018-05-17 11:18     ` Trahe, Fiona
2018-05-18 11:41     ` Akhil Goyal
2018-05-17  9:00   ` [dpdk-dev] [PATCH v3 3/4] doc: announce deprecation for attach/detach crypto session Pablo de Lara
2018-05-17 11:16     ` Trahe, Fiona
2018-05-18 11:44       ` Akhil Goyal
2018-05-17  9:00   ` [dpdk-dev] [PATCH v3 4/4] doc: announce deprecation in crypto queue pair start/stop Pablo de Lara
2018-05-17 11:32     ` Trahe, Fiona
2018-05-21 11:06 ` [dpdk-dev] [PATCH v4 0/6] Cryptodev API/ABI deprecation notices Pablo de Lara
2018-05-21 11:06   ` [dpdk-dev] [PATCH v4 1/6] doc: announce ABI change for crypto sym info struct Pablo de Lara
2018-05-21 11:06   ` [dpdk-dev] [PATCH v4 2/6] doc: announce ABI change for crypto " Pablo de Lara
2018-05-21 11:06   ` [dpdk-dev] [PATCH v4 3/6] doc: announce deprecation for attach/detach crypto session Pablo de Lara
2018-05-21 11:06   ` Pablo de Lara [this message]
2018-05-21 11:06   ` [dpdk-dev] [PATCH v4 5/6] doc: announce deprecation in crypto feature flags Pablo de Lara
2018-05-21 11:52     ` Akhil Goyal
2018-05-21 11:06   ` [dpdk-dev] [PATCH v4 6/6] cryptodev: rename get session size API Pablo de Lara
2018-05-21 11:41     ` Akhil Goyal
2018-05-21 12:05     ` Verma, Shally
2018-05-21 12:14       ` De Lara Guarch, Pablo
2018-05-21 13:08 ` [dpdk-dev] [PATCH v5 0/6] Cryptodev API/ABI deprecation notices Pablo de Lara
2018-05-21 13:08   ` [dpdk-dev] [PATCH v5 1/6] doc: announce ABI change for crypto sym info struct Pablo de Lara
2018-05-21 13:08   ` [dpdk-dev] [PATCH v5 2/6] doc: announce ABI change for crypto " Pablo de Lara
2018-05-21 13:08   ` [dpdk-dev] [PATCH v5 3/6] doc: announce deprecation for attach/detach crypto session Pablo de Lara
2018-05-21 13:08   ` [dpdk-dev] [PATCH v5 4/6] doc: announce deprecation in crypto queue pair start/stop Pablo de Lara
2018-05-21 13:08   ` [dpdk-dev] [PATCH v5 5/6] doc: announce deprecation in crypto feature flags Pablo de Lara
2018-05-21 17:27     ` Trahe, Fiona
2018-05-21 13:08   ` [dpdk-dev] [PATCH v5 6/6] cryptodev: rename get session size API Pablo de Lara
2018-05-22  5:35     ` Verma, Shally
2018-05-22  9:33     ` Trahe, Fiona
2018-05-22 17:34     ` Thomas Monjalon
2018-05-22 14:30   ` [dpdk-dev] [PATCH v5 0/6] Cryptodev API/ABI deprecation notices Jain, Deepak K
2018-05-22 14:35     ` De Lara Guarch, Pablo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180521110656.42437-5-pablo.de.lara.guarch@intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=shally.verma@cavium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).