From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 375111200A for ; Mon, 21 May 2018 13:19:09 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id l1-v6so26021889wmb.2 for ; Mon, 21 May 2018 04:19:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=T9QXONZuZGWZpmWD3+c4mSmKqda70xBuwnibK3BQddY=; b=xLwRsMSrfBRZzcku7Gs79oQVpwNg1E2kUnX4CHlIJQ8VsJcOmjO6HhEMsAf3Yu32gp BxHUU0TDrSNFnfBmPaLoJKenHkCiAnM6QSj6yK3wWc/r4wuzoMSWMx0NHnUcDOIMjBGP Xi9DJZ1IAGBwa2dvVyQAZZwzRZpxFtM/7SYAM8psqvnURptu8v3GJ1Upm2PigfqUhIpI YEgVycBu1R8Jkz4Ytl+F/SnjW2LTGeUFYy3H+KiOKn72fH4P971EI8/QoymESJbJuKuD prehsd+OwEzoWnuEZKHprBxNdBLsYmCS1UgicodVR29n3+GigBTLb+qzXF7h+YJPkoSj 340g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=T9QXONZuZGWZpmWD3+c4mSmKqda70xBuwnibK3BQddY=; b=K7MvuUsbKwOW7yqy8twq/pyypi7NzJqasx+Jsd4AhlyosQbtq2dthPwvqg/c4bpOYm pMiK9MiJ2fS++/cP/oV4VxxddkKRQRxwYRCTJzpmO+z2BVmOWu5m9WWpxPXmIv646zGU 9khKkcbA2xbmBQ3bA8EI6rRqHzVN3zOpxqDq9ufji7nTuuB6cYmiRfHF0lsqE3qvBuqC 4uqJTG1TICAc15gBylC6USra0BKvU4JqoFGVI4cff4FqVVrWEQzbLzj4so/JqFYGBdty 8tsN7gF444egl5uc5lQN/H76mxKpeObawxRbVLM0WnXiOGaoWbLkFvgv/7JpUFgH4bLs 2zCw== X-Gm-Message-State: ALKqPwc/LyLhT0sT/6JEy2UfQBHW7mpfHtbuloimXfMtDexOIXiuI7T2 K89ZvcsNwQ0KQajxrgJolrNWPg== X-Google-Smtp-Source: AB8JxZoULVf/BxqQ3wMe89Rk1CH5wlRk2Pl0e37uydyq9pOZGr2GEfzl2Rngu9lKzLuAjfkSWcErIw== X-Received: by 2002:a1c:4518:: with SMTP id s24-v6mr11264820wma.50.1526901548938; Mon, 21 May 2018 04:19:08 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id u8-v6sm11978732wmf.3.2018.05.21.04.19.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 May 2018 04:19:08 -0700 (PDT) Date: Mon, 21 May 2018 13:18:53 +0200 From: Adrien Mazarguil To: Ferruh Yigit Cc: Thomas Monjalon , dev@dpdk.org, stable@dpdk.org, Qi Zhang Message-ID: <20180521111853.GR6497@6wind.com> References: <20180516154052.16836-1-adrien.mazarguil@6wind.com> <20180516154052.16836-2-adrien.mazarguil@6wind.com> <465390c3-5aa9-e015-52bd-cec695d84c4c@intel.com> <58726116.gJB1vlhU96@xps> <20180521082401.GO6497@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH 2/2] ethdev: fix shallow copy of flow API RAW item X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 11:19:09 -0000 On Mon, May 21, 2018 at 11:44:33AM +0100, Ferruh Yigit wrote: > On 5/21/2018 9:24 AM, Adrien Mazarguil wrote: > > On Sat, May 19, 2018 at 04:25:15PM +0200, Thomas Monjalon wrote: > >> 18/05/2018 19:06, Ferruh Yigit: > >>> On 5/16/2018 4:41 PM, Adrien Mazarguil wrote: > >>>> Like original commit mentioned below, this fix synchronizes flow rule copy > >>>> function with testpmd's own implementation following "app/testpmd: fix copy > >>>> of raw flow item (revisited)". > >>>> > >>>> Fixes: d0ad8648b1c5 ("ethdev: fix shallow copy of flow API RSS action") > >>>> Cc: stable@dpdk.org > >>>> Cc: Qi Zhang > >>>> > >>>> Signed-off-by: Adrien Mazarguil > >>> > >>> Hi Thomas, > >>> > >>> What do you suggest about this one? > >>> Scope is limited to rte_flow but still many features are now relies on rte_flow, > >>> what is your comment on getting this in rc5? > >> > >> We need to know exactly what is broken. > >> If nothing serious, it can wait 18.08. > >> > >> Adrien, please can you describe the use case, the issue and the impact? > > > > A prior patch [1] (applied as "app/testpmd: fix copy of raw flow item"), > > addresses a crash in testpmd's flow copy function. > > > > The first patch of the present series [2] addresses remaining issues with > > its behavior which is, in fact, what caused the original issue. > > > > While both patches focus on testpmd, rte_flow also exposes its own public > > copy function with the exact same code that breaks when encountering a RAW > > pattern item. Primary users for this function are bonding and failsafe > > PMDs. > > > > This patch therefore addresses both [1] and [2] at once for rte_flow_copy(). > > Hi Adrien, > > What is the effect of _not_ getting this patch, just trying to understand if > this is something to get for this release or postpone to next one. Hi Ferruh, *Not* getting this patch means rte_flow_copy() crashes when user creates a flow rule that involves the RAW pattern item on top of either bonding or failsafe PMDs. Ditto for any external application that relies on rte_flow_copy() combined with the RAW pattern item. I'll send v2 to provide a bit more info and fix the wrong commit ID on the "Fixes" line. > > [1] "app/testpmd: fix invalid memory access" > > http://dpdk.org/ml/archives/dev/2018-May/100364.html > > > > [2] "app/testpmd: fix copy of raw flow item (revisited)" > > http://dpdk.org/ml/archives/dev/2018-May/101994.html -- Adrien Mazarguil 6WIND