From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id DBA8A1B03D for ; Mon, 21 May 2018 14:14:38 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 May 2018 05:14:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,426,1520924400"; d="scan'208";a="42937221" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.55]) by orsmga008.jf.intel.com with SMTP; 21 May 2018 05:14:35 -0700 Received: by (sSMTP sendmail emulation); Mon, 21 May 2018 13:14:35 +0100 Date: Mon, 21 May 2018 13:14:34 +0100 From: Bruce Richardson To: Andy Green Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20180521121434.GD22944@bricha3-MOBL.ger.corp.intel.com> References: <152686781484.58694.14737673447518527445.stgit@localhost.localdomain> <152686807337.58694.8171528630879404747.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152686807337.58694.8171528630879404747.stgit@localhost.localdomain> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v6 4/8] rte_mbuf.h: reduce temp to match uint16 types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 12:14:39 -0000 On Mon, May 21, 2018 at 10:01:13AM +0800, Andy Green wrote: > /projects/lagopus/src/dpdk/build/include/rte_mbuf.h: > In function 'rte_pktmbuf_detach': > /projects/lagopus/src/dpdk/build/include/rte_mbuf.h: > 1583:17: warning: conversion from 'uint32_t' {aka > 'unsigned int'} to 'uint16_t' {aka > 'short unsigned int'} may change value [-Wconversion] > m->priv_size = priv_size; > ^~~~~~~~~ > > The temp priv_size is declared as a uint32_t. But it > only deals in uint16_t. m->priv_size is a uint16_t. > Change it to a uint16_t. > > Fixes: 355e6735b3 ("mbuf: fix cloning with private mbuf data") > Fixes: 1a60a0daa6 ("mbuf: fix segments number type increase") > Signed-off-by: Andy Green > --- > lib/librte_mbuf/rte_mbuf.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Acked-by: Bruce Richardson