From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f66.google.com (mail-pl0-f66.google.com [209.85.160.66]) by dpdk.org (Postfix) with ESMTP id 59DFC1B1C9 for ; Mon, 21 May 2018 18:41:56 +0200 (CEST) Received: by mail-pl0-f66.google.com with SMTP id t12-v6so9118032plo.7 for ; Mon, 21 May 2018 09:41:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1Ty7TNytf7njgQSdAzcpeo44kx34ZeuR1qsRTVh3Vig=; b=UN4xgSG4rz9K2JDndhQFSLsOtd/D1zt5MfpcGEyOeMq+OUJ4wvDVJvcOam4NQyP78S nmHMwvSfXEoX33XBQqo0zdXeTtua3dJ9o3r1i7aAzXeM3rXzTcDcUMSwKuU+/PX40n+9 ppovnwcXM92YdhSObeKvMY8Xe+anlaURlD/adl7PSSn+aXnX1lAoml07lI/PxMHDbkdQ RhTZDEAxOcePVLRxhEB/2nylsqdBruub4CWhqi1cPOILQsTgdMYjca32p64Vk+OhzmCq MYA4qNKNqNbtte/pKtxkCFdrCiXJUIp3R1cCCiZtIQNa8hOpQyyGXgO3p47hAysIDU3A JLvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1Ty7TNytf7njgQSdAzcpeo44kx34ZeuR1qsRTVh3Vig=; b=PuAQ5wji5VkfoWFcBp1E3QgXVVDOAWO8wB956F2uxf0lika2m66eMMsE15iagT02id 4f3rxK7PPwJz1+IbOm5etI6vOOsiX6OoFXHCAJJQgbNCh0wg7pqXB1OLUE00uUdi4XFE uIotrEI+qkHeA26PHHSdfiSyI9sedZANmEeXb6sheX1lliSkffctDcLTdtvA7/MzXfMY zyzo3ijw94nJDyj6pSwqnMdCTIQrDXz13LiA3DNyZeZuQCSynQqZfBL6rQw7Wf6uIhr4 5osOWaNXZrT49NETiEdJPNfR7kj2yLuS2xWvNE0LCKEQ1Kvhuy3RF+ksKyxAxQYOKZNQ I3bA== X-Gm-Message-State: ALKqPwfev9u+/P/EVV248K+xK/cXFo7fTJ0+8dzeaLe5FrRIjkq4lWlF QKok9E+V+/p6EM/srHKO44vuGYyZw+I= X-Google-Smtp-Source: AB8JxZou6uNE0jmH/UMP/eKqSUv/Aa8ROPtPOQRCtO5t9CXUZpseHV8FS4+QgvCKnZ2qmoG+U3m30g== X-Received: by 2002:a17:902:7409:: with SMTP id g9-v6mr21094097pll.255.1526920915194; Mon, 21 May 2018 09:41:55 -0700 (PDT) Received: from xeon-e3.lan (204-195-35-107.wavecable.com. [204.195.35.107]) by smtp.gmail.com with ESMTPSA id u4-v6sm34622838pgn.10.2018.05.21.09.41.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 May 2018 09:41:53 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Mon, 21 May 2018 09:41:49 -0700 Message-Id: <20180521164150.24252-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180521164150.24252-1-stephen@networkplumber.org> References: <20180521164150.24252-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 1/2] pci: make rte_pci_remove_device static X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 16:41:56 -0000 Only used in one file, and therefore can be made static. Signed-off-by: Stephen Hemminger --- drivers/bus/pci/pci_common.c | 5 ++++- drivers/bus/pci/private.h | 10 ---------- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 7215aaec3add..d3ac04a8f00f 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common.c @@ -26,6 +26,9 @@ #include "private.h" + +static void rte_pci_remove_device(struct rte_pci_device *pci_device); + extern struct rte_pci_bus rte_pci_bus; #define SYSFS_PCI_DEVICES "/sys/bus/pci/devices" @@ -445,7 +448,7 @@ rte_pci_insert_device(struct rte_pci_device *exist_pci_dev, } /* Remove a device from PCI bus */ -void +static void rte_pci_remove_device(struct rte_pci_device *pci_dev) { TAILQ_REMOVE(&rte_pci_bus.device_list, pci_dev, next); diff --git a/drivers/bus/pci/private.h b/drivers/bus/pci/private.h index 88fa587e74dc..02e2fb44367f 100644 --- a/drivers/bus/pci/private.h +++ b/drivers/bus/pci/private.h @@ -93,16 +93,6 @@ void rte_pci_add_device(struct rte_pci_device *pci_dev); void rte_pci_insert_device(struct rte_pci_device *exist_pci_dev, struct rte_pci_device *new_pci_dev); -/** - * Remove a PCI device from the PCI Bus. This sets to NULL the bus references - * in the PCI device object as well as the generic device object. - * - * @param pci_device - * PCI device to be removed from PCI Bus - * @return void - */ -void rte_pci_remove_device(struct rte_pci_device *pci_device); - /** * Update a pci device object by asking the kernel for the latest information. * -- 2.17.0