From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 755D111D4 for ; Tue, 22 May 2018 11:00:40 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id o78-v6so31403375wmg.0 for ; Tue, 22 May 2018 02:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=33D9qoK39EH4pDjN9g30f2BqUfsiHs0XfM2pbP34EOU=; b=CJ/LPx8fB2G3nx72tqRecJ6J/O5BGf2nwoZj18aCUHRAgzTlu+4vlpcZSsN0s6NDsu LNkoyCJyagKPBuWoA1vu+SkiqLwquLDeHKpYApoWLFOMSq7+o+XRm8ykScCm3XNMaHUe DU/TIzA2lMHKn+29n+FEz6iB2QpJDR0v21xLADdRSdkd+UETEQvM8hHkMrKDRBYex5X9 Uvb4l3PIGKFXi/QBDkWy7XZ2vm9TTT7tsr+H1KajU/fF3bx2rWEXcbx6AA0mYcEim2V+ huz/BB9HkWCB1umJW+UzCBQZIfZaONH/KbeZdYC9X3OBwHBjGzmd+TW6JMgI9LNN0zBm rZog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=33D9qoK39EH4pDjN9g30f2BqUfsiHs0XfM2pbP34EOU=; b=qYA3w/tHtk36bbJpxw2BmGom/PvR3MumEkEIYOenkZa0TVxHNDZNMmxj5io1mKfTl3 bdrG11yRVrvIJr0VWw6dcVJpwaPzQmVlwOncOxUTXUlh21RRsKy2tO5OrKB4lYtTw9E5 nXrl9Yw03j9fynjSFNELiiwsDIrPoPoXen+UTGwcXr7sUL/+bNmabNBfalF1NZIwAPP4 /Imvz7rx0qNDy+KC65lRhlnSyZWZfRKBNwv4RFhI2eHd+y7f3efWL8LTdl7Xz2DZhJG8 ifSOYTJ5QIY+gM1mUWxfdlUtD5jlpxu5AtKJqO/L4cBsKhFdesmgUbdh3ERys4EtxFPv sRQA== X-Gm-Message-State: ALKqPweYc7xPuKATcEkdOyeSwNKC1oUsfFHWhcYf4mDvOWdQSrw+oX07 6Wa5ozw5t5dmKdmLaqBf9gmsisyV X-Google-Smtp-Source: AB8JxZoJw+Z2G90BIKrh01ygfZecHKN+sa513lrWc1JSe9N7a2Ekgmw2ZjAI2rW13ucipzWUH+keLw== X-Received: by 2002:a1c:8c6:: with SMTP id 189-v6mr475739wmi.19.1526979639869; Tue, 22 May 2018 02:00:39 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k126-v6sm19274697wmg.6.2018.05.22.02.00.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 May 2018 02:00:39 -0700 (PDT) Date: Tue, 22 May 2018 11:00:24 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20180522090024.m3cob5wsgk55tkvu@bidouze.vm.6wind.com> References: <20180521164150.24252-1-stephen@networkplumber.org> <20180521164150.24252-2-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180521164150.24252-2-stephen@networkplumber.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 1/2] pci: make rte_pci_remove_device static X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 09:00:40 -0000 Hello Stephen, On Mon, May 21, 2018 at 09:41:49AM -0700, Stephen Hemminger wrote: > Only used in one file, and therefore can be made static. > > Signed-off-by: Stephen Hemminger Acked-by: Gaetan Rivet > --- > drivers/bus/pci/pci_common.c | 5 ++++- > drivers/bus/pci/private.h | 10 ---------- > 2 files changed, 4 insertions(+), 11 deletions(-) > > diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c > index 7215aaec3add..d3ac04a8f00f 100644 > --- a/drivers/bus/pci/pci_common.c > +++ b/drivers/bus/pci/pci_common.c > @@ -26,6 +26,9 @@ > > #include "private.h" > > + > +static void rte_pci_remove_device(struct rte_pci_device *pci_device); > + > extern struct rte_pci_bus rte_pci_bus; > > #define SYSFS_PCI_DEVICES "/sys/bus/pci/devices" > @@ -445,7 +448,7 @@ rte_pci_insert_device(struct rte_pci_device *exist_pci_dev, > } > > /* Remove a device from PCI bus */ > -void > +static void > rte_pci_remove_device(struct rte_pci_device *pci_dev) > { > TAILQ_REMOVE(&rte_pci_bus.device_list, pci_dev, next); > diff --git a/drivers/bus/pci/private.h b/drivers/bus/pci/private.h > index 88fa587e74dc..02e2fb44367f 100644 > --- a/drivers/bus/pci/private.h > +++ b/drivers/bus/pci/private.h > @@ -93,16 +93,6 @@ void rte_pci_add_device(struct rte_pci_device *pci_dev); > void rte_pci_insert_device(struct rte_pci_device *exist_pci_dev, > struct rte_pci_device *new_pci_dev); > > -/** > - * Remove a PCI device from the PCI Bus. This sets to NULL the bus references > - * in the PCI device object as well as the generic device object. > - * > - * @param pci_device > - * PCI device to be removed from PCI Bus > - * @return void > - */ > -void rte_pci_remove_device(struct rte_pci_device *pci_device); > - > /** > * Update a pci device object by asking the kernel for the latest information. > * > -- > 2.17.0 > -- Gaëtan Rivet 6WIND