From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id F37C7152A for ; Tue, 22 May 2018 11:12:41 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2018 02:12:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,429,1520924400"; d="scan'208";a="41255743" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.55]) by fmsmga007.fm.intel.com with SMTP; 22 May 2018 02:12:39 -0700 Received: by (sSMTP sendmail emulation); Tue, 22 May 2018 10:12:37 +0100 Date: Tue, 22 May 2018 10:12:36 +0100 From: Bruce Richardson To: Andy Green Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20180522091236.GA22916@bricha3-MOBL.ger.corp.intel.com> References: <152695215195.111551.10652921922687464367.stgit@localhost.localdomain> <152695228744.111551.1634282119196550467.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152695228744.111551.1634282119196550467.stgit@localhost.localdomain> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v7 8/8] rte_ethdev.h: align sign and scope of temp var X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 09:12:42 -0000 On Tue, May 22, 2018 at 09:24:47AM +0800, Andy Green wrote: > /projects/lagopus/src/dpdk/build/include/rte_ethdev.h: > In function 'rte_eth_rx_burst': > /projects/lagopus/src/dpdk/build/include/rte_ethdev.h: > 3836:18: warning: conversion to 'int16_t' {aka 'short > int'} from 'uint16_t' {aka 'short unsigned int'} may > change the sign of the result [-Wsign-conversion] > int16_t nb_rx = (*dev->rx_pkt_burst)(dev->data-> > rx_queues[queue_id], > ^ > /projects/lagopus/src/dpdk/build/include/rte_ethdev.h: > 3844:50: warning: conversion to 'uint16_t' {aka 'short > unsigned int'} from 'int16_t' {aka 'short int'} may > change the sign of the result [-Wsign-conversion] > nb_rx = cb->fn.rx(port_id, queue_id, rx_pkts, nb_rx, > ^~~~~ > /projects/lagopus/src/dpdk/build/include/rte_ethdev.h: > 3844:12: warning: conversion to 'int16_t' {aka 'short > int'} from 'uint16_t' {aka 'short unsigned int'} may > change the sign of the result [-Wsign-conversion] > nb_rx = cb->fn.rx(port_id, queue_id, rx_pkts, nb_rx, > ^~ > /projects/lagopus/src/dpdk/build/include/rte_ethdev.h: > 3851:9: warning: conversion to 'uint16_t' {aka 'short > unsigned int'} from 'int16_t' {aka 'short int'} may > change the sign of the result [-Wsign-conversion] > return nb_rx; > ^~~~~ > > The second part of the patch is solved by its own basic > block because it is inside a preprocessor conditional. > > Bringing the declaration of the var to the top of the > function would require that also being given its own > preprocessor conditional, or a (void)var to avoid an > unused var warning. The basic block is no worse than > those imho. > > Signed-off-by: Andy Green Acked-by: Bruce Richardson