From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 25F8B2BFA for ; Tue, 22 May 2018 15:21:43 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id r13-v6so7813698wrj.10 for ; Tue, 22 May 2018 06:21:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/wNoNW4gmg87fb+hXaFlb8SCUQ0ammcUykHWDzwD4Ik=; b=mD6ve5Y0mKK30oiFs8oS6daBdoqJtYnfSkU3tr1YCESwbth0ATLjAaIQtfaDe3MWqx 3JHELbSzVbfNQDxok+knXyZ9mM2+Hkq7Vhr1DxEWmYmEvDXNN+LP1yJM3gkTGVj3DxpK GYb3sI7c1bh7TU0xLvUxyTjyTa5qTUdRhoTOSNBaZLGDJIP4WFvWsyJ0Fz/Y2TkwePgR 6KAECVgo4b8cyY8YWJrPm0EMxpVt2Ub0rHxIiJe4VG1dgyxBzQEwGPgJ+kmPWU2oPbGL iqWvpvnBlsgIk4tyQlN5JI5G1v/loO44U3KEcLPlDUGRXfYdZ6Jj0gI99pen8OZgFS2b lxYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/wNoNW4gmg87fb+hXaFlb8SCUQ0ammcUykHWDzwD4Ik=; b=kXsUGkbzGJIiPK8hRkFFBrHWdNoV4ArZUYnf5P63lZ4QB3Jxxvp9/YRmldN1/gNiKh /zp3WQ4ypkKmmx5qH/87D+1KLUcMSUH/bO021m/YkIW3rsLdHN7amOMV26tOpEBHEo+5 uKqsXgRc0cvoy9D1I4qy0FKQgmnRgT99Xgqc9FCBuZqY+BjfUPKf+pXO01vrltDiFFwi T0AuVFDrvM2UZE8Xb1jAdlwotYyGhlMAkQy5z3UBqpGzSI96XNCRAmRiMWisaTga5Wm6 D4okMpB92b5s44eU9et71XQDO7JEGP8mtDuOVfdon1g+EQk2VVQZgJonMWP71S3A3crJ 96iw== X-Gm-Message-State: ALKqPwcNcAswSXXboo6T9TkKOBBngqu6xVhExYQm/XJ5vVOGc8MKWTsh SwVlpab5MSj/feiFr5fBGDq81Q== X-Google-Smtp-Source: AB8JxZp2j7BBy6qbw7H1OxAhsBz8WHk+3+8WKbmftmP2DYY4W/PMrwgZGSsxkOSDgny9skBsmN7Ffg== X-Received: by 2002:adf:9bd7:: with SMTP id e23-v6mr18599344wrc.240.1526995302948; Tue, 22 May 2018 06:21:42 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 12-v6sm28405018wmn.27.2018.05.22.06.21.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 May 2018 06:21:42 -0700 (PDT) Date: Tue, 22 May 2018 15:21:27 +0200 From: Adrien Mazarguil To: Ferruh Yigit Cc: Shahaf Shuler , dev@dpdk.org Message-ID: <20180522132127.GW6497@6wind.com> References: <20180521154829.6297-2-adrien.mazarguil@6wind.com> <20180522112533.2785-1-adrien.mazarguil@6wind.com> <797d8b79-721c-1611-7b04-127eff7b31cc@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <797d8b79-721c-1611-7b04-127eff7b31cc@intel.com> Subject: Re: [dpdk-dev] [PATCH] net/mlx4: fix undefined behavior of RSS conversion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 13:21:43 -0000 On Tue, May 22, 2018 at 02:01:38PM +0100, Ferruh Yigit wrote: > On 5/22/2018 12:26 PM, Adrien Mazarguil wrote: > > As reported by ICC, an array initializer that uses values found in the > > array being initialized, although semantically correct (GCC and clang do > > not complain and generate correct code), results in undefined behavior > > since initialization order is itself undefined. > > > > This patch restores the static keyword and initializes array entries with > > constant expressions as a safety measure. > > > > Fixes: f76ccd763422 ("net/mlx4: refactor RSS conversion functions") > > > > Reported-by: Ferruh Yigit > > Signed-off-by: Adrien Mazarguil > > > > -- > > > > Shahaf, Ferruh, please remove the "Note the loss of the [...]" paragraph of > > the original commit if this patch gets squashed in it, as it is no longer > > relevant in that case. > > Squashed into relevant commit in next-net, thanks. > > Can you please confirm updated commit log? Looks good, thanks! -- Adrien Mazarguil 6WIND