From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0063.outbound.protection.outlook.com [104.47.34.63]) by dpdk.org (Postfix) with ESMTP id C2E0F2BF3 for ; Tue, 22 May 2018 15:49:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AvB6liB09492bagwENFr4HCU32fR9NsENAlYinkujNM=; b=Ij5fYpwtWFXvDRAQRqkA7thW1VRS8JmFPI494xnajLlwtNhndZjzrzXzy1tefng+RzV24GeVO0rVpHszLic9PiAOntxJJc5UnsD6DRTRT+t9FmV/vOIzQYrmU24+ZTL7nLT5EEOxJ1fRBaXdsSGLWyjYJDWUPO7vbw1lXDRfwUY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Shijith.Thotton@cavium.com; Received: from sthotton-lt.caveonetworks.com (111.93.218.67) by DM5PR07MB3017.namprd07.prod.outlook.com (2603:10b6:3:e3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.11; Tue, 22 May 2018 13:49:17 +0000 Date: Tue, 22 May 2018 19:19:02 +0530 From: Shijith Thotton To: yaochuhong Cc: shijith.thotton@cavium.com, dev@dpdk.org Message-ID: <20180522134901.GB18622@sthotton-lt.caveonetworks.com> References: <1526907495-120095-1-git-send-email-ych@panath.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1526907495-120095-1-git-send-email-ych@panath.cn> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR01CA0089.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1::29) To DM5PR07MB3017.namprd07.prod.outlook.com (2603:10b6:3:e3::15) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DM5PR07MB3017; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3017; 3:LpGVAQyHcubM1ocn5vmtI1B6AatFntZcaKTzTBitC8aT21ETjesK3FxNW7Z8zcGT4NAhNYphKQT3Qovuea71KGV//g1kLYNtOWnjenQJkW06UPyRZAt+MNyFb/NMPhOLqqgJ0SDMb2pLihcBXzrEqbOCDDoybXk5j7ouSUZPuE61xhTn2edroychgXDXA4Ix28hJkKZIS8b+kAJJ9x4AX1QqK7aHV3CSoekkrE9lgWH6fpB0oV8IuUenuK8F08qN; 25:Mh25QfgQvECkjy09U4cR/gtbU8LdNLuyC0K/O3WVDGR1qRGq1XInj8i/51a4jPlYrbZotKm79Fw0gy6Ah6s0B3WUEHEG/6BENrPbbBr7cm2OdL3vUdPaTJ2MFQ09bahTf1DjytNaMj7dK8G3OTG81NYn9q7Ey6u/StVevIoUu6MpU8v6jIA2fFodD9BEsLfl3fGyf0iXbbdUIcIQeGx4XziJQLvj4SvUQvgXDbhQBR1duCFcOTNbAn/uW6V1F9EWUQMM9yXGUoObxtps8XIAJRYkCEtIwduTqZ3zo6Y8mZQDu+9R5aiQmPn1mNKqK+dvvM5pD5sB5Gy6BtVb5WWORw==; 31:iVdfj5Dvt459LT2kDnSYztd6ttX+7qg1hEF01zifOY82LLXju/RbsrIZgCUCkpnL7b3ExBohDArqC0F1aRpehkx3/U6b+nSEpITSSflAoZ+F4hpBsyGPS/kEz6HDEhlx/weSA+rw2qgGWFADRtdTG8rrZqcmyjlQCCffF/LwVxU04znMLpEsFKVrMFGjy/xMFfwPvGnuZaurvnleSOJIB9jycVwQxTFche2ppmJbduE= X-MS-TrafficTypeDiagnostic: DM5PR07MB3017: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3017; 20:z3bMZZbiAi84MR85t1ICNn0QzAC+reXTluZJ27/5i2cjpfZH9n33Gt021fAPbzJv88IGd8D2uC8ElR+xfPw3NIuUQ0BUw/wCLgy3fFVKuEI1rhqDkLi1v5pWULcxbD3kw6Jifda+WzFGuyb0SiH7Lm1BK4qVo6KCpaXDCKYWcsguUZdrnV066uPNtH1KZRJW1KoIketQvqFssUsam2ARIy0QE3mJPIPH59zhuyWGg+gAgfy/a1fZHps/w2l82GT7vzWjgFxqXUbUE03dKYmwCOKXdKWjXvxG6oIN8UeDJoiqdNkfR+taEujeMhLDgtaxCmJ/ftI7Xs2/IHM02VauQEew2Hb0quHFfH56kwr1C6LHqng1nXah5zYuah/gnJkakluQLRY4DugGHXRYe5xgPu2Q1KIj9UH4/riKlpZp5d+o0Vzh3zA3li7/s69Ngjnr2xCGWSao3t63biiGdi1GE9UZkO1xXFSyukI0FhVEGYGOsIq6CGf9Ewwkx2MJzckBZum7d7ChAWDNw6rTL72UHHO2y56VB6vBkDsXP9CrCLlA0nMVLs2tg0vAfGsAfFtyuPNChNJ/3Y7mRWtvEgwhaFHHwAKGi++9YPr+XW8fojg=; 4:+fPmvQ3tnLT64P1s0X7ww0YiIamO8xi1C1hd7vIIsMbJf815dmZpw4WQIgfD3fc2YJJTaZpKV0NlSMwosM2QPkAqbiu7BDwSYWdtVVOPpboQ1hsoYiRyW57YEymT2FbQwEAes/yO8pB0vZCUS/3dtbPQe+lwoj4jfs2cvr1HENTbHBtiV4bXVVsOkhV6Bib3XdE3gfoM7monh98mlQPJejQ712KtQDPj4yeoaX76papk8k5VO6fbp7BjcswWqlfx/LQ/K5l6HxwdO3YBUP4VeA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(93006095)(10201501046)(3002001)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:DM5PR07MB3017; BCL:0; PCL:0; RULEID:; SRVR:DM5PR07MB3017; X-Forefront-PRVS: 0680FADD48 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(39380400002)(346002)(366004)(396003)(51914003)(189003)(199004)(81156014)(97736004)(6916009)(68736007)(8676002)(8936002)(6666003)(42882007)(59450400001)(23726003)(3846002)(6116002)(5009440100003)(5660300001)(7736002)(44832011)(2906002)(478600001)(15650500001)(305945005)(486006)(25786009)(72206003)(575784001)(81166006)(476003)(186003)(69596002)(956004)(26005)(11346002)(33656002)(446003)(55016002)(4326008)(16526019)(316002)(53936002)(66066001)(1076002)(9686003)(47776003)(229853002)(53416004)(386003)(58126008)(50466002)(6506007)(7696005)(52116002)(16586007)(6246003)(76176011)(106356001)(105586002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3017; H:sthotton-lt.caveonetworks.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3017; 23:vFBdTQPNF85acUWf74uVjvX/HeZcHHHjOs5URlNiF?= =?us-ascii?Q?wINr9LytFHhZWFCAePaLz9V5Q7WhG0Nzn9Evp2v/5szfwAx1WjSlRdbdoluv?= =?us-ascii?Q?3EM93FS8bj4Yfcovn5IYWleHKdT2mVSL43SUf9hDfDTu1IffRyUhRaqOcEMC?= =?us-ascii?Q?qx44imIcUJBbFpJtYckLdeE7qhIgdb33wjVq2cE1KzPdnAp8uyUyWnQvCtNR?= =?us-ascii?Q?mf/rNaIwcVfKHrmMBQf7Kld1Vw8Y4lhb3D/yB8xcl7H2vce2uirx/DlSZtRC?= =?us-ascii?Q?b+BwC3UVpclYTlyvuPemmsdI3YB5qqYOJeqvCMlqCf2PcDM8/saDk6smu6X7?= =?us-ascii?Q?nBdMPozKxz9yDADsceaRkTR12SZ9oxAb8xPiTu7+63qWNMAiOTLpPyermLe0?= =?us-ascii?Q?YluF5gZS6AO3qXLAeIjqqSxw991Pblp+efRodA1/8cVrPQh1A2O1V53CI7t1?= =?us-ascii?Q?nHfNeFU5Ic9qlqAqtkhBhwzRc0Z7S8sOXKXQvKcb9gxjTdwzzmsXC/Cy0xhg?= =?us-ascii?Q?dkMJ7Gm7cKDO4C6nlDz6fpOLVkrhHFiQEl5Pyn5V/NsmsZKQ0wjOfFAzjKaP?= =?us-ascii?Q?5x/smWcS5fNgqeSKYYLYp4hLsc3XqvfUXKs2dOKMXgHBPQwh+/WIRpk4lnQM?= =?us-ascii?Q?P/NwfICv9AuUm14cq6ifNyFFRJIzqh1Cel/1S20reKNOlj0U6Prqs8Wqlp9P?= =?us-ascii?Q?qkO+5aGbMZDnuXTVxokRzCm+MvbgiqwN6RG6YMtuDRKaeJBZ4q1YeOdTEMNo?= =?us-ascii?Q?7D0YyHXQbqnKtsKmTSTeVGgN8/LyOJVAe6OPUoL+MC4milPTDFDBzL7WZM/e?= =?us-ascii?Q?Nh2l9clOwvQfqLUc/E72dzRkYRW9o4y9lubHg19gsnFzxXs5Zk49OqjNac+H?= =?us-ascii?Q?QtE69aVHM1/tNkPfLeLSkfDSEQBDd7njZOyHHFQ7+DIS1uMgXpDil3WkVhKL?= =?us-ascii?Q?6aqbwALiifGEse1XGwkhxKuaOFCP7YQJpOvk4H8qnEzZ5LcRVUu7ai9jh4qW?= =?us-ascii?Q?aBUgbXVB601YJKnlumxIheNiFPYcTEhSmOdURX6JOP/AM0tuELYYIKfuMC6D?= =?us-ascii?Q?oGiKEka4OwEumN9nZNCLCp3Wvo0LDBRF4krY9bVMsJuWhCcbaLIwy8WDNFHH?= =?us-ascii?Q?lXn1RW28eczrdjnbEfxc/+nR195VLhG2fqk+eG4+P/kucDSpbIsNDw36/CnJ?= =?us-ascii?Q?jdHQOjSCMmalxWnr571trNY/g0Faq80KHjbiqERbKYmjBuIxbwtDsnKaog6s?= =?us-ascii?Q?qAgD949KAC6sRiEPcNsFkXHLIqwVKDwgMbEzdEBeT0zsdi1lw7PsPb3bvUDl?= =?us-ascii?Q?LTZmnG5Q94sD9aimi8pOaQOHxFC6/SOwIKQ7NzTOqdpIBUl8jZCRSJs8Kz3O?= =?us-ascii?Q?w7fYpLEswdjiFApsNkWTTN4uT/H53Q3G8Aww7+PwLL7pMt4cPYQ3X6hhdfdo?= =?us-ascii?Q?pJl2zIPnX4e8S9jroLBS8bWfwMD1ZKiRK+9Tfn6ZKnwBOXsEZZ0?= X-Microsoft-Antispam-Message-Info: qM/O58VUTmYT9cWVWg4sq2C+e1xch8HBSeXiGzEolDkYL7apTzOcuhlKf2qCzEs3M1KwpCshM2RYj/uRarjhAENDUQECOm3heWcQOZ5a9RYRVT8EXuJwmYvY7Y2mKNsgnV3ZcqujBE8lqDUICHmO0+HbFOLq8mDWclXgeyhg+hsvhMZOp5l6BI/5tG4u9k02 X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3017; 6:N6JYN+IkON8Bu9/UiGyIBDMnX/Vo9RAQniOPPklTIGS+lbyswHiOSz2IfQOJ5I0fcA/W++F8GtvRq8enjZDKpTN47KHC64HSh1cWgZins+gt6LtI8Sba0wKMqeuVy7ap7vL0A2RX2zHQdFQe4sdRqXMS+J8JUdTSFwvDuNsQDx0KhEYjspnlDSC2obeU1MioXws4JkQKtU+xxG0F7GB07npIVxunCpFbztTOyjorkyNQ1xd9CuSslezpnkPHZl6pVPqLCq9rUIUF9iURZGKntMMv5MijXEY9F1MutvXzRNyD0bXsS3gqjiLXGh0ZAI8WjzcYsrHgFQFBYZkqyCFbQkBQVyvY40h4B+4tFHkKHfDfXxiIDRtbK6GFFYU6ENsPVrrZpDhe/ZjkrTGOUvvsip0JijPeJIjg5ME2vbkAfN6qelcHfVSGT48pvNEiKvhtxE15KAg/BGvVN7ouFVvu6A==; 5:2qmEzAB7rRFk+AbFIA80fSQ4uUU56yDFSxDFPeH8iRyviPhGV5taQeNoOpY6Ia5ozODAJRvDIUq+HYRHsc65dv+oSWdyh2ik3lz72e1Yy+S5wTFzQajgr15vLGWNmURE5biaAC1zGa9N3P3Hzg6IA08hak6pyJjMcwrA7ysZutE=; 24:tu/IMI7JOIgydFoWWBRbBbIBLi3kg/Fxcy6K+1mBtonjBzdOrD/JHJNIzsTn7mi33gguXEHJJsyZOKR0A8xZ9VaRV+yJLOy+ly4EUHMVOhs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3017; 7:C9UP/UObV9WjNDlNnSuE+RMikmZsom7Q7LFSDzeDkWeh9XkDqaNU/szsImODaZzaZnCIX1CW/FFwPnQ3Sr/lsN7JaF0F4huqXmoEKD7pDQanaB3wc/h6xA5rSDHKaZVOqgF7BHDG9vk7azXn86mrshuphvC90g8nZzCzzy++dkutfhq0jjEpa8yfgeqcc+mqtutX0r0ogGIdCYxkOwZyxZwSHG84lnbN88u0Qp+ZIITtwztG/OcWoDFQEnOhKagR X-MS-Office365-Filtering-Correlation-Id: 5f64cf35-55d1-4f52-3862-08d5bfead0fa X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2018 13:49:17.9603 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5f64cf35-55d1-4f52-3862-08d5bfead0fa X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3017 Subject: Re: [dpdk-dev] [PATCH] net/liquidio:Fix Unable to update lio_dev->linfo.link var X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 13:49:21 -0000 On Mon, May 21, 2018 at 08:58:15PM +0800, yaochuhong wrote: > When I was using VPP +dpdk-18.02+liqudio CN23xx, I encountered such a bug. \n > When VPP called dpdk_device_start to initialize DPDK liqudio drive, I found that initialization failed. \n > The reason for the failure is that VF MTU > PF MTU, but PF MTU has been modified to 9600 (> VF MTU). \n > Finally, I am location that DPDK liqudio drive cannot get the correct PF driver to liqudio network card. \n > It is due to the fact that when VPP calls dpdk_device_start to initialize DPDK liqudio drive, \n > this time, lio_dev->linfo. Link var already exists in the old value, not empty. \n > Cause lio_dev - > linfo. Link. Link_status64 != 0 statement is set up, \n > and the link info is stopped directly to liqudio card, resulting in no get accurate pf mtu. \n > I did a test model to reproduce the bug, which is to add rte_eth_dev_set_mtu(portid, vf_mtu) \n > to the rte_eth_dev_start function when using dpdk-18.02+liqudio CN23xx+l2fwd. \n > You need to make sure that 1500 < vf_mtu < pf_mtu will be available. \n > At this time, you will have net_liovf[04:00.3]ERROR: lio_dev_mtu_set() VF MTU should be >= 68 and <= 1500. Such a mistake. \n > ps:I am a novice git. Please understand the trouble caused by this. > > Signed-off-by: yaochuhong > --- > drivers/net/liquidio/lio_ethdev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c > index 0e0b5d8..50743c7 100644 > --- a/drivers/net/liquidio/lio_ethdev.c > +++ b/drivers/net/liquidio/lio_ethdev.c > @@ -1405,6 +1405,9 @@ struct rte_lio_xstats_name_off { > /* Configure RSS if device configured with multiple RX queues. */ > lio_dev_mq_rx_configure(eth_dev); > > + /* Before update the link info, must set linfo.link.link_status64 to 0. */ > + lio_dev->linfo.link.link_status64 = 0; > + > /* start polling for lsc */ > ret = rte_eal_alarm_set(LIO_LSC_TIMEOUT, > lio_sync_link_state_check, > -- > 1.8.3.1 > Hi Yao, Thanks for the catch! Please send a v2 with corrections to commit log. Acked-by: Shijith Thotton