From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Nikhil Rao <nikhil.rao@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eventdev: fix eth port in eth Rx adapter internal function
Date: Wed, 23 May 2018 11:21:20 +0530 [thread overview]
Message-ID: <20180523055118.GA10924@jerin> (raw)
In-Reply-To: <1527023202-51808-1-git-send-email-nikhil.rao@intel.com>
-----Original Message-----
> Date: Wed, 23 May 2018 02:36:42 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
> Subject: [PATCH] eventdev: fix eth port in eth Rx adapter internal function
> X-Mailer: git-send-email 1.8.3.1
>
> The dev_id parameter to fill_event_buffer() should be 16 bit,
> also rename to to eth_dev_id to avoid confusion with event device
> id elsewhere in the file.
>
> Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit")
> Cc: stable@dpdk.org
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> lib/librte_eventdev/rte_event_eth_rx_adapter.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> index 6f70509..273df1e 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> @@ -418,14 +418,14 @@ static uint16_t gcd_u16(uint16_t a, uint16_t b)
>
> static inline void
> fill_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter,
> - uint8_t dev_id,
> + uint16_t eth_dev_id,
> uint16_t rx_queue_id,
> struct rte_mbuf **mbufs,
> uint16_t num)
> {
> uint32_t i;
> struct eth_device_info *eth_device_info =
> - &rx_adapter->eth_devices[dev_id];
> + &rx_adapter->eth_devices[eth_dev_id];
> struct eth_rx_queue_info *eth_rx_queue_info =
> ð_device_info->rx_queue[rx_queue_id];
>
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2018-05-23 5:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 21:06 Nikhil Rao
2018-05-23 5:51 ` Jerin Jacob [this message]
2018-05-24 20:55 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-06-03 7:23 ` Rao, Nikhil
2018-06-04 2:58 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523055118.GA10924@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=nikhil.rao@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).