* [dpdk-dev] [PATCH] baseband/turbo_sw: internal buffers names changed @ 2018-05-24 7:46 Kamil Chalupnik 2018-05-24 9:20 ` [dpdk-dev] [PATCH v2] " Kamil Chalupnik 0 siblings, 1 reply; 5+ messages in thread From: Kamil Chalupnik @ 2018-05-24 7:46 UTC (permalink / raw) To: amr.mokhtar, pablo.de.lara.guarch; +Cc: dev, Kamil Chalupnik Internal buffers names have been shortened to meet ring names size requirements after device name changed. Signed-off-by: Kamil Chalupnik <kamilx.chalupnik@intel.com> --- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c index d3e5103..bb9772a 100644 --- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c +++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c @@ -302,7 +302,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id, /* Allocate memory for Deinterleaver input. */ ret = snprintf(name, RTE_RING_NAMESIZE, - RTE_STR(DRIVER_NAME)"_deint_input%u:%u", + RTE_STR(DRIVER_NAME)"_de_in%u:%u", dev->data->dev_id, q_id); if ((ret < 0) || (ret >= (int)RTE_RING_NAMESIZE)) { rte_bbdev_log(ERR, @@ -321,7 +321,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id, /* Allocate memory for Deinterleaver output. */ ret = snprintf(name, RTE_RING_NAMESIZE, - RTE_STR(DRIVER_NAME)"_deint_output%u:%u", + RTE_STR(DRIVER_NAME)"_de_out%u:%u", dev->data->dev_id, q_id); if ((ret < 0) || (ret >= (int)RTE_RING_NAMESIZE)) { rte_bbdev_log(ERR, @@ -340,7 +340,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id, /* Allocate memory for Adapter output. */ ret = snprintf(name, RTE_RING_NAMESIZE, - RTE_STR(DRIVER_NAME)"_adapter_output%u:%u", + RTE_STR(DRIVER_NAME)"_ada_out%u:%u", dev->data->dev_id, q_id); if ((ret < 0) || (ret >= (int)RTE_RING_NAMESIZE)) { rte_bbdev_log(ERR, -- 2.5.5 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v2] baseband/turbo_sw: internal buffers names changed 2018-05-24 7:46 [dpdk-dev] [PATCH] baseband/turbo_sw: internal buffers names changed Kamil Chalupnik @ 2018-05-24 9:20 ` Kamil Chalupnik 2018-05-24 10:25 ` Mokhtar, Amr 2018-05-24 12:41 ` [dpdk-dev] [PATCH v3] " Kamil Chalupnik 0 siblings, 2 replies; 5+ messages in thread From: Kamil Chalupnik @ 2018-05-24 9:20 UTC (permalink / raw) To: dev; +Cc: amr.mokhtar, pablo.de.lara.guarch, Kamil Chalupnik Internal buffers names have been shortened to meet ring names size requirements after device name changed. Signed-off-by: Kamil Chalupnik <kamilx.chalupnik@intel.com> --- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c index d3e5103..05e95ed 100644 --- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c +++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c @@ -227,7 +227,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id, } /* Allocate memory for encoder output. */ - ret = snprintf(name, RTE_RING_NAMESIZE, RTE_STR(DRIVER_NAME)"_enc_out%u:%u", + ret = snprintf(name, RTE_RING_NAMESIZE, RTE_STR(DRIVER_NAME)"_enc_o%u:%u", dev->data->dev_id, q_id); if ((ret < 0) || (ret >= (int)RTE_RING_NAMESIZE)) { rte_bbdev_log(ERR, @@ -247,7 +247,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id, /* Allocate memory for rate matching output. */ ret = snprintf(name, RTE_RING_NAMESIZE, - RTE_STR(DRIVER_NAME)"_enc_in%u:%u", dev->data->dev_id, + RTE_STR(DRIVER_NAME)"_enc_i%u:%u", dev->data->dev_id, q_id); if ((ret < 0) || (ret >= (int)RTE_RING_NAMESIZE)) { rte_bbdev_log(ERR, @@ -302,7 +302,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id, /* Allocate memory for Deinterleaver input. */ ret = snprintf(name, RTE_RING_NAMESIZE, - RTE_STR(DRIVER_NAME)"_deint_input%u:%u", + RTE_STR(DRIVER_NAME)"_de_i%u:%u", dev->data->dev_id, q_id); if ((ret < 0) || (ret >= (int)RTE_RING_NAMESIZE)) { rte_bbdev_log(ERR, @@ -321,7 +321,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id, /* Allocate memory for Deinterleaver output. */ ret = snprintf(name, RTE_RING_NAMESIZE, - RTE_STR(DRIVER_NAME)"_deint_output%u:%u", + RTE_STR(DRIVER_NAME)"_de_o%u:%u", dev->data->dev_id, q_id); if ((ret < 0) || (ret >= (int)RTE_RING_NAMESIZE)) { rte_bbdev_log(ERR, @@ -340,7 +340,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id, /* Allocate memory for Adapter output. */ ret = snprintf(name, RTE_RING_NAMESIZE, - RTE_STR(DRIVER_NAME)"_adapter_output%u:%u", + RTE_STR(DRIVER_NAME)"_ada_o%u:%u", dev->data->dev_id, q_id); if ((ret < 0) || (ret >= (int)RTE_RING_NAMESIZE)) { rte_bbdev_log(ERR, -- 2.5.5 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: internal buffers names changed 2018-05-24 9:20 ` [dpdk-dev] [PATCH v2] " Kamil Chalupnik @ 2018-05-24 10:25 ` Mokhtar, Amr 2018-05-24 12:41 ` [dpdk-dev] [PATCH v3] " Kamil Chalupnik 1 sibling, 0 replies; 5+ messages in thread From: Mokhtar, Amr @ 2018-05-24 10:25 UTC (permalink / raw) To: Chalupnik, KamilX, dev; +Cc: De Lara Guarch, Pablo > -----Original Message----- > From: Chalupnik, KamilX > Sent: Thursday 24 May 2018 10:20 > To: dev@dpdk.org > Cc: Mokhtar, Amr <amr.mokhtar@intel.com>; De Lara Guarch, Pablo > <pablo.de.lara.guarch@intel.com>; Chalupnik, KamilX > <kamilx.chalupnik@intel.com> > Subject: [PATCH v2] baseband/turbo_sw: internal buffers names changed > > Internal buffers names have been shortened to meet ring names size > requirements after device name changed. > > Signed-off-by: Kamil Chalupnik <kamilx.chalupnik@intel.com> > --- It should have "Fixes: XXX" tag because it is a fix for a previous patch. But the fix itself is ok with me. Feel free to retain my "Acked-by" tag in the next patch when you add the "Fixes" tag Acked-by: Amr Mokhtar <amr.mokhtar@intel.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v3] baseband/turbo_sw: internal buffers names changed 2018-05-24 9:20 ` [dpdk-dev] [PATCH v2] " Kamil Chalupnik 2018-05-24 10:25 ` Mokhtar, Amr @ 2018-05-24 12:41 ` Kamil Chalupnik 2018-05-28 1:19 ` Thomas Monjalon 1 sibling, 1 reply; 5+ messages in thread From: Kamil Chalupnik @ 2018-05-24 12:41 UTC (permalink / raw) To: dev; +Cc: amr.mokhtar, pablo.de.lara.guarch, Kamil Chalupnik Internal buffers names have been shortened to meet ring names size requirements after device name changed. Fixes: 7ce00bf31bbe ("bbdev: change names of baseband devices") Signed-off-by: Kamil Chalupnik <kamilx.chalupnik@intel.com> Acked-by: Amr Mokhtar <amr.mokhtar@intel.com> --- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c index d3e5103..05e95ed 100644 --- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c +++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c @@ -227,7 +227,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id, } /* Allocate memory for encoder output. */ - ret = snprintf(name, RTE_RING_NAMESIZE, RTE_STR(DRIVER_NAME)"_enc_out%u:%u", + ret = snprintf(name, RTE_RING_NAMESIZE, RTE_STR(DRIVER_NAME)"_enc_o%u:%u", dev->data->dev_id, q_id); if ((ret < 0) || (ret >= (int)RTE_RING_NAMESIZE)) { rte_bbdev_log(ERR, @@ -247,7 +247,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id, /* Allocate memory for rate matching output. */ ret = snprintf(name, RTE_RING_NAMESIZE, - RTE_STR(DRIVER_NAME)"_enc_in%u:%u", dev->data->dev_id, + RTE_STR(DRIVER_NAME)"_enc_i%u:%u", dev->data->dev_id, q_id); if ((ret < 0) || (ret >= (int)RTE_RING_NAMESIZE)) { rte_bbdev_log(ERR, @@ -302,7 +302,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id, /* Allocate memory for Deinterleaver input. */ ret = snprintf(name, RTE_RING_NAMESIZE, - RTE_STR(DRIVER_NAME)"_deint_input%u:%u", + RTE_STR(DRIVER_NAME)"_de_i%u:%u", dev->data->dev_id, q_id); if ((ret < 0) || (ret >= (int)RTE_RING_NAMESIZE)) { rte_bbdev_log(ERR, @@ -321,7 +321,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id, /* Allocate memory for Deinterleaver output. */ ret = snprintf(name, RTE_RING_NAMESIZE, - RTE_STR(DRIVER_NAME)"_deint_output%u:%u", + RTE_STR(DRIVER_NAME)"_de_o%u:%u", dev->data->dev_id, q_id); if ((ret < 0) || (ret >= (int)RTE_RING_NAMESIZE)) { rte_bbdev_log(ERR, @@ -340,7 +340,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id, /* Allocate memory for Adapter output. */ ret = snprintf(name, RTE_RING_NAMESIZE, - RTE_STR(DRIVER_NAME)"_adapter_output%u:%u", + RTE_STR(DRIVER_NAME)"_ada_o%u:%u", dev->data->dev_id, q_id); if ((ret < 0) || (ret >= (int)RTE_RING_NAMESIZE)) { rte_bbdev_log(ERR, -- 2.5.5 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v3] baseband/turbo_sw: internal buffers names changed 2018-05-24 12:41 ` [dpdk-dev] [PATCH v3] " Kamil Chalupnik @ 2018-05-28 1:19 ` Thomas Monjalon 0 siblings, 0 replies; 5+ messages in thread From: Thomas Monjalon @ 2018-05-28 1:19 UTC (permalink / raw) To: Kamil Chalupnik; +Cc: dev, amr.mokhtar, pablo.de.lara.guarch 24/05/2018 14:41, Kamil Chalupnik: > Internal buffers names have been shortened to meet ring names size > requirements after device name changed. > > Fixes: 7ce00bf31bbe ("bbdev: change names of baseband devices") > > Signed-off-by: Kamil Chalupnik <kamilx.chalupnik@intel.com> > Acked-by: Amr Mokhtar <amr.mokhtar@intel.com> Considered it is critical. Applied, thanks ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-05-28 1:19 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-05-24 7:46 [dpdk-dev] [PATCH] baseband/turbo_sw: internal buffers names changed Kamil Chalupnik 2018-05-24 9:20 ` [dpdk-dev] [PATCH v2] " Kamil Chalupnik 2018-05-24 10:25 ` Mokhtar, Amr 2018-05-24 12:41 ` [dpdk-dev] [PATCH v3] " Kamil Chalupnik 2018-05-28 1:19 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).