* [dpdk-dev] [PATCH] doc: announce removal of indirect mbuf check macro
@ 2018-05-25 0:53 Yongseok Koh
2018-05-25 1:20 ` [dpdk-dev] [PATCH v2] " Yongseok Koh
0 siblings, 1 reply; 6+ messages in thread
From: Yongseok Koh @ 2018-05-25 0:53 UTC (permalink / raw)
To: olivier.matz, thomas
Cc: dev, arybchenko, konstantin.ananyev, stephen, Yongseok Koh
Link: http://dpdk.org/ml/archives/dev/2018-April/099476.html
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
doc/guides/rel_notes/deprecation.rst | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 1e2443c76..44da16445 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -42,6 +42,11 @@ Deprecation Notices
is defined in librte_sched in a non-generic way. The new generic format
will contain: queue ID, traffic class, color. Field size will not change.
+* mbuf: the macro ``RTE_MBUF_INDIRECT()`` will be removed in v18.08 and replaced
+ with ``RTE_MBUF_CLONED()``. As EXT_ATTACHED_MBUF is introduced in v18.05,
+ ``RTE_MBUF_INDIRECT()`` is no longer mutually exclusive with
+ ``RTE_MBUF_DIRECT()``. This change will fix the semantic inconsistency.
+
* ethdev: a new Tx and Rx offload API was introduced on 17.11.
In the new API, offloads are divided into per-port and per-queue offloads.
Offloads are disabled by default and enabled per application request.
--
2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] doc: announce removal of indirect mbuf check macro
2018-05-25 0:53 [dpdk-dev] [PATCH] doc: announce removal of indirect mbuf check macro Yongseok Koh
@ 2018-05-25 1:20 ` Yongseok Koh
2018-05-25 6:34 ` Andrew Rybchenko
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Yongseok Koh @ 2018-05-25 1:20 UTC (permalink / raw)
To: olivier.matz, thomas
Cc: dev, arybchenko, konstantin.ananyev, stephen, Yongseok Koh
Link: http://dpdk.org/ml/archives/dev/2018-April/099476.html
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
v2:
* modify removal deadline and add more comments in the deprecation note
* mark deprecation on the comment of the macro in rte_mbuf.h
doc/guides/rel_notes/deprecation.rst | 7 +++++++
lib/librte_mbuf/rte_mbuf.h | 3 ++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 1e2443c76..e1630c2cf 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -42,6 +42,13 @@ Deprecation Notices
is defined in librte_sched in a non-generic way. The new generic format
will contain: queue ID, traffic class, color. Field size will not change.
+* mbuf: the macro ``RTE_MBUF_INDIRECT()`` will be removed in v18.08 or later and
+ replaced with ``RTE_MBUF_CLONED()`` which is already added in v18.05. As
+ ``EXT_ATTACHED_MBUF`` is newly introduced in v18.05, ``RTE_MBUF_INDIRECT()``
+ can no longer be mutually exclusive with ``RTE_MBUF_DIRECT()`` if the new
+ experimental API ``rte_pktmbuf_attach_extbuf()`` is used. Removal of the macro
+ is to fix this semantic inconsistency.
+
* ethdev: a new Tx and Rx offload API was introduced on 17.11.
In the new API, offloads are divided into per-port and per-queue offloads.
Offloads are disabled by default and enabled per application request.
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index e136d12b7..8e6b4d292 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -738,7 +738,8 @@ rte_mbuf_to_baddr(struct rte_mbuf *md)
#define RTE_MBUF_CLONED(mb) ((mb)->ol_flags & IND_ATTACHED_MBUF)
/**
- * Returns TRUE if given mbuf is indirect, or FALSE otherwise.
+ * Deprecated.
+ * Use RTE_MBUF_CLONED().
*/
#define RTE_MBUF_INDIRECT(mb) RTE_MBUF_CLONED(mb)
--
2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2] doc: announce removal of indirect mbuf check macro
2018-05-25 1:20 ` [dpdk-dev] [PATCH v2] " Yongseok Koh
@ 2018-05-25 6:34 ` Andrew Rybchenko
2018-05-25 7:20 ` Olivier Matz
2018-05-27 4:36 ` Shahaf Shuler
2 siblings, 0 replies; 6+ messages in thread
From: Andrew Rybchenko @ 2018-05-25 6:34 UTC (permalink / raw)
To: Yongseok Koh, olivier.matz, thomas; +Cc: dev, konstantin.ananyev, stephen
On 05/25/2018 04:20 AM, Yongseok Koh wrote:
> Link: http://dpdk.org/ml/archives/dev/2018-April/099476.html
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
>
> v2:
> * modify removal deadline and add more comments in the deprecation note
> * mark deprecation on the comment of the macro in rte_mbuf.h
>
> doc/guides/rel_notes/deprecation.rst | 7 +++++++
> lib/librte_mbuf/rte_mbuf.h | 3 ++-
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 1e2443c76..e1630c2cf 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -42,6 +42,13 @@ Deprecation Notices
> is defined in librte_sched in a non-generic way. The new generic format
> will contain: queue ID, traffic class, color. Field size will not change.
>
> +* mbuf: the macro ``RTE_MBUF_INDIRECT()`` will be removed in v18.08 or later and
> + replaced with ``RTE_MBUF_CLONED()`` which is already added in v18.05. As
> + ``EXT_ATTACHED_MBUF`` is newly introduced in v18.05, ``RTE_MBUF_INDIRECT()``
> + can no longer be mutually exclusive with ``RTE_MBUF_DIRECT()`` if the new
> + experimental API ``rte_pktmbuf_attach_extbuf()`` is used. Removal of the macro
> + is to fix this semantic inconsistency.
> +
> * ethdev: a new Tx and Rx offload API was introduced on 17.11.
> In the new API, offloads are divided into per-port and per-queue offloads.
> Offloads are disabled by default and enabled per application request.
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index e136d12b7..8e6b4d292 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -738,7 +738,8 @@ rte_mbuf_to_baddr(struct rte_mbuf *md)
> #define RTE_MBUF_CLONED(mb) ((mb)->ol_flags & IND_ATTACHED_MBUF)
>
> /**
> - * Returns TRUE if given mbuf is indirect, or FALSE otherwise.
> + * Deprecated.
> + * Use RTE_MBUF_CLONED().
> */
> #define RTE_MBUF_INDIRECT(mb) RTE_MBUF_CLONED(mb)
>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] doc: announce removal of indirect mbuf check macro
2018-05-25 1:20 ` [dpdk-dev] [PATCH v2] " Yongseok Koh
2018-05-25 6:34 ` Andrew Rybchenko
@ 2018-05-25 7:20 ` Olivier Matz
2018-05-28 0:54 ` Thomas Monjalon
2018-05-27 4:36 ` Shahaf Shuler
2 siblings, 1 reply; 6+ messages in thread
From: Olivier Matz @ 2018-05-25 7:20 UTC (permalink / raw)
To: Yongseok Koh; +Cc: thomas, dev, arybchenko, konstantin.ananyev, stephen
On Thu, May 24, 2018 at 06:20:06PM -0700, Yongseok Koh wrote:
> Link: http://dpdk.org/ml/archives/dev/2018-April/099476.html
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] doc: announce removal of indirect mbuf check macro
2018-05-25 7:20 ` Olivier Matz
@ 2018-05-28 0:54 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2018-05-28 0:54 UTC (permalink / raw)
To: Olivier Matz; +Cc: dev, Yongseok Koh, arybchenko, konstantin.ananyev, stephen
25/05/2018 09:20, Olivier Matz:
> On Thu, May 24, 2018 at 06:20:06PM -0700, Yongseok Koh wrote:
> > Link: http://dpdk.org/ml/archives/dev/2018-April/099476.html
> >
> > Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] doc: announce removal of indirect mbuf check macro
2018-05-25 1:20 ` [dpdk-dev] [PATCH v2] " Yongseok Koh
2018-05-25 6:34 ` Andrew Rybchenko
2018-05-25 7:20 ` Olivier Matz
@ 2018-05-27 4:36 ` Shahaf Shuler
2 siblings, 0 replies; 6+ messages in thread
From: Shahaf Shuler @ 2018-05-27 4:36 UTC (permalink / raw)
To: Yongseok Koh, olivier.matz, Thomas Monjalon
Cc: dev, arybchenko, konstantin.ananyev, stephen, Yongseok Koh
Friday, May 25, 2018 4:20 AM, Yongseok Koh:
> Subject: [dpdk-dev] [PATCH v2] doc: announce removal of indirect mbuf
> check macro
>
> Link:
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpd
> k.org%2Fml%2Farchives%2Fdev%2F2018-
> April%2F099476.html&data=02%7C01%7Cshahafs%40mellanox.com%7Ccaccc
> ead653640735e3308d5c1ddb6b0%7Ca652971c7d2e4d9ba6a4d149256f461b%7
> C0%7C0%7C636628080378790994&sdata=7JOFTPtuU4OYWowtwEKp3BaK5aS
> 8idulFiGhLEHRIkU%3D&reserved=0
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
>
> v2:
> * modify removal deadline and add more comments in the deprecation note
> * mark deprecation on the comment of the macro in rte_mbuf.h
>
> doc/guides/rel_notes/deprecation.rst | 7 +++++++
> lib/librte_mbuf/rte_mbuf.h | 3 ++-
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 1e2443c76..e1630c2cf 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -42,6 +42,13 @@ Deprecation Notices
> is defined in librte_sched in a non-generic way. The new generic format
> will contain: queue ID, traffic class, color. Field size will not change.
>
> +* mbuf: the macro ``RTE_MBUF_INDIRECT()`` will be removed in v18.08 or
> +later and
> + replaced with ``RTE_MBUF_CLONED()`` which is already added in v18.05.
> +As
> + ``EXT_ATTACHED_MBUF`` is newly introduced in v18.05,
> +``RTE_MBUF_INDIRECT()``
> + can no longer be mutually exclusive with ``RTE_MBUF_DIRECT()`` if the
> +new
> + experimental API ``rte_pktmbuf_attach_extbuf()`` is used. Removal of
> +the macro
> + is to fix this semantic inconsistency.
> +
> * ethdev: a new Tx and Rx offload API was introduced on 17.11.
> In the new API, offloads are divided into per-port and per-queue offloads.
> Offloads are disabled by default and enabled per application request.
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index
> e136d12b7..8e6b4d292 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -738,7 +738,8 @@ rte_mbuf_to_baddr(struct rte_mbuf *md)
> #define RTE_MBUF_CLONED(mb) ((mb)->ol_flags &
> IND_ATTACHED_MBUF)
>
> /**
> - * Returns TRUE if given mbuf is indirect, or FALSE otherwise.
> + * Deprecated.
> + * Use RTE_MBUF_CLONED().
> */
> #define RTE_MBUF_INDIRECT(mb) RTE_MBUF_CLONED(mb)
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
>
> --
> 2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-28 0:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-25 0:53 [dpdk-dev] [PATCH] doc: announce removal of indirect mbuf check macro Yongseok Koh
2018-05-25 1:20 ` [dpdk-dev] [PATCH v2] " Yongseok Koh
2018-05-25 6:34 ` Andrew Rybchenko
2018-05-25 7:20 ` Olivier Matz
2018-05-28 0:54 ` Thomas Monjalon
2018-05-27 4:36 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).