From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 66069DE3 for ; Fri, 25 May 2018 10:54:35 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 May 2018 01:54:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,439,1520924400"; d="scan'208";a="52096737" Received: from debian.sh.intel.com (HELO debian) ([10.67.104.203]) by FMSMGA003.fm.intel.com with ESMTP; 25 May 2018 01:54:33 -0700 Date: Fri, 25 May 2018 16:54:54 +0800 From: Tiwei Bie To: Ferruh Yigit Cc: maxime.coquelin@redhat.com, john.mcnamara@intel.com, marko.kovacevic@intel.com, dev@dpdk.org, Wenzhuo Lu Message-ID: <20180525085454.GA15338@debian> References: <20180525061748.16184-1-tiwei.bie@intel.com> <5534310e-3539-87d8-95c9-befc1c4c9b4f@intel.com> <20180525082736.GA4935@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180525082736.GA4935@debian> User-Agent: Mutt/1.9.5 (2018-04-13) Subject: Re: [dpdk-dev] [PATCH] doc: address the offload API changes for virtio guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 May 2018 08:54:35 -0000 On Fri, May 25, 2018 at 04:27:36PM +0800, Tiwei Bie wrote: > On Fri, May 25, 2018 at 09:20:08AM +0100, Ferruh Yigit wrote: > > On 5/25/2018 7:17 AM, Tiwei Bie wrote: > > > Signed-off-by: Tiwei Bie > > > > <...> > > > > > @@ -252,7 +252,7 @@ The corresponding callbacks are: > > > Example of using the vector version of the virtio poll mode driver in > > > ``testpmd``:: > > > > > > - testpmd -l 0-2 -n 4 -- -i --txqflags=0xF01 --rxq=1 --txq=1 --nb-cores=1 > > > + testpmd -l 0-2 -n 4 -- -i --tx-offloads=0x0 --rxq=1 --txq=1 --nb-cores=1 > > > > Thanks, I missed this one, there are a few occurrence of "--txqflags" [1]. > > > > Tiwei would you mind sending another patch for those? > > In below context "--txqflags" is not really focus, I think we can just remove it > > without replacing with "--tx-offloads" > > No problem. I will do it now. :) > > Best regards, > Tiwei Bie > > > > > Thanks, > > ferruh > > > > > > [1] > > doc/guides/contributing/documentation.rst: -- -i --txqflags=0x0 > > --enable-hw-vlan --enable-lro \ > > doc/guides/howto/vfd.rst: testpmd -l 0-7 -n 4 -- -i --txqflags=0 > > doc/guides/howto/vfd.rst: testpmd -l 0-7 -n 4 -- -i --txqflags=0 Hmm.. After a closer look, I think above two --txqflags can't be simply removed. In this guide, it needs to demonstrate these offloads, e.g. VLAN insertion: http://dpdk.org/browse/dpdk/tree/doc/guides/howto/vfd.rst?h=v18.05-rc5#n155 Right now, unfortunately I'm being busy with preparing a QEMU patch set which I need to get it done today. So I'm afraid that I don't have time to look into this today.. I'm Sorry.. :( Best regards, Tiwei Bie > > doc/guides/howto/virtio_user_as_exceptional_path.rst: -- -i > > --txqflags=0x0 --enable-lro \ > > doc/guides/howto/virtio_user_as_exceptional_path.rst: -- -i > > --txqflags=0x0 --enable-lro \ > > doc/guides/howto/virtio_user_for_container_networking.rst: -- -i > > --txqflags=0xf00 --disable-hw-vlan