From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 8A9202BF4 for ; Fri, 25 May 2018 18:15:54 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id a8-v6so15797309wmg.5 for ; Fri, 25 May 2018 09:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=Hb4Gt8P7yzZ91rLjcoZPCjP9dIgymBfrbwjKK7BeLL0=; b=QNcZcCgO3vGso0pGLtnYCuXglHnnN3ArWonTNtCZiiKVuH3JUS8wlm5GWuxFXdNVg9 tRqxEsH/t4Bfvi3EOjDj8WQcGwBVEmxyLP7QBO9XLiC2QRKrbU9GOBSDzt/QvuG0LN3m ArqrcOULlNy5TOd0RHRWekJVySYFMvXLjOhDAoRSlwKrougJykbkLgcbShb1JLLUNogT RgJxQppmxYwomkWLa7pPpvLSxu+HcHtG3+Z6r5k1C0Bac7otLrmyielLHwxfZufpeNlr +rsRx2UGVB98K80d+uLjvsV0Av5fNLtBU7L2c4AeWMNGBQfKX8mdOdrANV+T8unAqFZ6 22Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=Hb4Gt8P7yzZ91rLjcoZPCjP9dIgymBfrbwjKK7BeLL0=; b=ImBA3LcvAAQ2r4etnJt+V8DHQ5nyQYly1rmA9+C+d/srob2czaEyPMf4jc+xsHFho2 uVWuWn5YrYoij7P5ogeBYJcBhcS0epY2pQH/x92sViiHUflgk7X6rxwMCNPtTTysawNe W8LBfR8wdYjG8hgyTOoH2ECm8mf7EtyQoBClOOyUy47VmTPUWRy3rbHoCzzZd62qcdxK A3DWD6OvKCX3fjOztySk3wFDN3NESgU3tpVADPlDuWAvyevAnbAP2QithBtoiHx2Zx1e 8HMwmJ8TPwGDelgGWL+iE/4rXTqkFn2fjfKfoFEHAOSU8OHzIiT8jTh/HWfnkUWJIMA1 iFyQ== X-Gm-Message-State: ALKqPweZqXz6wfvP2HdHAZttJVxg6g1DsD5IL67Knr5IKI8Sik8z2vWi pypR0RvZi2AGvgLOg6t7rfxZDQ== X-Google-Smtp-Source: ADUXVKKYI6JShlDjQpYkJiUhg8rrT1ESFq0bltKmwAaJAjxRfjB3d7n0C/mQcbg+YPL/qFZAbAKALw== X-Received: by 2002:a1c:f52:: with SMTP id 79-v6mr2462580wmp.24.1527264954222; Fri, 25 May 2018 09:15:54 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k28-v6sm30346089wrk.46.2018.05.25.09.15.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 May 2018 09:15:53 -0700 (PDT) Date: Fri, 25 May 2018 18:15:36 +0200 From: Adrien Mazarguil To: Shahaf Shuler Cc: dev@dpdk.org Message-ID: <20180525161428.13682-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH] net/mlx5: fix error message in probe function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 May 2018 16:15:54 -0000 Error values passed to strerror() must be positive. Fixes: 012ad9944dfc ("net/mlx5: fix probe return value polarity") Cc: Shahaf Shuler Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 11b395b64..9b78f9879 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -953,9 +953,9 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, priv->mtu = ETHER_MTU; err = mlx5_args(&config, pci_dev->device.devargs); if (err) { - DRV_LOG(ERR, "failed to process device arguments: %s", - strerror(err)); err = rte_errno; + DRV_LOG(ERR, "failed to process device arguments: %s", + strerror(rte_errno)); goto port_error; } err = mlx5_glue->query_device_ex(ctx, NULL, &device_attr_ex); -- 2.11.0