* [dpdk-dev] [PATCH] net/mlx5: fix error message in probe function
@ 2018-05-25 16:15 Adrien Mazarguil
2018-05-25 16:46 ` Yongseok Koh
0 siblings, 1 reply; 3+ messages in thread
From: Adrien Mazarguil @ 2018-05-25 16:15 UTC (permalink / raw)
To: Shahaf Shuler; +Cc: dev
Error values passed to strerror() must be positive.
Fixes: 012ad9944dfc ("net/mlx5: fix probe return value polarity")
Cc: Shahaf Shuler <shahafs@mellanox.com>
Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
drivers/net/mlx5/mlx5.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 11b395b64..9b78f9879 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -953,9 +953,9 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
priv->mtu = ETHER_MTU;
err = mlx5_args(&config, pci_dev->device.devargs);
if (err) {
- DRV_LOG(ERR, "failed to process device arguments: %s",
- strerror(err));
err = rte_errno;
+ DRV_LOG(ERR, "failed to process device arguments: %s",
+ strerror(rte_errno));
goto port_error;
}
err = mlx5_glue->query_device_ex(ctx, NULL, &device_attr_ex);
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix error message in probe function
2018-05-25 16:15 [dpdk-dev] [PATCH] net/mlx5: fix error message in probe function Adrien Mazarguil
@ 2018-05-25 16:46 ` Yongseok Koh
2018-06-17 8:05 ` Shahaf Shuler
0 siblings, 1 reply; 3+ messages in thread
From: Yongseok Koh @ 2018-05-25 16:46 UTC (permalink / raw)
To: Adrien Mazarguil; +Cc: Shahaf Shuler, dev
> On May 25, 2018, at 9:16 AM, Adrien Mazarguil <adrien.mazarguil@6wind.com> wrote:
>
> Error values passed to strerror() must be positive.
>
> Fixes: 012ad9944dfc ("net/mlx5: fix probe return value polarity")
> Cc: Shahaf Shuler <shahafs@mellanox.com>
>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix error message in probe function
2018-05-25 16:46 ` Yongseok Koh
@ 2018-06-17 8:05 ` Shahaf Shuler
0 siblings, 0 replies; 3+ messages in thread
From: Shahaf Shuler @ 2018-06-17 8:05 UTC (permalink / raw)
To: Yongseok Koh, Adrien Mazarguil; +Cc: dev
Friday, May 25, 2018 7:46 PM, Yongseok Koh:
> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix error message in probe
> function
>
>
> > On May 25, 2018, at 9:16 AM, Adrien Mazarguil
> <adrien.mazarguil@6wind.com> wrote:
> >
> > Error values passed to strerror() must be positive.
> >
> > Fixes: 012ad9944dfc ("net/mlx5: fix probe return value polarity")
> > Cc: Shahaf Shuler <shahafs@mellanox.com>
> >
> > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> > ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
Applied to next-net-mlx, thanks.
>
> Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-17 8:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-25 16:15 [dpdk-dev] [PATCH] net/mlx5: fix error message in probe function Adrien Mazarguil
2018-05-25 16:46 ` Yongseok Koh
2018-06-17 8:05 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).