From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 8C4E9200 for ; Mon, 28 May 2018 11:39:22 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 May 2018 02:39:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,451,1520924400"; d="scan'208";a="43381527" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.55]) by fmsmga008.fm.intel.com with SMTP; 28 May 2018 02:39:19 -0700 Received: by (sSMTP sendmail emulation); Mon, 28 May 2018 10:39:19 +0100 Date: Mon, 28 May 2018 10:39:18 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20180528093842.GC15204@bricha3-MOBL.ger.corp.intel.com> References: <20180424123255.204330-1-bruce.richardson@intel.com> <20180526112142.9975-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180526112142.9975-1-thomas@monjalon.net> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v4] devtools: add test script for meson builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 May 2018 09:39:24 -0000 On Sat, May 26, 2018 at 01:21:42PM +0200, Thomas Monjalon wrote: > From: Bruce Richardson > > To simplify testing with the meson and ninja builds, we can add a script > to set up and do multiple builds. Currently this script sets up: > > * clang and gcc builds > * builds using static and shared linkage for binaries (libs are always > built as both) > * a build using the lowest instruction-set level for x86 (-march=nehalem) > * cross-builds for each cross-file listed in config/arm > > Each build is configured in a directory ending in *-build, and then for > the build stage, we just call ninja in each directory in turn. [i.e. we > assume every directory starting with "build-" is a meson build, which is > probably an ok assumption]. > > Signed-off-by: Bruce Richardson > Signed-off-by: Thomas Monjalon > --- > v2: it is a rework with 3 major changes > - automatically stop on error thanks to -e > - directory name starts with "build-" > - optionally load a config file to get some environment variables > v3: > - remove forcing "cd": use current directory > - remove CROSS: use hard-written aarch64-linux-gnu-gcc > - remove config load in script start > v4: > - remove config file loading (will be improved and sent later) > - the v4 is closer to what Bruce sent as v1 > --- Yes, it's closer, but there is also some good material in your v2 that we probably want to rework into this later on. I suggest in the name of progress we merge this version and iterate on improving it later. /Bruce