Re: [dpdk-dev] [PATCH] devtools: add script to verify map files

[Bruce Richardson <bruce.richardson@intel.com>]

On Mon, May 28, 2018 at 11:31:31AM +0200, Thomas Monjalon wrote:
> 28/05/2018 11:21, Bruce Richardson:
> > On Sun, May 27, 2018 at 10:50:58PM +0200, Thomas Monjalon wrote:
> > > Sorry for having missed this patch during so long.
> > > 
> > > 13/02/2018 11:48, Ferruh Yigit:
> > > > On 2/12/2018 4:13 PM, Pavan Nikhilesh wrote:
> > > > > This script checks for the symbols specified in the map files against
> > > > > the symbols present in the map file directory.
> > > > > Currently, the script checks for map files in drivers and lib directory.
> > > > > 
> > > > > Example:
> > > > > ./devtools/check-map.py
> > > > > 
> > > > > The following symbols are unused :
> > > > > 
> > > > > Map file : /home/pavan/Work/clean/dpdk/drivers/mempool/dpaa/...
> > > > > ['rte_dpaa_pool_table']
> > > > > 
> > > > > Map file : /home/pavan/Work/clean/dpdk/drivers/bus/fslmc/...
> > > > > ['qbman_get_version', 'qbman_swp_send_multiple']
> > > > > 
> > > > > ...
> > > > > 
> > > > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > > > 
> > > > +1 to improve our tools.
> > > > 
> > > > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > > 
> > > I agree we must have more tools.
> > > 
> > > I think this check can be a lot simpler as a shell script,
> > > instead of Python. It does not need the list features of Python.
> > > 
> > 
> > While the shell version can be shorter, I always find python scripts to be
> > far easier to read, understand and therefore maintain than shell scripts.
> > While power-users of shell, like yourself, Thomas, can come up with some
> > amazing stuff done in shell, it tends to make them very hard to follow for
> > us mere mortals.
> 
> Some processing are simpler in Python.
> But here, the python script is mostly calling some shell commands and
> filtering like grep.
> 
> For comparison, python version:
> 	http://dpdk.org/ml/archives/dev/2018-February/090772.html
> shell version:
> 	http://dpdk.org/ml/archives/dev/2018-May/102993.html
> 

Well, the python script does have a call to grep in it, true. I'm not going
to have a problem either way, the python version still reads a little
easier, but the shell version is shorter and looks more natural, I suppose.
I'm happy enough to go along with whatever others (who may care) think.

/Bruce