From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 4955C2B96 for ; Tue, 29 May 2018 12:59:16 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2018 03:59:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,456,1520924400"; d="scan'208";a="43008050" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.55]) by fmsmga007.fm.intel.com with SMTP; 29 May 2018 03:59:12 -0700 Received: by (sSMTP sendmail emulation); Tue, 29 May 2018 11:59:11 +0100 Date: Tue, 29 May 2018 11:59:10 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20180529105910.GA4808@bricha3-MOBL.ger.corp.intel.com> References: <20180424123255.204330-1-bruce.richardson@intel.com> <1832507.I1aXYWBlau@xps> <20180528132023.GB8752@bricha3-MOBL.ger.corp.intel.com> <3902265.nh2GMnEBpQ@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3902265.nh2GMnEBpQ@xps> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] devtools: add test script for meson builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 May 2018 10:59:16 -0000 On Tue, May 29, 2018 at 12:38:14PM +0200, Thomas Monjalon wrote: > 28/05/2018 15:20, Bruce Richardson: > > On Mon, May 28, 2018 at 12:26:24PM +0200, Thomas Monjalon wrote: > > > 28/05/2018 11:33, Bruce Richardson: > > > > On Sat, May 26, 2018 at 11:32:53AM +0200, Thomas Monjalon wrote: > > > > > 25/05/2018 17:18, Bruce Richardson: > > > > > > On Fri, May 25, 2018 at 04:51:58PM +0200, Thomas Monjalon wrote: > > > > > > > +load_config () +{ + reset_env + . $(dirname $(readlink -e > > > > > > > $0))/load-devel-config + MESON=${MESON:-meson} +} > > > > > > Why does this need to be done each time? > > > > > > > > > > Because the config could be different for each build (see above). > > > > > > > > > How would it be different, it's the same command called with the same > > > > environment each time? > > > > > > No, the idea is to adapt the environment to the build target. As an > > > example, the dependencies can be different for 32-bit and 64-bit. > > > > > I would hope that dependency detection should solve that, but since you > > already have support for that in existing build script via environment > > vars, I have no objection to leveraging that in the meson scripts. Overall, > > though, I'd prefer to ensure that the detection works so that everyone only > > needs one environment setup in order to get all builds working > > simultaneously. > > The dependency detection cannot work if I have dependencies in uncommon > directories. > I think it is important to allow testing compilation with dependencies > which are available but not installed, by providing paths. > Yes, but that should be done via meson configure options to specify the paths, rather than via environmental variables. AFAIK there is no support in meson for querying the environment*, every variable that could affect the build should be explicitly specified /Bruce * Ok, no direct way. There are probably ways in which it could be done, but it's not the meson way to do things.