From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 85E735593 for ; Mon, 4 Jun 2018 09:24:24 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id 94-v6so41992530wrf.5 for ; Mon, 04 Jun 2018 00:24:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=6e+6O9Jd34aJjhSUvHjrKTd4grgkOdzu2P3dTH5piHw=; b=Sq9L5xW46/BLUXGlRrl/R3ckPsWjpjSPBV7FmNiCmqyI3AXavD1FQfgOVXF079v9KJ +ut/s3OiL/HaXYYs1dna2VvUIGefozZ5k3kWV1lMFYEFmtw6p7i9NLMgcEUssEMx9aQk yggqMKgfoQjHv5rw4Sem4UepVlXzlrM6Czer/jQsiAJ/ALb85Ce+1tGzBK0zgdc2hCG0 ygX+xlEWSb54DU+ZXBK8Zz2Gr605fElNMGP6R3PIG/aTkrETNkuBiefr567cujczwH6k bSeFlFsaEzBbZaoq0XeyhP70RLFAmNT2FbCwsPlcpQ4+Uwm+7ltf/R6kAl+NCvQqqxA3 lgbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=6e+6O9Jd34aJjhSUvHjrKTd4grgkOdzu2P3dTH5piHw=; b=H9/MsTUz10FYQBhuZF+sb9F7Zt3qWBoji5Vy+e6XfOD6tEjjZu2/7pMThfYoo8UHxE NCrNEGdEFyvist4dqem5NqmY0N6aMTPMCytuUPCKNHt6y6jjiTZGj1+ZJJ49mJ7C/7gq M3YJY/ciVjMii+TSN2i0R7w4/iMT52HeS5/sSrTpylp6mx9igjqnZIev3DiCx8hzqg9O 8LGX6zyvq2h8IHJh72+p4CYbcIdcfidOfnH47OpwAfQFSTUyzxt8sP/bBAqFIQQD7Fix MuhGaufcOi8ltVcqjMzk/p5ZRCPxEvbR+w8jhmavaD5Flp+hFZpp9i0n9sd5BzCd57od 4BIA== X-Gm-Message-State: ALKqPwei8wZchxskk4MTR2GgqlPMyBE4o+rFnsn5Ceq5iNmBzAwZlgv0 skAKfJG3dr53uHOLPQHM/qXFM/dTSg== X-Google-Smtp-Source: ADUXVKIVZOK2C+ZkwCsMShBYT6v3Nve2i9PMJgTbTxVtrwuqt+Icf8Hn6TfAeKc2D95XjgOnDPeywA== X-Received: by 2002:adf:f045:: with SMTP id t5-v6mr14357133wro.260.1528097064316; Mon, 04 Jun 2018 00:24:24 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id a17-v6sm5257343wrr.81.2018.06.04.00.24.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Jun 2018 00:24:23 -0700 (PDT) Date: Mon, 4 Jun 2018 09:24:48 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Moti Haimovsky Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org Message-ID: <20180604072448.vxq5ahapnyztklyg@laranjeiro-vm.dev.6wind.com> References: <1528039753-25889-1-git-send-email-motih@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1528039753-25889-1-git-send-email-motih@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [RFC] net/mlx5: add support 32bit build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jun 2018 07:24:24 -0000 On Sun, Jun 03, 2018 at 06:29:13PM +0300, Moti Haimovsky wrote: > This RFC and patch aim to add support for building mlx5 PMD on 32bit > archs such as i686. > The attached patch was not tested on 32bit environments and is given > here for explanatory purposes. > > Prerequisites: > * RDMA-core with 32bit support libraries. > * compile and build tools for 32bit systems according to DPDK documentation. > > Assumptions: > * Kernel and drivers are 64bit. > * Only user programs and support libraries are 32Bit. > > Changes proposed in the PMD for adding 32bit support: > The attached patch provides the changes needed in the PMD in order to support > 32bit builds with the major changes being: > * Modifying the UAR access routine to support non-atomic 64bit writes > according to the mlx5 hardware reference manual. > * Handling 64bit address fields that are written to the device WQEs. > * Modify UAR address and size mapping to fit into the 32bit address space. > > Concerns: > * The major concern of this modification is the UAR mapping. > Current PMD assumes 64bit address and therefore feels free to map 4G size > UAR to virtual address just above the huge-page addresses which of course > cannot work for 32bit address space. > As a workaround I reduced the UAR size to half the original size but > this of course is not the solution. > * Will vectorized support work on 32bit builds ? > > I am interested in your inputs regarding the concerns listed above, > especially the UAR mapping issue mentioned there. >[...] Hi Moti, My biggest concern and why such support has been removed [1] is because Mellanox OFED is not supporting 32bits compilation. As Mellanox OFED is still supported, we need such guarantee. On Mellanox website there is no way to download such kind of ISO which means such support becomes only valid for upstream RDMA-Core library with almost newer kernels. If you can find a way to detect the PMD is compiled in front of Mellanox OFED to forbid such support, it would be great, otherwise I am afraid such support cannot be added back without creating a lot of issues for people wanting it on 32bits processors with Mellanox OFED. Thanks, [1] https://dpdk.org/browse/dpdk/commit/?id=ebbb81eb27daca0a89ee8f228fcf141d9eb6ef1c -- Nélio Laranjeiro 6WIND