From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 9E72C548B for ; Mon, 4 Jun 2018 13:58:51 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2018 04:58:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,476,1520924400"; d="scan'208";a="47122315" Received: from debian.sh.intel.com (HELO debian) ([10.67.104.203]) by orsmga006.jf.intel.com with ESMTP; 04 Jun 2018 04:58:49 -0700 Date: Mon, 4 Jun 2018 19:59:03 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: zhihong.wang@intel.com, dev@dpdk.org Message-ID: <20180604115903.GB21406@debian> References: <20180601124758.22652-1-maxime.coquelin@redhat.com> <20180601124758.22652-4-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180601124758.22652-4-maxime.coquelin@redhat.com> User-Agent: Mutt/1.9.5 (2018-04-13) Subject: Re: [dpdk-dev] [PATCH 3/4] net/virtio: don't use simple Rx path if TCP LRO requested X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jun 2018 11:58:52 -0000 On Fri, Jun 01, 2018 at 02:47:57PM +0200, Maxime Coquelin wrote: > Signed-off-by: Maxime Coquelin > --- > drivers/net/virtio/virtio_ethdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index 5730620ed..d481b282e 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1893,7 +1893,8 @@ virtio_dev_configure(struct rte_eth_dev *dev) > } > > if (rx_offloads & (DEV_RX_OFFLOAD_UDP_CKSUM | > - DEV_RX_OFFLOAD_TCP_CKSUM)) > + DEV_RX_OFFLOAD_TCP_CKSUM | > + DEV_RX_OFFLOAD_TCP_LRO)) Maybe we also need to consider not using simple Rx when DEV_RX_OFFLOAD_VLAN_STRIP is requested. Best regards, Tiwei Bie > hw->use_simple_rx = 0; > > if (tx_offloads & (DEV_TX_OFFLOAD_TCP_CKSUM | > -- > 2.14.3 >