From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 749EC7CD1 for ; Thu, 7 Jun 2018 06:51:31 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2018 21:51:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,486,1520924400"; d="scan'208";a="57218349" Received: from debian.sh.intel.com (HELO debian) ([10.67.104.203]) by orsmga003.jf.intel.com with ESMTP; 06 Jun 2018 21:51:27 -0700 Date: Thu, 7 Jun 2018 12:51:41 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: zhihong.wang@intel.com, dev@dpdk.org Message-ID: <20180607045140.GA32696@debian> References: <20180606123128.7868-1-maxime.coquelin@redhat.com> <20180606123128.7868-6-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180606123128.7868-6-maxime.coquelin@redhat.com> User-Agent: Mutt/1.9.5 (2018-04-13) Subject: Re: [dpdk-dev] [PATCH v2 5/5] net/virtio: improve offload check performance X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jun 2018 04:51:32 -0000 On Wed, Jun 06, 2018 at 02:31:28PM +0200, Maxime Coquelin wrote: > Instead of checking the multiple Virtio features bits for > every packet, let's do the check once at configure time and > store it in virtio_hw struct. > > Signed-off-by: Maxime Coquelin > --- [...] > @@ -270,8 +261,7 @@ virtqueue_enqueue_xmit(struct virtnet_tx *txvq, struct rte_mbuf *cookie, > * which is wrong. Below subtract restores correct pkt size. > */ > cookie->pkt_len -= head_size; > - /* if offload disabled, it is not zeroed below, do it now */ I think there is no need to remove this comment. Apart from that, Reviewed-by: Tiwei Bie > - if (offload == 0) { > + if (!vq->hw->has_tx_offload) { > ASSIGN_UNLESS_EQUAL(hdr->csum_start, 0); > ASSIGN_UNLESS_EQUAL(hdr->csum_offset, 0); > ASSIGN_UNLESS_EQUAL(hdr->flags, 0); [...]