From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C692B1B1B4 for ; Thu, 7 Jun 2018 07:17:51 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2018 22:17:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,486,1520924400"; d="scan'208";a="65003577" Received: from debian.sh.intel.com (HELO debian) ([10.67.104.203]) by orsmga002.jf.intel.com with ESMTP; 06 Jun 2018 22:17:49 -0700 Date: Thu, 7 Jun 2018 13:18:03 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: zhihong.wang@intel.com, dev@dpdk.org Message-ID: <20180607051802.GD32696@debian> References: <20180606123128.7868-1-maxime.coquelin@redhat.com> <20180606123128.7868-3-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180606123128.7868-3-maxime.coquelin@redhat.com> User-Agent: Mutt/1.9.5 (2018-04-13) Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/virtio: use simple path for Tx even if Rx mergeable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jun 2018 05:17:52 -0000 On Wed, Jun 06, 2018 at 02:31:25PM +0200, Maxime Coquelin wrote: > Having Rx mergeable buffers feature enabled should not be > a reason to not use Tx simple path. > > Signed-off-by: Maxime Coquelin > --- > drivers/net/virtio/virtio_ethdev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index bdc4f09d5..73e6d6b6b 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1949,7 +1949,6 @@ virtio_dev_configure(struct rte_eth_dev *dev) > #endif > if (vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF)) { > hw->use_simple_rx = 0; > - hw->use_simple_tx = 0; > } Maybe it's better to also remove { and }. Reviewed-by: Tiwei Bie > > if (rx_offloads & (DEV_RX_OFFLOAD_UDP_CKSUM | > -- > 2.14.3 >