From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 20DAA1AFEB for ; Thu, 7 Jun 2018 09:53:41 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jun 2018 00:53:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,486,1520924400"; d="scan'208";a="62011167" Received: from debian.sh.intel.com (HELO debian) ([10.67.104.203]) by fmsmga001.fm.intel.com with ESMTP; 07 Jun 2018 00:53:40 -0700 Date: Thu, 7 Jun 2018 15:53:53 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: zhihong.wang@intel.com, dev@dpdk.org Message-ID: <20180607075353.GA15456@debian> References: <20180606123128.7868-1-maxime.coquelin@redhat.com> <20180606123128.7868-2-maxime.coquelin@redhat.com> <20180607054323.GE32696@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) Subject: Re: [dpdk-dev] [PATCH v2 1/5] net/virtio: prevent simple Tx path selection by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jun 2018 07:53:42 -0000 On Thu, Jun 07, 2018 at 09:40:35AM +0200, Maxime Coquelin wrote: > On 06/07/2018 07:43 AM, Tiwei Bie wrote: > > On Wed, Jun 06, 2018 at 02:31:24PM +0200, Maxime Coquelin wrote: > > [...] > > > + > > > +static int > > > +virtio_dev_args(struct rte_eth_dev *dev) > > > +{ > > > + struct rte_kvargs *kvlist; > > > + struct rte_devargs *devargs; > > > + const char *valid_args[] = { > > > + VIRTIO_SIMPLE_TX_SUPPORT, > > > + NULL, > > > + }; > > > + int ret; > > > + int i; > > > + > > > + devargs = dev->device->devargs; > > > + if (!devargs) > > > + return 0; /* return success */ > > > + > > > + kvlist = rte_kvargs_parse(devargs->args, valid_args); > > > + if (kvlist == NULL) > > > + return -EINVAL; > > > > Virtio-user has defined some other mandatory devargs. > > The parse will fail when other devargs have been > > specified. > > Ok, so IIUC, just returning 0 here should do the trick, right? I think you can't just return 0 in this case, because you still need to find and parse the VIRTIO_SIMPLE_TX_SUPPORT devarg. I didn't look into the kvargs code. It seems that you can pass NULL as the second param when calling rte_kvargs_parse(), i.e. just get the KV list without valid keys check. Best regards, Tiwei Bie > > > > + > > > + /* Process parameters. */ > > > + for (i = 0; (valid_args[i] != NULL); ++i) { > > > > There is an extra space before the comment. > > The () around `valid_args[i] != NULL` isn't necessary. > > Fixed. > > > > + if (rte_kvargs_count(kvlist, valid_args[i])) { > > > + ret = rte_kvargs_process(kvlist, valid_args[i], > > > + virtio_dev_args_check, dev); > > > + if (ret) { > > > + rte_kvargs_free(kvlist); > > > + return ret; > > > + } > > > + } > > > + } > > > + rte_kvargs_free(kvlist); > > > + > > > + return 0; > > > +} > > > + > > [...] > > > > Thanks! > Maxime