From: Yanglong Wu <yanglong.wu@intel.com>
To: dev@dpdk.org
Cc: qi.z.zhang@intel.com, konstantin.ananyev@intel.com,
Yanglong Wu <yanglong.wu@intel.com>
Subject: [dpdk-dev] [PATCH] net/i40e: illagel pactket checking
Date: Thu, 7 Jun 2018 17:39:38 +0800 [thread overview]
Message-ID: <20180607093938.62579-1-yanglong.wu@intel.com> (raw)
Some illegal packets will lead to TX/RX hang and
can't recover automatically. This pacth check those
illegal packets and protect TX/RX from hanging.
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
drivers/net/i40e/i40e_rxtx.c | 10 ++++++++++
drivers/net/i40e/i40e_rxtx.h | 2 ++
2 files changed, 12 insertions(+)
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 6032d5541..be00b898e 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -1458,6 +1458,16 @@ i40e_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,
return i;
}
+ /*check the size of pkt len*/
+ if (m->pkt_len > ETHER_MAX_LEN || m->pkt_len < I40E_TX_MIN_PKT_LEN){
+ rte_errno = -EINVAL;
+ return i;}
+
+ /*check the number of mbuf segments*/
+ if(m->nb_segs > I40E_TX_MAX_MTU_SEG){
+ rte_errno = -EINVAL;
+ return i;}
+
#ifdef RTE_LIBRTE_ETHDEV_DEBUG
ret = rte_validate_tx_offload(m);
if (ret != 0) {
diff --git a/drivers/net/i40e/i40e_rxtx.h b/drivers/net/i40e/i40e_rxtx.h
index ea73a8a1b..3fc619af9 100644
--- a/drivers/net/i40e/i40e_rxtx.h
+++ b/drivers/net/i40e/i40e_rxtx.h
@@ -30,6 +30,8 @@
#define I40E_TX_MAX_SEG UINT8_MAX
#define I40E_TX_MAX_MTU_SEG 8
+#define I40E_TX_MIN_PKT_LEN 17
+
#undef container_of
#define container_of(ptr, type, member) ({ \
typeof(((type *)0)->member)(*__mptr) = (ptr); \
--
2.11.0
next reply other threads:[~2018-06-07 9:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 9:39 Yanglong Wu [this message]
2018-06-07 16:04 ` Ananyev, Konstantin
2018-06-08 3:54 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
2018-06-08 14:04 ` Ananyev, Konstantin
2018-06-08 17:24 ` Wiles, Keith
2018-06-15 6:18 ` [dpdk-dev] [PATCH v3] " Yanglong Wu
2018-06-15 14:56 ` Zhang, Qi Z
2018-06-19 8:42 ` [dpdk-dev] [PATCH v3] net/i40e: illegal " Yanglong Wu
2018-06-19 9:10 ` [dpdk-dev] [PATCH] " Yanglong Wu
2018-06-20 1:44 ` Yanglong Wu
2018-06-20 1:46 ` [dpdk-dev] [PATCH v3] " Yanglong Wu
2018-06-20 2:12 ` [dpdk-dev] [PATCH v4] net/i40e: illegal packet checking Yanglong Wu
2018-06-22 9:17 ` Ananyev, Konstantin
2018-06-22 11:52 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180607093938.62579-1-yanglong.wu@intel.com \
--to=yanglong.wu@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).