From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id 5E68C1CFFC for ; Fri, 8 Jun 2018 22:02:18 +0200 (CEST) Received: by mail-pf0-f196.google.com with SMTP id a11-v6so7146500pff.8 for ; Fri, 08 Jun 2018 13:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=USsCGVVadNrN8n4fqjkU5bA0+oZViKOHo0UAlFQFB+M=; b=W+NHjPxHi+kyR4kKA/XUdg/9aPkR7II/dKxlKabGTDS46uPqfX+3lF3zjo3N0BbTKO S3+CSX03w426Kh8lRKpWabtNuD5Fup7mOqIqavvGqEP3aMyC+oidNpX8zekldBb9s3w/ web7jGMF8NTXo9Ex+FhsMvSWbS19qGVuvI9IkXca/O+3yKuGO8yE0dvkUN2F9AFDG1t1 uy13JJDCKBs1G3AUXtjwmEiz2urvXMh+n6tdfxWa1x1PVtBAFsdP/Ogu1hhfC9kukqjs zMd3enm53hAsy3V+RdusUDGrXnLqSTvPi75x4giDVQfl8Tx6NTE2ELDfnLluAc9N0q81 kacg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=USsCGVVadNrN8n4fqjkU5bA0+oZViKOHo0UAlFQFB+M=; b=TBkoM4jzSq/wtEuHnHBa0Q0dOy03nfOaFefqyR5/KAdHJZ3/fu9XWcVivU89sCL9dV ClhLFUCfaGR573cUaXuiBq1X8Zp7ogvNUDeD3QOTDOQtrtCrj3MWqYgThnZGcVn6xI54 5pwVcQToVwuBiDe5F8y54tUbYIDRTroPTHfC6K+3QSCroFk88dpFfHMvqBdhxuTk3ZYr TNxqb+/aRriCzyi7Sevw537N6wcPbteddlqU0B9sZp/HYwjY1MMfo/ILJUoYsaMjBYPJ LHGoHETusBA9J7sposs3bcAQ/e/2NGH1+d/cuSf1Hr9OC1s7dOLaN1gRp5kXVv0LczQ8 N3zA== X-Gm-Message-State: APt69E3Q5Hxh7JUFzD+VSiQs/OdmrBbC4dOygWiFthZayghcdguoHxFW bRyg1vQ2YwofiE/SY9c6vCOIeg== X-Google-Smtp-Source: ADUXVKIV5gnhkpDDo21O5JoWDpe0o93TDAfLlwSBtWQ0xfKGUQvVwB+i2kSHaZwCeaktSGfpJdSjjQ== X-Received: by 2002:a62:f248:: with SMTP id y8-v6mr7400951pfl.217.1528488137233; Fri, 08 Jun 2018 13:02:17 -0700 (PDT) Received: from xeon-e3 (204-195-35-107.wavecable.com. [204.195.35.107]) by smtp.gmail.com with ESMTPSA id v26-v6sm18165053pfn.105.2018.06.08.13.02.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Jun 2018 13:02:17 -0700 (PDT) Date: Fri, 8 Jun 2018 13:02:14 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: Thomas Monjalon , dev@dpdk.org, Shahaf Shuler , Wei Dai , Qi Zhang , Andrew Rybchenko Message-ID: <20180608130214.686c79e8@xeon-e3> In-Reply-To: <20180531124431.13746-1-ferruh.yigit@intel.com> References: <20180531124431.13746-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: force offloading API rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jun 2018 20:02:18 -0000 On Thu, 31 May 2018 13:44:30 +0100 Ferruh Yigit wrote: > The error path was disabled in previous release to let apps to be more > flexible. > > But this release they are enabled, applications have to obey offload API > rules otherwise they will get errors from following APIs: > rte_eth_dev_configure > rte_eth_rx_queue_setup > rte_eth_tx_queue_setup > > Signed-off-by: Ferruh Yigit Rather than always returning -EINVAL, why not propagate error code that the driver returns. This would allow driver to give a more detailed error return. The problem with that is you probably need to do a review of each drivers configure and setup routines to see what they return on error (if any).