From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0074.outbound.protection.outlook.com [104.47.40.74]) by dpdk.org (Postfix) with ESMTP id DA7831DB54 for ; Sun, 10 Jun 2018 13:16:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=16lAHtccW1VUJD5sDqe9hn7z9EZXSrcgxNpe1viyuGU=; b=ESaTw7QSRZKcukMNWcAjBPwLOe3AtQxWoSMb+4OvXZZUwdPOZ5eMm7hJ8CQis9ObPLjD/7uDpZT6nVRYTrjEkWaRCUMoVUcZiJHQ6m0CMILWwUYKceAcOWp42bphwJdtzskqOph9hsElAImLExZXOiSW62URclGjr4SvI2IDkJo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (118.143.155.128) by BN3PR07MB2513.namprd07.prod.outlook.com (2a01:111:e400:7bbf::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.14; Sun, 10 Jun 2018 11:16:50 +0000 Date: Sun, 10 Jun 2018 16:46:42 +0530 From: Jerin Jacob To: Stephen Hemminger Cc: "Wiles, Keith" , "dev@dpdk.org" , Stephen Hemminger Message-ID: <20180610111640.GA7050@jerin> References: <20180608165920.12228-1-stephen@networkplumber.org> <20180608165920.12228-2-stephen@networkplumber.org> <6F565A11-3B17-4A94-806C-3F066499AAD5@intel.com> <20180608111154.4a034010@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180608111154.4a034010@xeon-e3> User-Agent: Mutt/1.10.0 (2018-05-17) X-Originating-IP: [118.143.155.128] X-ClientProxiedBy: BYAPR07CA0027.namprd07.prod.outlook.com (2603:10b6:a02:bc::40) To BN3PR07MB2513.namprd07.prod.outlook.com (2a01:111:e400:7bbf::10) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(2017052603328)(7153060)(7193020); SRVR:BN3PR07MB2513; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 3:VGbdQOU1Tq5zVUbV7MueSXsIGIrSipizfPUmV6qX9WoQxz4SUksoAXb+XAzBf4OlUeBtIilZZ35pX/WzE/3gFp5ND4WSNDYrqpy79T8TINV9diSLhF3ONWGgotE0Layljx/axGGDv6UJmaZD4OQ+mAYToH3o0uplYxRf0WsAynEn5BeiFz0yyUPd16Mt6i3nu5FNPYON7kceXojxpSFb3klFc7qExVdXD3ZSHz6qf3E0CU4IZzo8IjqOZJlRXWeF; 25:NcHm7C6CFRfge6Qqr2UgzGLPEasomqXffLd1yoRiTa728UfK3vorEU66HjwehBC5+TGiNig259WR3HQ/axknu+Y2Q2/+A0+DSiUkJhfYMBzu2ycRRG1T3WHXT0kB8LqU1ZA97tjCm4zdokd7c+aRoOPR10afY8XLEwz6dFia76pBLjzBQU3HTiiFgYpDNqa6/wx0tQYOTT56h9gh0BoHbDRFOF/uMtJfZm5KGx/JM3QKt8OdGWbBHSJuWX6WngI+qMrov0Mcp9HA4fEzbFtR32tg5lIXqSNovKQP/vgofCtHAwM6/q1txYTK1cRxy9uTKVtBfE2qLkuM9cza8nAGhw==; 31:QkhHxJ5ySIJrRal//p/2bkiOqmdwYPW73Vzb3DWQ1rptuVhOBBSfPJVkr7h1jcAnzfHM9BKKuqfrYVtRJ4YZWqnXHCCe6jM7lFL9FGAKgLZEaL+JWhtsCx45kK0b3E4ofOIwAAEnQ1ND3i5kfYZ+x6WVb9jIK6ZcjxKRtziT6DhiAoS2MPdxzKUtpF+WHghFHhBFYKjewtAJZpngddJT9e7FETYf9aczyfIg0v9njvI= X-MS-TrafficTypeDiagnostic: BN3PR07MB2513: X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 20:hWj1VioJm13tPTnO/Jz9fmbLfMl7w8XeuTdKfcdtgPTEobBKR8KUKax9Lo9SL76D0jULBDyOzdJHjVngCR1dxnqZMO/sZsQTmhNcdNffi/XomLPHgMHkw9m2Gx4EI+8as6ddmrnbzjJcipI0aWQAvQq55WHYypX7UIi0lK0SCqiEfhsONJ2CjnwBZ1UYCOU4Sz7khCuAhT6B3xtXkSs6bIqk/gHYI3zH7l/qLkQrc1/gQSokE9PDsIO35UROhn2BghdXybsxnAJg/C5+0rpznHtwaSg3WInjqBjWtfE0LYDzfUTq4LSheCqQjpAkHLplzSOjIr8Kd0N1CF/ZUHT34tu9UokbMjKvE2D01XHtxzu5Q+icevmv+QslsEM6x8X9pZYgqupAP+KFdHC9eV4Tjp/uoWR9Is/VIrmtLtYEJkiLGxmysAg8witMcsb8kavhpZlJJKUf9A9RM5iMiI46dt9nQ/7XRIFqxIVltMW7ysIMUeQ6TLp6ilnMPzfUncJ2zxqvtO2AjqeUffJk3wwswd8Qjqnu/hpLRExlWDcBHEkDYFqkpNTKBrb8QwtSE+8FW9z+czFLVW1HRRboWjxIczYG9a17INjx5PXrFCTXtzo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(28532068793085)(89211679590171)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(10201501046)(3002001)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:BN3PR07MB2513; BCL:0; PCL:0; RULEID:; SRVR:BN3PR07MB2513; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 4:L0t4Fr1kfIDE0VlCZ0f3NPls2PrJzpx0rvmfMOMhd3Rd77g7dfWEim+yzILfXg/j5GznK07kM2ZLnf0b2YLMQ8MW8iNnb/YCvLu2jZz+0mZCzPlGZvZjD2ZwSv3ysNrZl1FAXnqMUPjFVcUZ5NwWujvf6Q/q/wlSpUv5uL+wT4vZigyABnR8lFHf+HbzzcYz9VGa9akXQdlDBJXeFbd32i0gVj8miXAq2gzeJATRsCjyavQzVqAkYj3XA3o8sGwT4b+ULdtLLKYymZcuXit8ewKRHdx7DR2Y6E3p3OZJscU1pRoH3OkcsOFOPGs0Hi6m9C4HosVyMvN98uXdmCG13LleC7vzyXUvlthpzZ5njozOvTxRM7DWvv92GXHg0+IU X-Forefront-PRVS: 0699FCD394 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(376002)(39850400004)(366004)(346002)(396003)(189003)(199004)(13464003)(16586007)(45080400002)(478600001)(105586002)(106356001)(1076002)(6916009)(305945005)(5660300001)(93886005)(7736002)(54906003)(50466002)(72206003)(23726003)(3846002)(6116002)(316002)(58126008)(68736007)(53936002)(59450400001)(33896004)(11346002)(52116002)(76176011)(2906002)(6496006)(446003)(476003)(33656002)(956004)(66066001)(8666007)(229853002)(9686003)(55016002)(16526019)(186003)(386003)(26005)(53546011)(33716001)(44832011)(8936002)(25786009)(81166006)(81156014)(97736004)(6666003)(42882007)(8676002)(6246003)(4326008)(47776003)(486006)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR07MB2513; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR07MB2513; 23:YDQdO1e888s97dnMf1GsBPBqzI5N3hMfFEBUoEJuR?= =?us-ascii?Q?2RgxK1DVAo1wT1GNSWB7WRpH2Jhwl8KLrCpJkdq9YeFFBehADBWmJr+tY38X?= =?us-ascii?Q?8SSH5LIGa/VKu6QZvviTJwjpQAPlOZh9bQ2d2vaB+hxC+sOoVuGAAZvaNfIc?= =?us-ascii?Q?fsm+u6EgeLzMWljGVQ0F03ppJf0V1VnmG3CiRc7qQ2QJ/8ISA4PPC1arZNY0?= =?us-ascii?Q?0nJPWg0e+ydt3D4NDbrw9rbXFUR68TP97XXgZhfeITdbLcN2vpcqI4X0Zbk3?= =?us-ascii?Q?nRJrtBf0gtAMQ9j1c2xgFbJ1f9Zw3kggxOYDKRhQW+GLxkStHVAnlcYelJaL?= =?us-ascii?Q?QK+iNaXWtvm9RLh4SwqdoBY5OKRODvD237/UTZlZ0mf6RypHhUwhui7x5neT?= =?us-ascii?Q?IH+AN9FQ5d5SMNwTvvJTOXuunImUK2pTHaHtzJQnKZoOcvp//cjUIqM6gHoc?= =?us-ascii?Q?eTiU3UvFJcx8tnJqKLnQDBZBA4P+KuNrDLKA8UJzGur6On+C4MVCERJsQlmP?= =?us-ascii?Q?f0BpFxb8zvy5LjGY40ozgY3+edSVhQxpfG+2KhHRYRUeiACWT89AiFPkNoDZ?= =?us-ascii?Q?Gr1HqqcPPKlddB7xcxz8+0Irze6hHPPBaWPMYayYRDwDU3fJXuVhdhk6gL3e?= =?us-ascii?Q?MYLR6Af3iJkD/quKhb8DniqSayhz+68WhPyajMfalWaR0lJtxkPn8LEpaJhr?= =?us-ascii?Q?htJUHKVFrwhsieHLwdiKmPEZJT0FBgM6lvW7zTPEfCxc0gr/rEa5I3nt4N0y?= =?us-ascii?Q?vPicmuGxY/3RMAN0x+EV4f/6X+ffh3xTlGGvNU35uqRF6nbW0XWq7yVYkQ7R?= =?us-ascii?Q?rhg4IYhCD2Xyo4tPa3xy8KjnnTARtCVlY7qVtwhrI12cWbztnnZbhABcwJCX?= =?us-ascii?Q?Ip+Nm/5lQeBTG50nuq5SiKkntnEVESh5/o1QQG43j0EvEEZAr9zqqwRkyhlO?= =?us-ascii?Q?rDKm3nMw+i1/YsNRhqzCkypSBCWxn/m7EjE2B60l+ugtntpxAPcczfIdCii2?= =?us-ascii?Q?XtetOqDjHhULtjV6ydKT827EbSbvQm4tkabxZezP4TH8OcYRFaTYDZnLa3Um?= =?us-ascii?Q?UtyyL1QIVjekt0qemtzb6QjpSeirAoETHdCuDMSgxelyJ0D2wCcR4w7QemfJ?= =?us-ascii?Q?xjWTV4SQZdLTD3gyNDyKs4/jMxswOUVF6BaGgdBcyS4uOdrhWBkvyffmL7o1?= =?us-ascii?Q?ROOpkJci14DCz+rTXvLosDLK+++HnjbNTqK+W1kDRbKnK+Blq8hFXM6afnSv?= =?us-ascii?Q?161bABBkJ1GoH+f38uggiUmHN2T5WSiDlPs2g2VPXgaRZFm0oqFJ/g0O884w?= =?us-ascii?Q?WjW0XHpMNLPvHLuC4yJmom4PQPD+Mu7jBWBSlW5zPtf2x53Io67sLd1XfXmy?= =?us-ascii?Q?OH23a7+IEeqh5BcVtzzF7ymIxD9kSTfLKsTO7cnfRHBdYyw8mOKPJpKFlVwW?= =?us-ascii?Q?aFxRlzS1VXtEiwVNuisSilrBMl1ows8dj5L5/GnMVPhW1h9rpBj?= X-Microsoft-Antispam-Message-Info: TdfCcdu0ClZt8sldGvMWFFwmm4jjpbZ67fkgA/QE/UBWcZv6fCwUz70OaO8t2SObQ0bOgknkDzZfQx6yfXh80tNOUwLpwNesiNE5x9Ov6Ykftc2XjJRJeKg3PmTxkbK5f+CihWH50JoXpscae+iLGIUbVH175rk9IQFkkoUykPWZtXWVTHncrPGZU8mKxwbp X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 6:7mgedn8fTJSz6LCy9tpYEwygliRmqT+WeJw42pKekv8yPQCR0xZmvV+lIWtB/Vppzt7/5v6CxD0UMRV9kYLoRYgyTYKIvjMlNnfzELsmkbPaIyXAT+2s3oEw65p72tmtawdmxO3OvZcZkAgkjbBL0ut7ivsHViAYPdWcxWyW1zeNp3JhVpD/0LM4UFFl1i/qgFMRtbHbmgK+GQ8onUx3j7UCYRD6nDUl+km5SRqBGehIlSFYRv7zK+siwVWyNAiBfj+hnJZ9fGp2Afihgkcp9almOET28drpqho5++tRdVMfP6/mh16VHLWuSOjeIcU55KUTk4n93YiJcefwbvtvFwd+RVIFyA2F6GVzZ7sEYnxAq14EMrBOd/gePW136S29BAifC5haBXRC8I/wXqdsnnOaz8EdE1FjnpZ0AMfjlyEidtGKjOrr2Gjmy0+jcYyL7NmEFz+JLqsD1ncdIdQKYA==; 5:PA7oRSrtIr2CYz48TF3RWItG5mkwWv9+uuGF/+cttueQyvTpZK8QfwI9XSqbiQZbX8rn578ZSYxULzHAiMXCx0bagFrkTzpPGIRyLCxyH8Wieziy0OkJiUEVaxTlu0DDXuEfil5JkHDLMLHjTdkrUgdPKgagq+YkYf9/tFEuclo=; 24:ObrEAtawkEy+D/nMTiI5xZKlDp/HOtKdUJBB+RFGeHQ1BzwDae8pxFFge0FK/bzCqBPDaeG04GWC8QJ2tZPWMHJCrODXlBTXczVStKJzNkg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 7:cUPJsQ9GRyQdyBebh2g/EMrDEAqgA8rKmuHaFk845YhBFQmR6OF2683YOkxtTPjcuqgim2m0WBsh1V+KdlN9Z4qZRa7h8cx5fRSPNF3VBiEXGb/t1aEUtHaFJDZdEm3iLp1+9Ut9OMJLkIZujdPXZnqCHlDaUY2Vg9sAb5AsiT9lLgP9OlN+gZaahCWMLa1YAgFXmAEMgwAKb/jnMPBmRvjIpXROgRSCBa8C4mhblFhwcl8gVsJUCr3SuOz/C8QV X-MS-Office365-Filtering-Correlation-Id: 0d58d658-b3a3-4329-d3f2-08d5cec3ab41 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2018 11:16:50.3861 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0d58d658-b3a3-4329-d3f2-08d5cec3ab41 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2513 Subject: Re: [dpdk-dev] [PATCH v10 1/5] eal: add rte_uuid support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Jun 2018 11:16:56 -0000 -----Original Message----- > Date: Fri, 8 Jun 2018 11:11:54 -0700 > From: Stephen Hemminger > To: "Wiles, Keith" > Cc: "dev@dpdk.org" , Stephen Hemminger > > Subject: Re: [dpdk-dev] [PATCH v10 1/5] eal: add rte_uuid support > > On Fri, 8 Jun 2018 17:15:04 +0000 > "Wiles, Keith" wrote: > > > > On Jun 8, 2018, at 9:59 AM, Stephen Hemminger wrote: > > > > > > Since uuid functions may not be available everywhere, implement > > > uuid functions in DPDK. These are based off the BSD licensed > > > libuuid in util-link. > > > > > > Signed-off-by: Stephen Hemminger > > > --- > > > lib/librte_eal/bsdapp/eal/Makefile | 1 + > > > lib/librte_eal/common/Makefile | 2 +- > > > lib/librte_eal/common/eal_common_uuid.c | 193 +++++++++++++++++++++++ > > > lib/librte_eal/common/include/rte_uuid.h | 129 +++++++++++++++ > > > lib/librte_eal/common/meson.build | 2 + > > > lib/librte_eal/linuxapp/eal/Makefile | 1 + > > > lib/librte_eal/rte_eal_version.map | 9 ++ > > > 7 files changed, 336 insertions(+), 1 deletion(-) > > > create mode 100644 lib/librte_eal/common/eal_common_uuid.c > > > create mode 100644 lib/librte_eal/common/include/rte_uuid.h > > > > > > > Hi Stephen, Why does this need to be in EAl/Common would this be better in the lib directory for utils or string routines? Does the EAl use the feature for something? > > > > Regards, > > Keith > > > > It could be anywhere. Not tied to being in EAL common but that is where the PCI parsing code is. > Still not 100% sure we need our own version of this simple code. It is more about BSD and eventually Windows support. IMO, It is useful to add it in common EAL as some drivers can also use it. But, I think, we must add unit test case for this new API.