From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg0-f41.google.com (mail-pg0-f41.google.com [74.125.83.41])
 by dpdk.org (Postfix) with ESMTP id D9F261E4BE
 for <dev@dpdk.org>; Mon, 11 Jun 2018 17:25:11 +0200 (CEST)
Received: by mail-pg0-f41.google.com with SMTP id m5-v6so9909644pgd.3
 for <dev@dpdk.org>; Mon, 11 Jun 2018 08:25:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=mwAO6N9DM5zmYT5KwPG5O+UhTsxK7afIF/yk6WMLr58=;
 b=z0SpvaeO4OgZlbgshGXcdyZTsCGxLGwfaGBOc0ZyKgc97JkJCn9KjSe/pfUxp/i0dH
 f9SFAYcOS6KU6/8mDJfOyf22ycAnFfKlJhHFofGOj/UhC0tM3zxBKtrA6ZKwbWMwMqqD
 8N886lFX6jChEhrEypQPyfUW0P7iBOpji8IpKbRO79FxF9Fqp++jx54JE6Wc0SBdV+21
 Gj5mBQzJgBUeRPQJ2yeVxQWWvI5wAImJvSGkhfvZKIAP8UmxA4Bhr9SJva5aFs9NyQfT
 spg5+bZjkF3GnRk235ix7k4P2k17MNfiOXtDxr/hEjEAbcM3eFQ72yJVY/Zt2+A6Qwl7
 /uLA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=mwAO6N9DM5zmYT5KwPG5O+UhTsxK7afIF/yk6WMLr58=;
 b=np1YojmWGWMvBBiEV1CQ6wi/q+mVv3aBq7RVDpirf4rBuiux3IAKpRj0rD+Jadi1Ec
 COILeykbQvAFKpt98ogo6g1xT92x4y5m5KLDEDBHczDmXLLhPRz0CblvW4lYTamDZVew
 6GH1nuSAGfRcMtOb9jxeuufrfLrOHkbCcPzNUOEIw+T7/8vbCXpwM1uRiCgpJxBKbE39
 RGZLFzR33ERSGe9r9Ftwtv02yl2Ov2jyNPS2wkcHn4hzAR0T2gxgzTMU6vAhO8zCgYJC
 LFZAl5a4mGDBm64KHBJ4PCECH5sDirb3OdQj+3/cCpwRGx4Ib6OfhkpfcViGgGGSLuS5
 4vaA==
X-Gm-Message-State: APt69E2o1YUZda0fT/YgB8H8GOTFw4qPEUKNgs8IPiyRLyKbeZ6DSDmC
 s9qkFYhP1dwn0dYd0nFhuPxZzw==
X-Google-Smtp-Source: ADUXVKIXd0R6/FUtwKOCWA7yJ4dpimUKoxtn2US3rdhlWTne8qQJJsQbpzjvHTa5GEnepjfi7iHx/Q==
X-Received: by 2002:a63:5fc4:: with SMTP id
 t187-v6mr14795436pgb.183.1528730711053; 
 Mon, 11 Jun 2018 08:25:11 -0700 (PDT)
Received: from xeon-e3 (204-195-35-107.wavecable.com. [204.195.35.107])
 by smtp.gmail.com with ESMTPSA id a81-v6sm46440173pfl.167.2018.06.11.08.25.10
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Mon, 11 Jun 2018 08:25:10 -0700 (PDT)
Date: Mon, 11 Jun 2018 08:25:09 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Neil Horman <nhorman@tuxdriver.com>, John McNamara
 <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Message-ID: <20180611082509.4551fac5@xeon-e3>
In-Reply-To: <20180608225709.19473-1-ferruh.yigit@intel.com>
References: <20180608225709.19473-1-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [RFC] ethdev: add new offload flag to keep CRC
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jun 2018 15:25:12 -0000

On Fri,  8 Jun 2018 23:57:09 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> DEV_RX_OFFLOAD_KEEP_CRC offload flag added.
> 
> DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release
> default behavior in PMDs is to keep the CRC until this flag removed

This won't work for virtual devices that never keep CRC.
Maybe wording should be changed.