From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f66.google.com (mail-pl0-f66.google.com [209.85.160.66]) by dpdk.org (Postfix) with ESMTP id 8D2B81DE6B for ; Mon, 11 Jun 2018 19:35:11 +0200 (CEST) Received: by mail-pl0-f66.google.com with SMTP id g20-v6so12739442plq.1 for ; Mon, 11 Jun 2018 10:35:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=q4FWKV+AiMo/Bk0S4V7T64nBHeIdysMsNld7C/FgSEM=; b=ohDeBLMlCLBZDolJZ/AY0JK1QVY+E0qDQj5hZg3iBGO+jH4+B8wvrZifHmLizedKYV fqqSE9KIZ4SsM77mfKl7dgiM3Jn1QKux5Ue2TrMaAK3wrb1jX5r+rt2FPmQRawaPLJ0H NEGBf2LBS9XgtVY7i/9lCNJ6WDxNd029G6sHL04bgrpr2L34kR3rrQJzdt5n4Odvrw1Y 43YNTWVYH91JjGQWzFinI3gg7ZRsiY9ekQ1eFE/VxI9x1EYjUmtgr6Q5YbRc096yoL9q giDeHiT+bLVKypqmkijNNZ1lfJSDrGdxsJxNC4b8fFU4jQRVWmpRENUzAje8DG15XDBJ b7FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=q4FWKV+AiMo/Bk0S4V7T64nBHeIdysMsNld7C/FgSEM=; b=WA56PeoBepiiGvaOwXjf7H1ZA5eMdHMezKwYkn8654ciQ8Pjixg9CRx2hwztJPEDjz c5rc+Xu//7dZ2aPkVblL9xdvfFrgGIz2X7C7qV7FRye/dxvx6Yyrwsg6ULUgdl8MdNI7 +oshfr4ylgJhgii/nKLRAGZnf8wqlPvBnzo7eZJpUPWm3OdNw4tIavv3FWpcVRjQHGd9 tfShi0f4ehuslViRaQq2rXNRluPaSM5uICOP871++s+V3bbmmPoV1w+LPO0K67CrYZfh so2PAQWkV57xJ26Fny1jGvaGgde9yp8o47t3GlZ8nmFTf/9rkFzeDiVOxSLszI3QNgHp 5K8w== X-Gm-Message-State: APt69E1Y8s8EW00SxTIHvfvXhbdR2GHWOXOHnqoH/mbSXBRg2FZKU2SY 5g8guOebgEzi0a6CAoA242mhKC3prCU= X-Google-Smtp-Source: ADUXVKKG5rOk73IIu2OUZ3a/Kwkg7d0eQP4rNB1MsAVFRBnFoJGJ1nEBr50h/6bA5dlic9MyJCu6TA== X-Received: by 2002:a17:902:4424:: with SMTP id k33-v6mr140279pld.242.1528738510669; Mon, 11 Jun 2018 10:35:10 -0700 (PDT) Received: from xeon-e3 (204-195-35-107.wavecable.com. [204.195.35.107]) by smtp.gmail.com with ESMTPSA id j15-v6sm42554781pfk.40.2018.06.11.10.35.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Jun 2018 10:35:10 -0700 (PDT) Date: Mon, 11 Jun 2018 10:35:08 -0700 From: Stephen Hemminger To: Jerin Jacob Cc: "Wiles, Keith" , "dev@dpdk.org" , Stephen Hemminger Message-ID: <20180611103508.6893e6ee@xeon-e3> In-Reply-To: <20180610111640.GA7050@jerin> References: <20180608165920.12228-1-stephen@networkplumber.org> <20180608165920.12228-2-stephen@networkplumber.org> <6F565A11-3B17-4A94-806C-3F066499AAD5@intel.com> <20180608111154.4a034010@xeon-e3> <20180610111640.GA7050@jerin> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v10 1/5] eal: add rte_uuid support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 17:35:11 -0000 On Sun, 10 Jun 2018 16:46:42 +0530 Jerin Jacob wrote: > -----Original Message----- > > Date: Fri, 8 Jun 2018 11:11:54 -0700 > > From: Stephen Hemminger > > To: "Wiles, Keith" > > Cc: "dev@dpdk.org" , Stephen Hemminger > > > > Subject: Re: [dpdk-dev] [PATCH v10 1/5] eal: add rte_uuid support > > > > On Fri, 8 Jun 2018 17:15:04 +0000 > > "Wiles, Keith" wrote: > > > > > > On Jun 8, 2018, at 9:59 AM, Stephen Hemminger wrote: > > > > > > > > Since uuid functions may not be available everywhere, implement > > > > uuid functions in DPDK. These are based off the BSD licensed > > > > libuuid in util-link. > > > > > > > > Signed-off-by: Stephen Hemminger > > > > --- > > > > lib/librte_eal/bsdapp/eal/Makefile | 1 + > > > > lib/librte_eal/common/Makefile | 2 +- > > > > lib/librte_eal/common/eal_common_uuid.c | 193 +++++++++++++++++++++++ > > > > lib/librte_eal/common/include/rte_uuid.h | 129 +++++++++++++++ > > > > lib/librte_eal/common/meson.build | 2 + > > > > lib/librte_eal/linuxapp/eal/Makefile | 1 + > > > > lib/librte_eal/rte_eal_version.map | 9 ++ > > > > 7 files changed, 336 insertions(+), 1 deletion(-) > > > > create mode 100644 lib/librte_eal/common/eal_common_uuid.c > > > > create mode 100644 lib/librte_eal/common/include/rte_uuid.h > > > > > > > > > > Hi Stephen, Why does this need to be in EAl/Common would this be better in the lib directory for utils or string routines? Does the EAl use the feature for something? > > > > > > Regards, > > > Keith > > > > > > > It could be anywhere. Not tied to being in EAL common but that is where the PCI parsing code is. > > Still not 100% sure we need our own version of this simple code. It is more about BSD and eventually Windows support. > > > IMO, It is useful to add it in common EAL as some drivers can also use it. > But, I think, we must add unit test case for this new API. > I don't see much point in going through the effort of writing unit test since it is just a straight copy of Ted's uuid code which has been around for a long time.