From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 731C11E89F for ; Tue, 12 Jun 2018 08:18:35 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jun 2018 23:18:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,213,1526367600"; d="scan'208";a="63815035" Received: from debian.sh.intel.com (HELO debian) ([10.67.104.228]) by orsmga001.jf.intel.com with ESMTP; 11 Jun 2018 23:18:32 -0700 Date: Tue, 12 Jun 2018 14:18:39 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: zhihong.wang@intel.com, dev@dpdk.org Message-ID: <20180612061839.GA14136@debian> References: <20180607092616.27720-1-maxime.coquelin@redhat.com> <20180607092616.27720-3-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180607092616.27720-3-maxime.coquelin@redhat.com> User-Agent: Mutt/1.9.5 (2018-04-13) Subject: Re: [dpdk-dev] [PATCH v3 2/5] net/virtio: use simple path for Tx even if Rx mergeable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2018 06:18:35 -0000 On Thu, Jun 07, 2018 at 11:26:13AM +0200, Maxime Coquelin wrote: > Having Rx mergeable buffers feature enabled should not be > a reason to not use Tx simple path. > > Signed-off-by: Maxime Coquelin Reviewed-by: Tiwei Bie > --- > drivers/net/virtio/virtio_ethdev.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index 052dd056a..c6087d9b1 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1948,10 +1948,8 @@ virtio_dev_configure(struct rte_eth_dev *dev) > hw->use_simple_tx = 0; > } > #endif > - if (vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF)) { > + if (vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF)) > hw->use_simple_rx = 0; > - hw->use_simple_tx = 0; > - } > > if (rx_offloads & (DEV_RX_OFFLOAD_UDP_CKSUM | > DEV_RX_OFFLOAD_TCP_CKSUM)) > -- > 2.14.3 >