From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com [209.85.128.177]) by dpdk.org (Postfix) with ESMTP id 1E7731DE38 for ; Tue, 12 Jun 2018 15:20:03 +0200 (CEST) Received: by mail-wr0-f177.google.com with SMTP id l41-v6so24061553wre.7 for ; Tue, 12 Jun 2018 06:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=aziJeYnPutq5C9mVviQRUPQGG5EA/8h3khpZ0RUNULE=; b=O7curHxYEFemvpZTokIRNgWwQPz1fu5GmYTwgaycu299ZcCT1cl4xjmVjdIuCIw1Xm yXO6wod/FS8RCdPBgC7FxRdzn8F2IA3iObk8x2B11wk2xyiA5ZwX8XTlv+qpTcS/POOm X905ivyM6A9CZroV8jvghII9NY9siMocvXWrcXRoWTPINkLKYYBMx6musJU2ZGVzDy/U b43+SYO2/OTe/+YK0MOYHmUk1/lDMs1kPdkjitTLGDG4rSmEBp/9oJeqAxG7vu3fORda dAttQDkEPDrKlCs5ULCPY3eHtLhQWGrL2EGAHzTDN8FEpg1/9GGmzwmmddpXZ5lW+qyQ rBmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aziJeYnPutq5C9mVviQRUPQGG5EA/8h3khpZ0RUNULE=; b=D16qc/xmK9WuefbUfW2JeGPOJKjmR1cqVHaJcfpU5hp4CGO2VrnijXVFxAHOWWbI70 akV/ujWwlClc6B/sltLNJYF0jYCSs7jdrRFgHb0iIsntSyCwvS8VZP1vf9zPCvPuajRi hf6ML3wADZW86okABi5nHYcEqj0h3iYdtdyDEBjmqd8Th3FL36czyIRVTYFHMAB93XcY QOXZ58L1F5ksxrYs3tdi1URwToZ6dH7IfOi6GDflIN69NMZFVafs+w7lRzATshOpOi7M 0PK8yL9Zvop0EqsmlTTAfYxaFzoG72USTTN5p2aLrSNOyiXcEQv7IR3opI+bHTAkb8EZ MnpQ== X-Gm-Message-State: APt69E16spNv0ATryNiEzvgCMwriOrNqKHd7Ol1QTC8FAKu262/R1953 93bK2SnNwPCuTDKC0I0JF/B4mA== X-Google-Smtp-Source: ADUXVKJikY1moDFFO8ywluJFtkeXU5xzRU+NIXzOEKhfI9SKELMmZ3mClfNSdYcc0SjAPsreMhxJEQ== X-Received: by 2002:adf:ef4f:: with SMTP id c15-v6mr284559wrp.182.1528809602928; Tue, 12 Jun 2018 06:20:02 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id n7-v6sm206492wri.27.2018.06.12.06.20.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Jun 2018 06:20:01 -0700 (PDT) Date: Tue, 12 Jun 2018 15:19:46 +0200 From: Adrien Mazarguil To: "Xueming(Steven) Li" Cc: Shahaf Shuler , "dev@dpdk.org" Message-ID: <20180612131946.GU4025@6wind.com> References: <20180525161814.13873-1-adrien.mazarguil@6wind.com> <20180525161814.13873-2-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH 1/7] net/mlx5: rename confusing object in probe code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2018 13:20:03 -0000 On Sun, Jun 10, 2018 at 11:00:57AM +0000, Xueming(Steven) Li wrote: > Ack except one minor question below. > > - mlx5_glue->dv_query_device(attr_ctx, &attrs_out); > > - if (attrs_out.flags & MLX5DV_CONTEXT_FLAGS_MPW_ALLOWED) { > > - if (attrs_out.flags & MLX5DV_CONTEXT_FLAGS_ENHANCED_MPW) { > > + mlx5_glue->dv_query_device(ctx, &dv_attr); > > Should ctx be attr_ctx?. Indeed, seems like I didn't validate this patch on its own after splitting it from another. Will fix in v2, thanks. -- Adrien Mazarguil 6WIND