From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 1215C1EE49 for ; Wed, 13 Jun 2018 08:18:36 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jun 2018 23:18:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,217,1526367600"; d="scan'208";a="63645155" Received: from debian.sh.intel.com (HELO debian) ([10.67.104.228]) by fmsmga001.fm.intel.com with ESMTP; 12 Jun 2018 23:18:33 -0700 Date: Wed, 13 Jun 2018 14:18:39 +0800 From: Tiwei Bie To: Marvin Liu Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org Message-ID: <20180613061839.GA26433@debian> References: <20180608090724.20855-1-yong.liu@intel.com> <20180608090724.20855-2-yong.liu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180608090724.20855-2-yong.liu@intel.com> User-Agent: Mutt/1.9.5 (2018-04-13) Subject: Re: [dpdk-dev] [PATCH 1/7] vhost: announce VIRTIO_F_IN_ORDER support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jun 2018 06:18:37 -0000 On Fri, Jun 08, 2018 at 05:07:18PM +0800, Marvin Liu wrote: [...] > @@ -853,6 +853,10 @@ rte_vhost_driver_register(const char *path, uint64_t flags) > vsocket->supported_features = VIRTIO_NET_SUPPORTED_FEATURES; > vsocket->features = VIRTIO_NET_SUPPORTED_FEATURES; > > + /* Dequeue zero copy can't assure descriptors returned in order */ > + if (vsocket->dequeue_zero_copy) > + vsocket->features &= ~(1ULL << VIRTIO_F_IN_ORDER); You also need to clear this bit from vsocket->supported_features. Thanks