From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 1895E1D671 for ; Fri, 15 Jun 2018 13:25:45 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id o12-v6so9555962wrm.12 for ; Fri, 15 Jun 2018 04:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=csa14KMdOCL60MyeICyvCqs8Fz5GbjScGc/ZwK9QEE4=; b=rQEG3/dPi2fAbowjjHwNU6Fc/4dPFEqRXBxDF4FJIdMOEfpynpTzCql57or70LrmZS VLIanYZxIMerRixqRuHUrswXXQmT1QenCQz4E+BZvxrjc1ptApk+LpGx2q9rX8HJGf66 3E4gbDv8FROAEWYlVEiqcZyfCeXxu9W91V9JZpJF6kMS2qMPnp9QsRmqsWdTfov8+d0P dn94ZVlMjWgTWXKb5QsRRp974RYt73PDqhcnPBsvXf4bdTOINQ8f66Sx5ZoqsgI5B73L sxEvHY5fRog+jeCpycvOu2+JyxseGQn1P1a569vYXkWk5/bQExk//c2OGBxM3DYaMxMD D6ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=csa14KMdOCL60MyeICyvCqs8Fz5GbjScGc/ZwK9QEE4=; b=BElZq3Z3a3KyY6XuyfBjfdz4YKfz6sB5RzJU4d1hE9I7Pw0JBj8abxHsDr7hYRztIh 2Do4juDAEyD5Gr/R7F8sNX85dF3rTLmnKg2xrsTiA46iRCp0J+5WGT+vwwKmSvqs5TFh ou2bnnWiorPTPa8OcOR5ZQh1XbBZgaewqjfgTp2XrcvU+BraWEdxl781Tqg5inqV8ygl 2RA4z4h5bZXSYLqRpKBPrzd3V7FOmgjuUK5q9AJf3Ho1OVIZBdADAeD4bHRYDjNkZ4RU nd6Y4Oieg1SW3ENreOTWtB1K2VsJzkntYKCfNt8BSxg2449rf6WdiXceQLpk29aIoupN kVVw== X-Gm-Message-State: APt69E0BMlLf73rqsYWCrIYtjVVxV2J3lIkdgDY+dLwjHQJtQWfn7E4L tkzrrrXmp0JYsQrOvDyuKWJ/ X-Google-Smtp-Source: ADUXVKIKNmciPxkjdzWuW1G7izOMq7Yz0yAnbI1v7RKpCJ0Kj5HgEK+2nIyav0kTCufEt06eb8XCtw== X-Received: by 2002:adf:8bdb:: with SMTP id w27-v6mr1317759wra.169.1529061944913; Fri, 15 Jun 2018 04:25:44 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id l15-v6sm7512501wrs.95.2018.06.15.04.25.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Jun 2018 04:25:44 -0700 (PDT) Date: Fri, 15 Jun 2018 13:25:45 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: "Iremonger, Bernard" Cc: "dev@dpdk.org" , Adrien Mazarguil , "Lu, Wenzhuo" , "Wu, Jingjing" , "Awal, Mohammad Abdul" Message-ID: <20180615112545.cnwnx7mxk4sld3a6@laranjeiro-vm.dev.6wind.com> References: <8CEF83825BEC744B83065625E567D7C260CB3BE9@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CB3BE9@IRSMSX108.ger.corp.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: add NVGRE encap/decap support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2018 11:25:45 -0000 Hi Bernard, On Fri, Jun 15, 2018 at 09:32:02AM +0000, Iremonger, Bernard wrote: > Hi Nelio, > >[...] > > @@ -14927,6 +14930,81 @@ cmdline_parse_inst_t cmd_set_vxlan = { > > }, > > }; > > > > +/** Set VXLAN encapsulation details */ > > VXLAN should be NVGRE. >[...] Right, > > b/app/test-pmd/testpmd.c index 1c68c9d30..f54205949 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -408,6 +408,15 @@ struct vxlan_encap_conf vxlan_encap_conf = { > > .eth_dst = "\xff\xff\xff\xff\xff\xff", }; > > > > +struct nvgre_encap_conf nvgre_encap_conf = { > > + .select_ipv4 = 1, > > + .tni = "\x00\x00\x00", > > + .ipv4_src = IPv4(127, 0, 0, 1), > > + .ipv4_dst = IPv4(255, 255, 255, 255), > > Should there be .ipv6_src and .ipv6_dst here ? >[...] Yes indeed initialisation of IPv6 is missing. > > +- ``nvgre_decap``: Performs a decapsulation action by stripping all > > +headers of > > + the VXLAN tunnel network overlay from the matched flow. > > VXLAN should be NVGRE. > >[...] Here also, I am will update it in a V2. Thanks for you review, -- Nélio Laranjeiro 6WIND