* [dpdk-dev] [PATCH] vhost: fix missing increment of log cache count
@ 2018-06-15 13:48 ` Maxime Coquelin
2018-06-15 15:48 ` Ilya Maximets
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Maxime Coquelin @ 2018-06-15 13:48 UTC (permalink / raw)
To: dev, tiwei.bie, zhihong.wang
Cc: stable, xnhp0320, i.maximets, Maxime Coquelin
The log_cache_nb_elem was never incremented, resulting
in all dirty pages to be missed during live migration.
Fixes: c16915b87109 ("vhost: improve dirty pages logging performance")
Cc: stable@dpdk.org
Reported-by: Peng He <xnhp0320@icloud.com>
Cc: Ilya Maximets <i.maximets@samsung.com>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
lib/librte_vhost/vhost.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
index 528e01c8f..786a74f64 100644
--- a/lib/librte_vhost/vhost.h
+++ b/lib/librte_vhost/vhost.h
@@ -429,6 +429,7 @@ vhost_log_cache_page(struct virtio_net *dev, struct vhost_virtqueue *vq,
vq->log_cache[i].offset = offset;
vq->log_cache[i].val = (1UL << bit_nr);
+ vq->log_cache_nb_elem++;
}
static __rte_always_inline void
--
2.14.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] vhost: fix missing increment of log cache count
2018-06-15 13:48 ` [dpdk-dev] [PATCH] vhost: fix missing increment of log cache count Maxime Coquelin
@ 2018-06-15 15:48 ` Ilya Maximets
2018-06-18 3:22 ` Tiwei Bie
2018-06-23 6:52 ` Maxime Coquelin
2 siblings, 0 replies; 4+ messages in thread
From: Ilya Maximets @ 2018-06-15 15:48 UTC (permalink / raw)
To: Maxime Coquelin, dev, tiwei.bie, zhihong.wang; +Cc: stable, xnhp0320
On 15.06.2018 16:48, Maxime Coquelin wrote:
> The log_cache_nb_elem was never incremented, resulting
> in all dirty pages to be missed during live migration.
>
> Fixes: c16915b87109 ("vhost: improve dirty pages logging performance")
> Cc: stable@dpdk.org
>
> Reported-by: Peng He <xnhp0320@icloud.com>
> Cc: Ilya Maximets <i.maximets@samsung.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> lib/librte_vhost/vhost.h | 1 +
> 1 file changed, 1 insertion(+)
LGTM,
Acked-by: Ilya Maximets <i.maximets@samsung.com>
>
> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
> index 528e01c8f..786a74f64 100644
> --- a/lib/librte_vhost/vhost.h
> +++ b/lib/librte_vhost/vhost.h
> @@ -429,6 +429,7 @@ vhost_log_cache_page(struct virtio_net *dev, struct vhost_virtqueue *vq,
>
> vq->log_cache[i].offset = offset;
> vq->log_cache[i].val = (1UL << bit_nr);
> + vq->log_cache_nb_elem++;
> }
>
> static __rte_always_inline void
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] vhost: fix missing increment of log cache count
2018-06-15 13:48 ` [dpdk-dev] [PATCH] vhost: fix missing increment of log cache count Maxime Coquelin
2018-06-15 15:48 ` Ilya Maximets
@ 2018-06-18 3:22 ` Tiwei Bie
2018-06-23 6:52 ` Maxime Coquelin
2 siblings, 0 replies; 4+ messages in thread
From: Tiwei Bie @ 2018-06-18 3:22 UTC (permalink / raw)
To: Maxime Coquelin; +Cc: dev, zhihong.wang, stable, xnhp0320, i.maximets
On Fri, Jun 15, 2018 at 03:48:46PM +0200, Maxime Coquelin wrote:
> The log_cache_nb_elem was never incremented, resulting
> in all dirty pages to be missed during live migration.
>
> Fixes: c16915b87109 ("vhost: improve dirty pages logging performance")
> Cc: stable@dpdk.org
>
> Reported-by: Peng He <xnhp0320@icloud.com>
> Cc: Ilya Maximets <i.maximets@samsung.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> lib/librte_vhost/vhost.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
> index 528e01c8f..786a74f64 100644
> --- a/lib/librte_vhost/vhost.h
> +++ b/lib/librte_vhost/vhost.h
> @@ -429,6 +429,7 @@ vhost_log_cache_page(struct virtio_net *dev, struct vhost_virtqueue *vq,
>
> vq->log_cache[i].offset = offset;
> vq->log_cache[i].val = (1UL << bit_nr);
> + vq->log_cache_nb_elem++;
> }
>
> static __rte_always_inline void
> --
> 2.14.3
>
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] vhost: fix missing increment of log cache count
2018-06-15 13:48 ` [dpdk-dev] [PATCH] vhost: fix missing increment of log cache count Maxime Coquelin
2018-06-15 15:48 ` Ilya Maximets
2018-06-18 3:22 ` Tiwei Bie
@ 2018-06-23 6:52 ` Maxime Coquelin
2 siblings, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2018-06-23 6:52 UTC (permalink / raw)
To: dev, tiwei.bie, zhihong.wang; +Cc: stable, xnhp0320, i.maximets
On 06/15/2018 03:48 PM, Maxime Coquelin wrote:
> The log_cache_nb_elem was never incremented, resulting
> in all dirty pages to be missed during live migration.
>
> Fixes: c16915b87109 ("vhost: improve dirty pages logging performance")
> Cc:stable@dpdk.org
>
> Reported-by: Peng He<xnhp0320@icloud.com>
> Cc: Ilya Maximets<i.maximets@samsung.com>
> Signed-off-by: Maxime Coquelin<maxime.coquelin@redhat.com>
> ---
> lib/librte_vhost/vhost.h | 1 +
> 1 file changed, 1 insertion(+)
Applied to dpdk-next-virtio/master
Maxime
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-23 6:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20180615134909epcas3p1e953360a9deba597cf4b89058d3653bc@epcas3p1.samsung.com>
2018-06-15 13:48 ` [dpdk-dev] [PATCH] vhost: fix missing increment of log cache count Maxime Coquelin
2018-06-15 15:48 ` Ilya Maximets
2018-06-18 3:22 ` Tiwei Bie
2018-06-23 6:52 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).