From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 426051D0CB; Fri, 15 Jun 2018 16:14:39 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jun 2018 07:14:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,227,1526367600"; d="scan'208";a="208378139" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga004.jf.intel.com with SMTP; 15 Jun 2018 07:14:35 -0700 Received: by (sSMTP sendmail emulation); Fri, 15 Jun 2018 15:14:32 +0100 Date: Fri, 15 Jun 2018 15:14:32 +0100 From: Bruce Richardson To: Gavin Hu Cc: dev@dpdk.org, nd@arm.com, stable@dpdk.org Message-ID: <20180615141431.GB11108@bricha3-MOBL.ger.corp.intel.com> References: <20180615092605.12043-1-gavin.hu@arm.com> <20180615102143.12778-1-gavin.hu@arm.com> <20180615102143.12778-7-gavin.hu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180615102143.12778-7-gavin.hu@arm.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.0 (2018-05-17) Subject: Re: [dpdk-dev] [PATCH v10 6/6] devtools: expand meson cross compiling test coverage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2018 14:14:40 -0000 On Fri, Jun 15, 2018 at 06:21:43PM +0800, Gavin Hu wrote: > The default test script covers only default host cc compiler, either gcc or > clang, the fix is to cover both, gcc and clang. And also the build dirs are > changed to *-host-$c, indicating the difference of cc used. > > Fixes: a55277a788 ("devtools: add test script for meson builds") > Cc: stable@dpdk.org > > Signed-off-by: Gavin Hu > Reviewed-by: Phil Yang > Reviewed-by: Song Zhu > --- Apologies, some late comments inline below that I missed on previous reviews. > devtools/test-meson-builds.sh | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index 9bb5b93bd..f1553b7bd 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -44,11 +44,20 @@ done > # test compilation with minimal x86 instruction set > build build-x86-default -Dmachine=nehalem > > +# compile the general v8a also for clang to increase coverage > +f=config/arm/arm64_armv8_linuxapp_gcc > +export CC="ccache clang" > +build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2)-host-clang \ > + --cross-file $f > + This might be better just as e.g. +export CC="ccache clang" +build build-arm64-host-clang --cross-file config/arm/arm64_armv8_linuxapp_gcc to be shorter and more readable. You don't really need the armv8 part in the directory name, as it's primarily a test of the clang host build, so you can omit it to shorten the command to a single line with all hardcoded values, which is more readable than a version with tr filename mangling. > # enable cross compilation if gcc cross-compiler is found > for f in config/arm/arm*gcc ; do > c=aarch64-linux-gnu-gcc > if ! command -v $c >/dev/null 2>&1 ; then > - continue > + echo "## ERROR: $c is missing..." > + exit 1 I think this if check should be moved out of the block, and be before the test with clang, since that clang test will also fail. > fi > - build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2) --cross-file $f > + export CC="ccache gcc" > + build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2)-host-gcc \ > + --cross-file $f > done > -- > 2.11.0 >