DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ilya Maximets <i.maximets@samsung.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
	dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com
Cc: stable@dpdk.org, xnhp0320@icloud.com
Subject: Re: [dpdk-dev] [PATCH] vhost: fix missing increment of log cache count
Date: Fri, 15 Jun 2018 18:48:52 +0300	[thread overview]
Message-ID: <20180615154854eucas1p252a8e95e7cd7f52b4a11de2b2d6961e8~4YBkWzY5K1555915559eucas1p2I@eucas1p2.samsung.com> (raw)
In-Reply-To: <20180615134846.11641-1-maxime.coquelin@redhat.com>

On 15.06.2018 16:48, Maxime Coquelin wrote:
> The log_cache_nb_elem was never incremented, resulting
> in all dirty pages to be missed during live migration.
> 
> Fixes: c16915b87109 ("vhost: improve dirty pages logging performance")
> Cc: stable@dpdk.org
> 
> Reported-by: Peng He <xnhp0320@icloud.com>
> Cc: Ilya Maximets <i.maximets@samsung.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  lib/librte_vhost/vhost.h | 1 +
>  1 file changed, 1 insertion(+)

LGTM,
Acked-by: Ilya Maximets <i.maximets@samsung.com>


> 
> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
> index 528e01c8f..786a74f64 100644
> --- a/lib/librte_vhost/vhost.h
> +++ b/lib/librte_vhost/vhost.h
> @@ -429,6 +429,7 @@ vhost_log_cache_page(struct virtio_net *dev, struct vhost_virtqueue *vq,
>  
>  	vq->log_cache[i].offset = offset;
>  	vq->log_cache[i].val = (1UL << bit_nr);
> +	vq->log_cache_nb_elem++;
>  }
>  
>  static __rte_always_inline void
> 

  reply	other threads:[~2018-06-15 15:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180615134909epcas3p1e953360a9deba597cf4b89058d3653bc@epcas3p1.samsung.com>
2018-06-15 13:48 ` Maxime Coquelin
2018-06-15 15:48   ` Ilya Maximets [this message]
2018-06-18  3:22   ` Tiwei Bie
2018-06-23  6:52   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20180615154854eucas1p252a8e95e7cd7f52b4a11de2b2d6961e8~4YBkWzY5K1555915559eucas1p2I@eucas1p2.samsung.com' \
    --to=i.maximets@samsung.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=tiwei.bie@intel.com \
    --cc=xnhp0320@icloud.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).