From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id B996E1BF1C for ; Fri, 15 Jun 2018 17:48:57 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20180615154855euoutp02d725a72ef16576ce344501887d8c1ad9~4YBlvjwCF0069000690euoutp02M for ; Fri, 15 Jun 2018 15:48:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20180615154855euoutp02d725a72ef16576ce344501887d8c1ad9~4YBlvjwCF0069000690euoutp02M DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1529077735; bh=l/WmXR6xtcz/UJF4GBE9u7VdRYhTuuSRkTxJcsd6UM0=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=rT3mAfde5Qw3SDhjdJx4z9uWUGNnODjupuLX2RheDokfwJ3NyDFaRPzHMkc4RRp+E WzVNE+7tqanIE3uXLAov35njfEQVE+1aC7ZuOosYcLoxHM+jyXMIzu4zBAlpVjqwm4 JzUDTqygvCIkJqIyrec/qNkWL+Ig/t/Kn8eZOBNc= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180615154855eucas1p2cd851fecf27e06fcf6f962535042a682~4YBlEEuBL1555115551eucas1p2M; Fri, 15 Jun 2018 15:48:55 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 24.F4.05700.6EFD32B5; Fri, 15 Jun 2018 16:48:54 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20180615154854eucas1p252a8e95e7cd7f52b4a11de2b2d6961e8~4YBkWzY5K1555915559eucas1p2I; Fri, 15 Jun 2018 15:48:54 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20180615154853eusmtrp1db450b87fc3ab06551521ef97a5c57c0~4YBkA17yb0969109691eusmtrp1L; Fri, 15 Jun 2018 15:48:53 +0000 (GMT) X-AuditID: cbfec7f2-1c1ff70000011644-c3-5b23dfe6813e Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 6B.D6.04178.5EFD32B5; Fri, 15 Jun 2018 16:48:53 +0100 (BST) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20180615154853eusmtip1d856a94cbc546a8e208567ec16b1ceed~4YBji_-tB2887128871eusmtip1-; Fri, 15 Jun 2018 15:48:53 +0000 (GMT) To: Maxime Coquelin , dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com Cc: stable@dpdk.org, xnhp0320@icloud.com From: Ilya Maximets Date: Fri, 15 Jun 2018 18:48:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180615134846.11641-1-maxime.coquelin@redhat.com> Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNKsWRmVeSWpSXmKPExsWy7djPc7rP7itHG7TdMLZ492k7k8WV9p/s Fsc697BY/Ov4w26xteE/k0X//n1sFpsvTmJyYPf4tWApq8fyaUcZPRbvecnk8X7fVTaPvi2r GANYo7hsUlJzMstSi/TtErgylly5yFTwhr1i/5O7LA2MB9m6GDk5JARMJL5+38jUxcjFISSw glHiyrXpzBDOF0aJb1M+s0M4n4Gc2bcZYVqO3+9jgUgsZ5R4+qEHquojo8SPU3/AqoQFXCSm /1zNBGKLCORK7HjazQpiMwtoSDw48Z8FxGYT0JE4tfoIWD2LgKrEsU9/wWxRgQiJpuc/2UFs XgFBiZMzn4DVcwo4SDx7/okRYo64RNOXlVAz5SW2v50DdreEwDp2iZOP3wI1cAA1l0n82xoG cbWLxIGmPVAfCEu8Or6FHcKWkTg9uYcFwq6XuN/ykhFiTgejxPRD/5ggEvYSW16fYweZySyg KbF+lz5E2FHi2KIXzCBhCQE+iRtvBSHO4ZOYtG06VJhXoqNNCKJaReL3weXMELaUxM13n9kn MCrNQvLkLCSPzULy2CyEvQsYWVYxiqeWFuempxYb5qWW6xUn5haX5qXrJefnbmIEJqHT/45/ 2sH49VLSIUYBDkYlHl6B08rRQqyJZcWVuYcYJTiYlUR4e0uUooV4UxIrq1KL8uOLSnNSiw8x SnOwKInzxmnURQkJpCeWpGanphakFsFkmTg4pRoYZ/IsXix54+uCto7D96dX3bHblOFi8C37 gX9Jqappjdm3v9o7p5vMnnHNx3ZG28p1LX+fC/U6HeyIkJoQyn7SfXKO0kchtVDDHPdlU/br BxZ8fXIxZEt2wJcukdBP0071T56vdSar/di2zb0mzdreiXm7JqXHLtkbyr6fLfC7i4qEuv2D uem/lViKMxINtZiLihMBhZI0sj4DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLIsWRmVeSWpSXmKPExsVy+t/xu7pP7ytHGyy9Zmnx7tN2Josr7T/Z LY517mGx+Nfxh91ia8N/Jov+/fvYLDZfnMTkwO7xa8FSVo/l044yeize85LJ4/2+q2wefVtW MQawRunZFOWXlqQqZOQXl9gqRRtaGOkZWlroGZlY6hkam8daGZkq6dvZpKTmZJalFunbJehl LLlykangDXvF/id3WRoYD7J1MXJySAiYSBy/38cCYgsJLGWU2LYyFCIuJfHj1wVWCFtY4s+1 LqB6LqCa94wSt+atYQdJCAu4SEz/uZoJxBYRyJXo2NnCCGIzC2hIPDjxH2roZEaJrXsNQGw2 AR2JU6uPgNXwCthJbH20GKyGRUBV4tinv2BxUYEIiXvnP7FB1AhKnJz5BKyGU8BB4tnzT1Dz 1SX+zLvEDGGLSzR9WckKYctLbH87h3kCo9AsJO2zkLTMQtIyC0nLAkaWVYwiqaXFuem5xYZ6 xYm5xaV56XrJ+bmbGIFRt+3Yz807GC9tDD7EKMDBqMTDm3FWOVqINbGsuDL3EKMEB7OSCG9v iVK0EG9KYmVValF+fFFpTmrxIUZToOcmMkuJJucDE0JeSbyhqaG5haWhubG5sZmFkjjveYPK KCGB9MSS1OzU1ILUIpg+Jg5OqQbG6UtSFuZ5rOos2R5bHrBvfkDtPquNqXdqVtUEndBiU6vi nv786m3nj9Zewk332G+qiLn9neots8b8eunyD9mWi2/4a/if3fePp+TCxbSpKTODz1YKzXo2 I+ljZP/nVzz280vv32p24E7i+H/Pu5trTdOs3CvWM+/azHVrbfEOC8k75HTJxa5WiaU4I9FQ i7moOBEA+NCUWNACAAA= Message-Id: <20180615154854eucas1p252a8e95e7cd7f52b4a11de2b2d6961e8~4YBkWzY5K1555915559eucas1p2I@eucas1p2.samsung.com> X-CMS-MailID: 20180615154854eucas1p252a8e95e7cd7f52b4a11de2b2d6961e8 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20180615134909epcas3p1e953360a9deba597cf4b89058d3653bc X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180615134909epcas3p1e953360a9deba597cf4b89058d3653bc References: <20180615134846.11641-1-maxime.coquelin@redhat.com> Subject: Re: [dpdk-dev] [PATCH] vhost: fix missing increment of log cache count X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2018 15:48:57 -0000 On 15.06.2018 16:48, Maxime Coquelin wrote: > The log_cache_nb_elem was never incremented, resulting > in all dirty pages to be missed during live migration. > > Fixes: c16915b87109 ("vhost: improve dirty pages logging performance") > Cc: stable@dpdk.org > > Reported-by: Peng He > Cc: Ilya Maximets > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost.h | 1 + > 1 file changed, 1 insertion(+) LGTM, Acked-by: Ilya Maximets > > diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h > index 528e01c8f..786a74f64 100644 > --- a/lib/librte_vhost/vhost.h > +++ b/lib/librte_vhost/vhost.h > @@ -429,6 +429,7 @@ vhost_log_cache_page(struct virtio_net *dev, struct vhost_virtqueue *vq, > > vq->log_cache[i].offset = offset; > vq->log_cache[i].val = (1UL << bit_nr); > + vq->log_cache_nb_elem++; > } > > static __rte_always_inline void >