From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id F3C732BF3; Mon, 18 Jun 2018 05:22:15 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jun 2018 20:22:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,237,1526367600"; d="scan'208";a="58097154" Received: from debian.sh.intel.com (HELO debian) ([10.67.104.228]) by FMSMGA003.fm.intel.com with ESMTP; 17 Jun 2018 20:22:12 -0700 Date: Mon, 18 Jun 2018 11:22:17 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: dev@dpdk.org, zhihong.wang@intel.com, stable@dpdk.org, xnhp0320@icloud.com, i.maximets@samsung.com Message-ID: <20180618032216.GA7022@debian> References: <20180615134846.11641-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180615134846.11641-1-maxime.coquelin@redhat.com> User-Agent: Mutt/1.9.5 (2018-04-13) Subject: Re: [dpdk-dev] [PATCH] vhost: fix missing increment of log cache count X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 03:22:17 -0000 On Fri, Jun 15, 2018 at 03:48:46PM +0200, Maxime Coquelin wrote: > The log_cache_nb_elem was never incremented, resulting > in all dirty pages to be missed during live migration. > > Fixes: c16915b87109 ("vhost: improve dirty pages logging performance") > Cc: stable@dpdk.org > > Reported-by: Peng He > Cc: Ilya Maximets > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h > index 528e01c8f..786a74f64 100644 > --- a/lib/librte_vhost/vhost.h > +++ b/lib/librte_vhost/vhost.h > @@ -429,6 +429,7 @@ vhost_log_cache_page(struct virtio_net *dev, struct vhost_virtqueue *vq, > > vq->log_cache[i].offset = offset; > vq->log_cache[i].val = (1UL << bit_nr); > + vq->log_cache_nb_elem++; > } > > static __rte_always_inline void > -- > 2.14.3 > Reviewed-by: Tiwei Bie