From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 4CBFC2BB0 for ; Mon, 18 Jun 2018 11:38:36 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id n5-v6so14207794wmc.5 for ; Mon, 18 Jun 2018 02:38:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=KLyxVXj3pUwBHaR1Jxxyb/zq583aaBoIzbMOQ/+gZOQ=; b=wbULsAUn8Zfb+00YOmVu4QM+PVxraER2ETI6V32x4gVzSUFPNlqU4eqEoCglqHChK2 HsdG1nB+UO/WZPeSrAU/G/FBOIDrBxjLdJA4g2dnWezgILFoEclx+UnuB2r2YLkxrh4R i6boog5zl8sCuZ0PXzMmBoacZKlmiSF9QUoZDT1PKkF8h2XCeIcvClIMglKkcMhi5inm J70mTEthg2ADAlwgJ2X4bols/7bBhtPSWvXIhwJVnPpf9wO5VoyfxjJ4HTbPb/LoBso1 gnoQx/PId+cNiiioAg4TLs0VD6an4YjYYdfX1smnhMdA3PY0DDkSWxBNS4c1WkZHqeSD nwaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=KLyxVXj3pUwBHaR1Jxxyb/zq583aaBoIzbMOQ/+gZOQ=; b=BxjalPF+QPOZY3DlYmA78idLSYOPpL8beZRZTj3jgtNfAME9JpL8b5DUgaScsrVjGz ptsCSTjUW17rc728R5IaOp55hKXriDLGdc2N/MSHAIh7IhuZEzP4kWFYVCgMwP+dsraX QAy3ggPsPN7h59o15f2noMbQDJznAOY3EI3AxWTd08ApYh24jdu5yxUWeahpua1xUn7m c8jbccSUrYdH1s3HVQB/FTS6OapRXgxffyvI2ZVr1vmCJn7XQqBa+AX7G7X1/eAWiD6/ CizNDonvDIs/Inqw91JLeJylvo2rLsexgLLJWnEd+Kpgh+2qtqfoqXpzLgG/ffgze7yA JamQ== X-Gm-Message-State: APt69E2/FlZmX78v3sNwN5FD6svlT0XHwzXGpJ9n7SCWDHHNrQa/Skrb HmYl9w7ltxNDNVCgEqyLuBuf X-Google-Smtp-Source: ADUXVKKqhEqbrfiQx45SWZaCN51SxNM5+O9rxPfneCtREKvhcj/fcUs/OYH7prG0EMwkFFansya/nw== X-Received: by 2002:a1c:470b:: with SMTP id u11-v6mr7730114wma.49.1529314716025; Mon, 18 Jun 2018 02:38:36 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id g129-v6sm7609178wmf.5.2018.06.18.02.38.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 02:38:35 -0700 (PDT) Date: Mon, 18 Jun 2018 11:38:43 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Ferruh Yigit Cc: dev@dpdk.org, Adrien Mazarguil , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , Mohammad Abdul Awal Message-ID: <20180618093843.y34xrnrgjjpm5myf@laranjeiro-vm.dev.6wind.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 09:38:36 -0000 On Mon, Jun 18, 2018 at 10:05:03AM +0100, Ferruh Yigit wrote: > On 6/18/2018 9:52 AM, Nelio Laranjeiro wrote: > > This series adds an easy and maintainable configuration version support for > > those two actions for 18.08 by using global variables in testpmd to store the > > necessary information for the tunnel encapsulation. Those variables are used > > in conjunction of RTE_FLOW_ACTION_{VXLAN,NVGRE}_ENCAP action to create easily > > the action for flows. > > > > A common way to use it: > > > > set vxlan ipv4 4 4 4 127.0.0.1 128.0.0.1 11:11:11:11:11:11 22:22:22:22:22:22 > > flow create 0 ingress pattern end actions vxlan_encap / queue index 0 / end > > > > set vxlan ipv6 4 4 4 ::1 ::2222 11:11:11:11:11:11 22:22:22:22:22:22 > > flow create 0 ingress pattern end actions vxlan_encap / queue index 0 / end > > > > set nvgre ipv4 4 127.0.0.1 128.0.0.1 11:11:11:11:11:11 22:22:22:22:22:22 > > flow create 0 ingress pattern end actions nvgre_encap / queue index 0 / end > > > > set nvgre ipv6 4 ::1 ::2222 11:11:11:11:11:11 22:22:22:22:22:22 > > flow create 0 ingress pattern end actions nvgre_encap / queue index 0 / end > > > > This also replace the proposal done by Mohammad Abdul Awal [1] which handles > > in a more complex way for the same work. > > Hi Nelio, > > Is this set on top of mentioned set? Hi Ferruh, No it is another implementation of Declan's API. It can be directly applied on top of the current DPDK code without any other patch. > If so shouldn't the set has the Awal's sign-off too? > Are you replacing someone else patch with dropping his sign-off? > > > Note this API has already a modification planned for 18.11 [2] thus those > > series should have a limited life for a single release. > > > > [1] https://dpdk.org/ml/archives/dev/2018-May/101403.html > > [2] https://dpdk.org/ml/archives/dev/2018-June/103485.html > > > > > > Changes in v2: > > > > - add default IPv6 values for NVGRE encapsulation. > > - replace VXLAN to NVGRE in comments concerning NVGRE layer. > > > > Nelio Laranjeiro (2): > > app/testpmd: add VXLAN encap/decap support > > app/testpmd: add NVGRE encap/decap support > > > > app/test-pmd/cmdline.c | 169 +++++++++++++ > > app/test-pmd/cmdline_flow.c | 248 ++++++++++++++++++++ > > app/test-pmd/testpmd.c | 28 +++ > > app/test-pmd/testpmd.h | 28 +++ > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 25 ++ > > 5 files changed, 498 insertions(+) -- Nélio Laranjeiro 6WIND