From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg0-f65.google.com (mail-pg0-f65.google.com [74.125.83.65])
 by dpdk.org (Postfix) with ESMTP id A97532C38
 for <dev@dpdk.org>; Mon, 18 Jun 2018 23:02:13 +0200 (CEST)
Received: by mail-pg0-f65.google.com with SMTP id m5-v6so8091028pgd.3
 for <dev@dpdk.org>; Mon, 18 Jun 2018 14:02:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=bG1D1RXbfV6Yk0k/+63MpCW9bTMidR/QFU5gr/r9p7A=;
 b=EAymBZdmf6ZqjG2wC5dIfm5QIdbVFSj30Z6orkInp/kDx32yNKaqHQve0g8RjpGLp2
 yNfDGhwtFN55Ecq8JwIO9pPnH+xukLu7gVI4ItkhCVyP/NrHQr1M7etAgrtf36b0SV4j
 zKF76ZCCoJVjPABa/XCfwhRGiFu/GCf55l27vp7zoRPrOYbj5j9JBKcqp06JpoQWjr7n
 aIU0hnJGPnOM+wNOSAVsoOtxFAtBUw+R/iUHWHelriMjO3kJPL9z4TgKBqKBnOS3JUHk
 L8J7MvFwvaQXRbUKgUOwnej9KfVlsIErNr7JtYx40pjNTJv+a3QpeUnaLHfWT+M71dOD
 mJMA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=bG1D1RXbfV6Yk0k/+63MpCW9bTMidR/QFU5gr/r9p7A=;
 b=AJgc7SjaFNEgLrjpZtN2x3bnTypahVtBswWkJerMsMOGA71LAbaV4LrXgUjhwGkxac
 iWNoFKxMwOAexFrPPKpXEtpi7kRJDQUYjwTTmKTHgrVI343T0Z13KXVW67afkbblUhLU
 u6gbo2RuEvN+tNoHEceXRozjr7XYbbzkT6v6pEqT7vZzRdo8gvkmdDVIZKnBj8PrRify
 YqktJtKlN+Ou5EVHSgE6bvbH7FegjLlDZkNgNpouUhbesTk+qRsYX98GcUNAk+namMG5
 vIqmpyl4cWvFxdjN2eDUHEqtz+uS4kI/WxJiyETn2QY07zlJ//FoWFZDhM6OcyENlmRg
 UEOQ==
X-Gm-Message-State: APt69E19f9G0ld/yHBzpi33DMhdG1I4IOE4VubX2zWe3fN72XGg6UIAU
 b2X1GL/fOgbqAg2klKVtaPuK+x63jVI=
X-Google-Smtp-Source: ADUXVKLHBUpkyWmqkwb/cXM7Jio38vGeAb31dR3nzq2N3YkEFjj4/OtvREaBribxN2mVjSaIaw+cUw==
X-Received: by 2002:a65:614e:: with SMTP id
 o14-v6mr12545431pgv.308.1529355732789; 
 Mon, 18 Jun 2018 14:02:12 -0700 (PDT)
Received: from xeon-e3 (204-195-35-107.wavecable.com. [204.195.35.107])
 by smtp.gmail.com with ESMTPSA id t13-v6sm18624502pgv.43.2018.06.18.14.02.12
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Mon, 18 Jun 2018 14:02:12 -0700 (PDT)
Date: Mon, 18 Jun 2018 14:02:10 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>, Wenzhuo Lu
 <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, Bernard
 Iremonger <bernard.iremonger@intel.com>, Mohammad Abdul Awal
 <mohammad.abdul.awal@intel.com>
Message-ID: <20180618140210.431f2771@xeon-e3>
In-Reply-To: <9356cee477d0d3ea3984f3bafee032d92554a7e0.1529311722.git.nelio.laranjeiro@6wind.com>
References: <cover.1529311722.git.nelio.laranjeiro@6wind.com>
 <9356cee477d0d3ea3984f3bafee032d92554a7e0.1529311722.git.nelio.laranjeiro@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add VXLAN encap/decap
 support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Jun 2018 21:02:14 -0000

On Mon, 18 Jun 2018 10:52:54 +0200
Nelio Laranjeiro <nelio.laranjeiro@6wind.com> wrote:

>  
> +struct vxlan_encap_conf vxlan_encap_conf = {
> +	.select_ipv4 = 1,
> +	.vni = "\x00\x00\x00",
> +	.udp_src = RTE_BE16(1),

Overall looks good. One enhancement I would suggest is to implement generating
the UDP source port based on a hash of fields from inner packet (as suggested
in RFC 7348).  This would be enabled by default (use udp source port of 0
as a flag to enable it).