From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id C083D1559 for ; Tue, 19 Jun 2018 09:32:35 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id x4-v6so19372575wro.11 for ; Tue, 19 Jun 2018 00:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=z0wInZC5pOu85KSZttBd/pGt9giOx5wUaih5RHo8TkM=; b=myZkbCtcpv3vThR1JypBb5j6I9DYMQ/R/gZ14NFCG2rC8aIP65yDuvar/Kdv8xx0uJ JY6KtdyJdE5KDqNWRtbRaKJXUH0vNmwg7zUbJ+dGuYIAONK49AM3iPa8KmADCBicxZpD xhqM6vkWg+lrdztjPtsWXXolBPiIgy58rkZogn8iowC5QIo6Hie/4W0C5APKoPDLodM9 wxpApUr5i/Oz2/i3zuyXrFUC1n/K8H9AZxeqh1ll7+RPPMcWmpDiDR7aEGF9aTZTf6tQ METhrjTl1J2bHatz4/W4dyHzfWZK/wxKMPO0bZ392m+TJNxrmqT/t7TSkdaL5+T5t5z4 En/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=z0wInZC5pOu85KSZttBd/pGt9giOx5wUaih5RHo8TkM=; b=HrJeveI+chWXo1y3IBfP9S3b6JSFKfH0paKMqLqoZ2ap3ylCf4XYPBcMONNoePadq5 WSa/ehIE43+FVz9G9L9n5oBawk4v82tXQfZsY4D0drz9qaZlLaaIMnzl6EdQGwzPuuaO g52/OS4SVuEZTzxNUHTUiW31uM5DRIICFxwVZduBws+EGHiLq+pHImngtPnXTYfy2PRs fASObskQFAJ8SJVfX7ZOzZwvnv2681byRPqLlZrjkW8wNIZ9p5GC1YAHUERxhtTrD5Fq yluIbL+RNUrN4O589OJzl3sa6ayzApSHQV5iPWjI0DlxAkCTwNHiQTKwxTAG62KIQtat H8Ew== X-Gm-Message-State: APt69E1q1RejeVFz6+w1bDhNL7cQDa2xDkcBJLLXLFtcPIkjFCjXzwoG Oly/j6npAMgFuEpDa9RJ6vIe X-Google-Smtp-Source: ADUXVKIJo86gfL71NFHYVNazpIGUlbUwqqF0GLXnfVhkDS1UbEXXfy0ItjEj/QpIvj5tmLRmUxWOAA== X-Received: by 2002:adf:fd05:: with SMTP id e5-v6mr12394596wrr.280.1529393555256; Tue, 19 Jun 2018 00:32:35 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id n7-v6sm19718571wrr.39.2018.06.19.00.32.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Jun 2018 00:32:34 -0700 (PDT) Date: Tue, 19 Jun 2018 09:32:44 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Ferruh Yigit Cc: dev@dpdk.org, Adrien Mazarguil , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , Mohammad Abdul Awal Message-ID: <20180619073244.lbl33zd3pjlapkq3@laranjeiro-vm.dev.6wind.com> References: <20180618093843.y34xrnrgjjpm5myf@laranjeiro-vm.dev.6wind.com> <3311e792-134b-b8d3-0a9b-7695877ac671@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3311e792-134b-b8d3-0a9b-7695877ac671@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2018 07:32:35 -0000 On Mon, Jun 18, 2018 at 03:40:53PM +0100, Ferruh Yigit wrote: > On 6/18/2018 10:38 AM, Nélio Laranjeiro wrote: > > On Mon, Jun 18, 2018 at 10:05:03AM +0100, Ferruh Yigit wrote: > >> On 6/18/2018 9:52 AM, Nelio Laranjeiro wrote: > >>> This series adds an easy and maintainable configuration version support for > >>> those two actions for 18.08 by using global variables in testpmd to store the > >>> necessary information for the tunnel encapsulation. Those variables are used > >>> in conjunction of RTE_FLOW_ACTION_{VXLAN,NVGRE}_ENCAP action to create easily > >>> the action for flows. > >>> > >>> A common way to use it: > >>> > >>> set vxlan ipv4 4 4 4 127.0.0.1 128.0.0.1 11:11:11:11:11:11 22:22:22:22:22:22 > >>> flow create 0 ingress pattern end actions vxlan_encap / queue index 0 / end > >>> > >>> set vxlan ipv6 4 4 4 ::1 ::2222 11:11:11:11:11:11 22:22:22:22:22:22 > >>> flow create 0 ingress pattern end actions vxlan_encap / queue index 0 / end > >>> > >>> set nvgre ipv4 4 127.0.0.1 128.0.0.1 11:11:11:11:11:11 22:22:22:22:22:22 > >>> flow create 0 ingress pattern end actions nvgre_encap / queue index 0 / end > >>> > >>> set nvgre ipv6 4 ::1 ::2222 11:11:11:11:11:11 22:22:22:22:22:22 > >>> flow create 0 ingress pattern end actions nvgre_encap / queue index 0 / end > >>> > >>> This also replace the proposal done by Mohammad Abdul Awal [1] which handles > >>> in a more complex way for the same work. > >> > >> Hi Nelio, > >> > >> Is this set on top of mentioned set? > > > > Hi Ferruh, > > > > No it is another implementation of Declan's API. It can be directly > > applied on top of the current DPDK code without any other patch. > > I mean "based on" more than "on top of". So if this code is based on referenced > patchset, I believe it should keep original sign-off. > > If this code is completely new implementation that replaces referenced patchset, > I believe it would be nice to comment on the original patch or communicate about > it instead of just sending another set to replace original one. Hi Ferruh, I agree with your point of view but my intention was to show how hard for an application it will be to implement such actions (as mentioned by Adrien [1][2]) whereas Mohammad has made the implementation for the testpmd command line interactive mode. That is also the reason why I've copied Mohammad at the first place in my series. Note that such implementation request has been made by Thomas [3] even with it, it has entered DPDK without it. I did not comment on his series because I don't have any reason to block it, if his series enters, mine just won't I also agree with that, there is no need to have both implementation in DPDK, but it worse to show how an application may have to deal with such actions. > >> If so shouldn't the set has the Awal's sign-off too? > >> Are you replacing someone else patch with dropping his sign-off? > >> > >>> Note this API has already a modification planned for 18.11 [2] thus those > >>> series should have a limited life for a single release. > >>> > >>> [1] https://dpdk.org/ml/archives/dev/2018-May/101403.html > >>> [2] https://dpdk.org/ml/archives/dev/2018-June/103485.html > >>> > >>> > >>> Changes in v2: > >>> > >>> - add default IPv6 values for NVGRE encapsulation. > >>> - replace VXLAN to NVGRE in comments concerning NVGRE layer. > >>> > >>> Nelio Laranjeiro (2): > >>> app/testpmd: add VXLAN encap/decap support > >>> app/testpmd: add NVGRE encap/decap support > >>> > >>> app/test-pmd/cmdline.c | 169 +++++++++++++ > >>> app/test-pmd/cmdline_flow.c | 248 ++++++++++++++++++++ > >>> app/test-pmd/testpmd.c | 28 +++ > >>> app/test-pmd/testpmd.h | 28 +++ > >>> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 25 ++ > >>> 5 files changed, 498 insertions(+) > > > Regards, [1] https://mails.dpdk.org/archives/dev/2018-April/095945.html [2] https://mails.dpdk.org/archives/dev/2018-April/098124.html [3] https://mails.dpdk.org/archives/dev/2018-April/099799.html -- Nélio Laranjeiro 6WIND