From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id EA78E2C15 for ; Tue, 19 Jun 2018 11:44:08 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id o12-v6so19810619wrm.12 for ; Tue, 19 Jun 2018 02:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=jWhIzmstnDtc7eUkitswNJSh5wQ1g2Gs0RGaSixllIM=; b=FXqK2+eER4zvTnFvsZBaj9vwp+G+9uV1iEZuQ+T7RLkuF3XD9i1p6sOUiKsN+Z9znJ 7Wg/j8pphwnhJW76ZBFjs8DeN2FL5b9eBs9CrORTvERN2subjwNlWZ+mcqmttvHVyCMc ktYDmOwTi3IuJWTjTIGx1mQmc1t+Tv/vUBbCIHcV96fbKquiqplf/S8cGrGbnddVqkU4 ZR7OZXdwAiYR8LW1QfiFyfYuNFPUsrDo7AYuPufVaAQ+5EKxCXQJxj/D7HmU8NVUuDPf KKK2J+C+IXtPmzZeEcAtuTZgeYIVdIYCZ9HTUhddQmtBKXdLDdITQFcCkgFYkDlZ1xjB SYnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=jWhIzmstnDtc7eUkitswNJSh5wQ1g2Gs0RGaSixllIM=; b=LANCBxCZ9HamJyPCT08jWaCuM6y41ng7xqyoZ63n0Jtkf9dfQhHVyG2Gph2J3oX2ic 7K4v2I4Y8JqMvNykx+xxRpGeLcx4oKRJJFHtU1O38vclHl3CNrzecEw7ehhSzq8ZY+v2 Sh42XEyLwOfYw7r2AmTOJ3TnsYhVT1XkUDLYu+z/HoyE4GFK8+d8Xopl5HPgqEILdo40 ONChzomiEwnzK6ReVX1VIU/OSC2eIi+7y68ChplEB3n+thc+cculyn/rKnCDZ06O0WEl DQD2I5JfUA9Nr+iSckt/8WtIUaHPAEjrX1n4k1+ZPLPywqz2oAanku5Y13rFXiRC1+l7 u3zA== X-Gm-Message-State: APt69E0CUjtrfOPdqvHfj6p7i9DzkQIXvCpaY6D9fD/PUvew96+zC5nv 4KFoeHpQ5kxka375SnFYEu9l+dRZ0Q== X-Google-Smtp-Source: ADUXVKIF3QrGVOcIO3tZjo30bymaGO8/i26hK1cjxcwqO+L35MNhZwtVKwfOruTE50HYRdRmVgPmkw== X-Received: by 2002:adf:d08b:: with SMTP id y11-v6mr13885465wrh.152.1529401448784; Tue, 19 Jun 2018 02:44:08 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id h18-v6sm8933025wrq.36.2018.06.19.02.44.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Jun 2018 02:44:08 -0700 (PDT) Date: Tue, 19 Jun 2018 11:44:18 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Stephen Hemminger Cc: dev@dpdk.org, Adrien Mazarguil , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , Mohammad Abdul Awal Message-ID: <20180619094418.4y2mcx2oegreyz6t@laranjeiro-vm.dev.6wind.com> References: <9356cee477d0d3ea3984f3bafee032d92554a7e0.1529311722.git.nelio.laranjeiro@6wind.com> <20180618140210.431f2771@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180618140210.431f2771@xeon-e3> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add VXLAN encap/decap support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2018 09:44:09 -0000 On Mon, Jun 18, 2018 at 02:02:10PM -0700, Stephen Hemminger wrote: > On Mon, 18 Jun 2018 10:52:54 +0200 > Nelio Laranjeiro wrote: > > > > > +struct vxlan_encap_conf vxlan_encap_conf = { > > + .select_ipv4 = 1, > > + .vni = "\x00\x00\x00", > > + .udp_src = RTE_BE16(1), > > Overall looks good. One enhancement I would suggest is to implement generating > the UDP source port based on a hash of fields from inner packet (as suggested > in RFC 7348). This would be enabled by default (use udp source port of 0 > as a flag to enable it). I'll make the modification for the v4, Thanks, -- Nélio Laranjeiro 6WIND