From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 3FE5323A; Tue, 19 Jun 2018 12:14:34 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jun 2018 03:14:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,242,1526367600"; d="scan'208";a="238382971" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga005.fm.intel.com with SMTP; 19 Jun 2018 03:14:30 -0700 Received: by (sSMTP sendmail emulation); Tue, 19 Jun 2018 11:14:29 +0100 Date: Tue, 19 Jun 2018 11:14:28 +0100 From: Bruce Richardson To: Gavin Hu Cc: dev@dpdk.org, nd@arm.com, stable@dpdk.org Message-ID: <20180619101428.GC23348@bricha3-MOBL.ger.corp.intel.com> References: <20180615102143.12778-1-gavin.hu@arm.com> <20180619013746.13268-1-gavin.hu@arm.com> <20180619013746.13268-7-gavin.hu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180619013746.13268-7-gavin.hu@arm.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.0 (2018-05-17) Subject: Re: [dpdk-dev] [PATCH v11 6/6] devtools: expand meson cross compiling test coverage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2018 10:14:34 -0000 On Tue, Jun 19, 2018 at 09:37:46AM +0800, Gavin Hu wrote: > The default test script covers only default host cc compiler, either gcc or > clang, the fix is to increase the coverage by adding one more to cover > clang and the others for gcc, also the build dirs are changed to *-host-$c, > indicating the difference of cc used. > > Fixes: a55277a788 ("devtools: add test script for meson builds") > Cc: stable@dpdk.org > > Signed-off-by: Gavin Hu > Reviewed-by: Phil Yang > Reviewed-by: Song Zhu > --- > devtools/test-meson-builds.sh | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index 9bb5b93bd..f0912d109 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -44,11 +44,18 @@ done > # test compilation with minimal x86 instruction set > build build-x86-default -Dmachine=nehalem > > +# compile the general v8a also for clang to increase coverage > +export CC="ccache clang" > +build build-arm64-host-clang --cross-file config/arm/arm64_armv8_linuxapp_gcc > + This will fail if the cross-gcc is not present. You still need to move the check out of the loop below to above this build call. > # enable cross compilation if gcc cross-compiler is found > for f in config/arm/arm*gcc ; do > c=aarch64-linux-gnu-gcc > if ! command -v $c >/dev/null 2>&1 ; then > - continue > + echo "## ERROR: $c is missing..." > + exit 1 > fi > - build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2) --cross-file $f > + export CC="ccache gcc" > + build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2)-host-gcc \ > + --cross-file $f Minor nit: I'd tend to leave off the "host-gcc" part for brevity. If one build is marked as host-clang, I think most folks unfamiliar with the script will probably guess that gcc is the host compiler in unstated cases. > done > -- > 2.11.0 >