From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 93A3958C4 for ; Wed, 20 Jun 2018 09:10:22 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id f16-v6so2077158wrm.3 for ; Wed, 20 Jun 2018 00:10:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=DMF+5ZKOFZNn9DY7El7oJ+scKwkCLPHTn85/McVEP2c=; b=xGaiu87fU6ffz0ldlUdl4oc4oEiq7b5/NiIRsrBHJqZ5GmyQNkbLAdWmfv7Eg8enDQ CSb0yDBWJaw/w0tlBCTe1ZB+n/zXBbFLI/hOm3EGs3kFgHLTILYM+9OYY+SH55nU+Hh+ /5XHls3/c8rd8YJYh/qUTwuYSjeGkg6w9r3ekdReyKbpgCWSRm5Gp/t6837UVdkH6zQj FxMWy1LpWqkq7xjURFwFj3PwBrFJrChCFiM+ooZCrxr/QXmHTjoZ5LT40bo/n1aLGt4C l4fCD2WxoiRD1ICTa7GJFWaN6a0wBSTjN/su+Iyg+BwJazkvEYM1hKwcTWvanitO02HK dArA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=DMF+5ZKOFZNn9DY7El7oJ+scKwkCLPHTn85/McVEP2c=; b=iSsifUi7RTAzjZj40auE+qo4hgCw3xBQWRBLjduKgI+sUQL9sA/94dWP4/Vvbeg4it P3C/cp23OhxVGXhG1HbYAVEhiUtE8Lp++oFewHr7zWAbhuo1xDyeljXnuis/X0vMM0Us ltO0230TdYxC1iiJXPuRe1goxm0TrmWZbWRfY5DQA/Qa7r5YJ1+P2k2Plof7dA8raOpk gQyjSxzx6Z4hRmIjbhO0hOcu2MGEaW1tFwbnvHoeShVgSvjXaNKks+cd8yhjuatcsIqB ZCa4n2FJ8VnRMw7F+UR2WWQMIxcCyrSI0n254XT4OFuTDvQ/x4M38TCkuy9cRxgbHGIl /2Eg== X-Gm-Message-State: APt69E1H/FKOm4tViOM3WKRMS0KmE4vU9BWWBt3/LEAEmH2MDz+6EIBp PKZC4RDYvNpwtsHPTyjhit2I28fEAg== X-Google-Smtp-Source: ADUXVKKP164BVM3XKpoXKH2rUX4KpSTY1QV0z8ZmzIUCd1V0YiQ82FQzk6w8ikiw5fxu+kTdiltMNQ== X-Received: by 2002:adf:ea44:: with SMTP id j4-v6mr16898227wrn.224.1529478622337; Wed, 20 Jun 2018 00:10:22 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id f18-v6sm2254716wro.1.2018.06.20.00.10.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Jun 2018 00:10:21 -0700 (PDT) Date: Wed, 20 Jun 2018 09:10:33 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Shahaf Shuler Cc: Raslan Darawsheh , Yongseok Koh , Adrien Mazarguil , "dev@dpdk.org" , Matan Azrad , "stable@dpdk.org" Message-ID: <20180620071033.wxvqvtn4bbdbzcfk@laranjeiro-vm.dev.6wind.com> References: <1529413738-28378-1-git-send-email-rasland@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix Rss level validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2018 07:10:22 -0000 On Wed, Jun 20, 2018 at 05:34:23AM +0000, Shahaf Shuler wrote: > Adding the maintainers, > > Tuesday, June 19, 2018 4:09 PM, Raslan Darawsheh: > >Subject: [PATCH] net/mlx5: fix Rss level validation > > Rss -> RSS > > > > >When setting the level in rss action it's checking for the value stored in the > >parser which is set to 0 by default. > > > >this change the check to be for the requested action insted. > > this -> This > instead -> instead > > > > >Fixes: d4a40518 ("net/mlx5: support tunnel RSS level") > > > >Cc: stable@dpdk.org > >Signed-off-by: Raslan Darawsheh > >--- > > drivers/net/mlx5/mlx5_flow.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > >diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > >index 994be05..40df633 100644 > >--- a/drivers/net/mlx5/mlx5_flow.c > >+++ b/drivers/net/mlx5/mlx5_flow.c > >@@ -738,7 +738,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, > > return -rte_errno; > > } > > #ifndef HAVE_IBV_DEVICE_TUNNEL_SUPPORT > >- if (parser->rss_conf.level > 1) { > >+ if (rss->level > 1) { > > rte_flow_error_set(error, EINVAL, > > > >RTE_FLOW_ERROR_TYPE_ACTION, > > actions, > >@@ -747,7 +747,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, > > return -rte_errno; > > } > > #endif > >- if (parser->rss_conf.level > 2) { > >+ if (rss->level > 2) { > > rte_flow_error_set(error, EINVAL, > > > >RTE_FLOW_ERROR_TYPE_ACTION, > > actions, > >-- > > The above changes (if they are the only one) can be address by me when I apply the patch. > Will wait few days for the maintainers comments. > > Acked-by: Shahaf Shuler We should answer the same as the other patches, there is already a re-work remodeling the whole engine, this patch remains relevant for stables branches, but no more for mainline. Regards, -- Nélio Laranjeiro 6WIND