From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 280031BB92 for ; Thu, 21 Jun 2018 11:55:08 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2018 02:55:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,251,1526367600"; d="scan'208";a="66458312" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga001.jf.intel.com with SMTP; 21 Jun 2018 02:55:04 -0700 Received: by (sSMTP sendmail emulation); Thu, 21 Jun 2018 10:55:03 +0100 Date: Thu, 21 Jun 2018 10:55:02 +0100 From: Bruce Richardson To: Choonho Son Cc: dev@dpdk.org Message-ID: <20180621095502.GA436@bricha3-MOBL.ger.corp.intel.com> References: <1529573741-9606-1-git-send-email-choonho.son@gmail.com> <1529573741-9606-2-git-send-email-choonho.son@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1529573741-9606-2-git-send-email-choonho.son@gmail.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.0 (2018-05-17) Subject: Re: [dpdk-dev] [PATCH] usertools: fix build with gcc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2018 09:55:09 -0000 On Thu, Jun 21, 2018 at 09:35:41AM +0000, Choonho Son wrote: > dpdk-setup.sh fails to build with lack of environment variable > > Build complete [x86_64-native-linuxapp-gcc] > Installation cannot run with T defined and DESTDIR undefined > > Signed-off-by: Choonho Son > --- > usertools/dpdk-setup.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh > index 5eebbce..5248e7a 100755 > --- a/usertools/dpdk-setup.sh > +++ b/usertools/dpdk-setup.sh > @@ -65,6 +65,7 @@ setup_target() > { > option=$1 > export RTE_TARGET=${TARGETS[option]} > + export DESTDIR=${DESTDIR:-install} > > compiler=${RTE_TARGET##*-} > if [ "$compiler" == "icc" ] ; then > @@ -76,7 +77,7 @@ setup_target() > fi > fi > if [ "$QUIT" == "0" ] ; then > - make install T=${RTE_TARGET} > + make install T=${RTE_TARGET} DESTDIR=${DESTDIR} > fi > echo "------------------------------------------------------------------------------" > echo " RTE_TARGET exported as $RTE_TARGET" The message about no DESTDIR is not really an error, the build has completed successfully. I don't think copying the build over to a new directory is something we should always do as part of this script. /Bruce