From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0046.outbound.protection.outlook.com [104.47.34.46]) by dpdk.org (Postfix) with ESMTP id 61C511BAC7 for ; Thu, 21 Jun 2018 18:57:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KmXCrTJM+cSCTjU2kLeRSURTmRqQPiDJHceTmGbbmSY=; b=o6oWjq4irB8LJhR8pwGUD5zrcI+O028+xk+5Rdf4og5Tv9lHNJ45w/Rxdmo4zDPQ6+es1io4GW2XTm7KCFVE5+15n0E7kcIFLg198h9QVHIbGq5Rb4DK64u9hBgp/uzqxPxzTqbxDiNDdc/6xAVWQzzqJdKtb66T4EY3A/xM008= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from ltp-pvn (111.93.218.67) by DM5PR07MB3468.namprd07.prod.outlook.com (2603:10b6:4:67::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.20; Thu, 21 Jun 2018 16:54:25 +0000 Date: Thu, 21 Jun 2018 22:24:04 +0530 From: Pavan Nikhilesh To: Ferruh Yigit , Liang Ma , Xueming Li , jerin.jacob@caviumnetworks.com Cc: dev@dpdk.org Message-ID: <20180621165403.GA32459@ltp-pvn> References: <20180620150122.45945-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180620150122.45945-1-ferruh.yigit@intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR0101CA0028.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::14) To DM5PR07MB3468.namprd07.prod.outlook.com (2603:10b6:4:67::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 26c60358-fe59-4517-0db1-08d5d797a682 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:DM5PR07MB3468; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3468; 3:Cdki2O7rzeLfZ8MzoSVnCvWWNP7VA8MjWWb0t3+vJZDEOMqFWQnnFvO6xvl6Zyt/A0I3MaIVMWO/1ghR/JeVDrkVilpRu5EKSgFbQE+oeUOmWU/hcaulHqXfU0JDfDQjQm17y1yrR3dzx9HiafBpz++V762d9Bmh5ANQYF5JcCiwrr/1jwGznPRgcju6WYaOzpcYGio9hd5PCFeB14+yDJg8Y6KnsVBy3kiMEFIZ6qxdFlk6bthbth2Al2QX3BOq; 25:mUYXoJB3TWgPuLcNqN2822v9nADed4s8aKjcIHF0Y64l+pw0m0iCHkFPBxOlPX4igtO2XtaQO5LAfq6P9caanJmW+xIVDNwCSxzgRM84E1r4IvBE4+bs4IaWldSy3V0pH2jJ1pV9vLQ9oKX7AK2e4q865W/u4dw4NGzzov8jKEMRBV3oNyCkQEmXsWixLl/FPtZQ47fxbVP1gW5LuI/9y6LY2Cspuq/VJShJA/Tga5Dtz5sLRyjh+W5i5/BX8p+N8j6zdWUim5J28CJTPvSL31SMpuGsAp9pryW+df8g3gAMHfKHYyv6FaeCCXjnLTkd3Z0HjJg2w2pMsyFP4+pjfw==; 31:vZFhhecnBRhVfejFuhVYACCxpFzp4JV8Tc37FaPU7shAaE8bvQcZW1ZlFB7+XE0YMC+VO/4fmz+sErnBhW9zxa4DJ71QOFShtpXnaPnfTPGBeGgdPT323LyXf3CjJ84sodXScpw/7N1bt8rp0e7uLHg+8UNcIgcdMGVZr18JmNcCkoaO3zZy4M3VbfscHzsW7MdddJkviOvkcYAlIhkgk6NyynNxnCcpTVOqzWLY91g= X-MS-TrafficTypeDiagnostic: DM5PR07MB3468: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3468; 20:kFmVkTNWHAtP+eCo/m3xRI+Kcm+teAkHapSYxwxRrpfc6lISiCOL1MAaE3byu35CX1X3pUCEfTKggREpjuT9B2iXBHoZrdYvj7s+keFX4rGJpBDdpjZJOn1fMzTArZv0ZF4MdnONEXgJpH0ZfqcDuNOk4RFTliU/mc1f3OcuKHRK376woHjxDJGTUR0aIqc5SODoiRjEOTHoNjaaCwer8Mc9pi9sveX1EPRZLLjl/jpdJOMKD++c3kXQXQufzYnF407MNbpNHllcfR9nhy76oDIF0C/pYWyHwR3Ko3pwxcNrkij+HSUGDA45QLGRjWGvtCzy13ZFP2VIhTRs74tiKNeknrXYeXajQ4pe1pBhUgqb/liEMJH3Acjdn3rIjsNgUTWSSxLrw1XTdJLGMukkdpA9aG0P3bdfLJVIxaTanmdMyVLhT+QpqtzOTnI6aiSEvap7O+5pxmrZBnhbnVefzBwFomsiTgWq7XfmjDI4gcezElk1OX8FDllWWJVYzhXEY7rD2Mu1Uo6twspblik+Z+5kuktig77F0gC/hpPU7h/lpQm7vr31TclKZzMYZGTDB4RILXLYgsEWc55h4ecoZwl7m1taoDi2gYw1/z/R2Vg= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(10201501046)(3002001)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:DM5PR07MB3468; BCL:0; PCL:0; RULEID:; SRVR:DM5PR07MB3468; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3468; 4:A1+S3icVqgBJbCeuvxWOqY+Nq5+O6jRWsIfU4v2NzQE3eZObFdA57rrs8P1gLF/CWapR3IOBTN1ZysZcMQ87qejoCIuWYHWYLPbr9VtHEIbqbc0FtLJVweMDTdnGju+pVliTDxmhiHfj7bNhBTf1pC8OzPJRaQY50y+pRq9J4SiPdyVxhvZM2AUGMhQ/JDn1LEA3VZuoZk5BdMtNmuZR7EeaPUKvE1uUNJJl8ciA8w5uI1heNRQcDJQ1UmylqWgXikmRc3osknCwvgHUMQvbjBi+bKSs6Xq/tzIalGsVGf+pXUGr3NOXuTVYLR2mzz3cjuBLlWVdGwDkHQbZXMQTdYW0l6xkhNXuz311I3Ueewo= X-Forefront-PRVS: 07106EF9B9 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(39380400002)(376002)(366004)(346002)(189003)(199004)(5660300001)(8676002)(81156014)(1076002)(68736007)(6116002)(72206003)(3846002)(478600001)(23726003)(55016002)(8936002)(229853002)(81166006)(5009440100003)(2906002)(33656002)(106356001)(305945005)(105586002)(7736002)(42882007)(50466002)(16526019)(476003)(11346002)(486006)(52116002)(76176011)(186003)(33896004)(97736004)(26005)(386003)(956004)(110136005)(33716001)(16586007)(6496006)(25786009)(58126008)(47776003)(66066001)(316002)(4326008)(446003)(9686003)(6636002)(53936002)(6666003)(6246003)(18370500001)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3468; H:ltp-pvn; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3468; 23:QOdFAskbxZ9j/w95Yitb7GdEg3oTqjE4V3z3OalEz?= =?us-ascii?Q?ekNiTmpr+ZMYjIifRDbbnU85AdP4x27lR+TwUKqKziF58Jd3Buj66VDRLdUj?= =?us-ascii?Q?n6/CX9NjzzAxu44LSLPh7DDU/0FQr4awg8CZKAQhSebA3pcyIlMq9PAA7JBI?= =?us-ascii?Q?eIASsWV2ldSXGncKkWsIYvrA8UV3CWCa3h4YMeB460ao4kLhPGdzBhyFnlwb?= =?us-ascii?Q?9AjTCgzeBpeazrajrnfFAH12k4gNJpD4/bUtvAuyYoATcQGRJ6tLLIRcTaP/?= =?us-ascii?Q?kZMlrFoOfJjimrYemqVldH4W1Bil3iI1nLWwS0Jer77lmYQOYF789En7fBDh?= =?us-ascii?Q?ZhNoERt8dnbUugwq28Rb+8MQjtAZWnM87SEINegLpl/PMVPfyNw7COiahHLC?= =?us-ascii?Q?tbRMsPcXPta6+jiwMF1qTM3cUh3UgE4VnbLK9B0xqaXAdd+adySxk1KLfSo6?= =?us-ascii?Q?2sxUXObmUXF5jjhfhXxX0zxld30VJCQnYfgFimmqkogsPT7qhJk0HE7kwEAf?= =?us-ascii?Q?+xSX3K4u1YZhU4qzSpXf7KEQYk22/Bw1SJ8IIufIpKBln5tu14+SQChkyAho?= =?us-ascii?Q?tdYH9reLTMEnqODqakKaiy/fYNi7ZYcx6+qSTCAEy3aA8/4idaSkgv5qDs0G?= =?us-ascii?Q?y7mqG/ux0WDriRu/7wasQYaZ/Pk9sJCgV19/PgphDnlSGfGyPq01fmEAZlrI?= =?us-ascii?Q?mYdYOS3VDA9DL2xP7G9lnfYJxEZdfNLMpTN4r+vjagNUGGmdEIM0AnOnrJK7?= =?us-ascii?Q?tu1he9mcUZaCiTGeaJyknqtPpaox6d/D06iJ4A8kZms2GtcvXQycjiUbzkWm?= =?us-ascii?Q?yewRe+Grd2/ez896j4zxt4sxPuzdvR+QNpQ8MjWZ69JKuNXJ0rkluIycfOpq?= =?us-ascii?Q?3Gj3fFKsZTKFYo/+z0m1uKkXI5NkG4lHIFl3PB8IlQasiTntmiUjs2X6papZ?= =?us-ascii?Q?/ITcfHDpfxCMFFdYKYN5XKdXILMd5iNmkFRCSFAgFVV5TdRipndfLkBr4M4L?= =?us-ascii?Q?T/BKPQYXdbYLe1/4tJNJrUMp/FSwVkLD7wyDZ89iGLP2YpICmhtMIpCLAh0z?= =?us-ascii?Q?otER/sYAt3W08rvNBZk2hRDtrh4JaJNB+C3vk9Q+dad3rZSMm70dQPfVSfWd?= =?us-ascii?Q?KupQUyoLSJQzePbYf0wYoQNSJIgT1eeAoUccr6OXxSh7qsuBzsbvEJ8Dh0tv?= =?us-ascii?Q?hmM+Aos5Puu4toziDrwM8Y5i+bCNi1wEKf7IJe/LYzjq3m+YiYmwwUyz1/AN?= =?us-ascii?Q?GL21GV8ahgREh4vzNikL4GF8qW3rvRwQ5WmurJ5EGOf3VbUiBekFtXALqb3e?= =?us-ascii?Q?AmscAA1liKjyjvWzsdKqTyu3i6sTV7A2hmr0avbvwmvIr2xXZX6AZbyN1VHu?= =?us-ascii?Q?IHiLAAp8LpPZu7pVHM5YfqanTHacxcnd4vth7PNAlNk55DX?= X-Microsoft-Antispam-Message-Info: buwv/roUKImbRxi8J2hzp+X60Qg6zi6RUs53QMq3wtA8h8viS7FZ0+tWLQVJxNJugmNpsA49eJFhOg4Qh4u7mRLqjADIikHNbYa1aKRwP1/oktVYX/VJ7QHai3VVXUCeGnjbuC/fqw6DuPXqwnFk7amx489S50T1LkI2oC8Z39FcxcRABDlXOCLbfw0GQbl1ZXvzMUnujT6rUpaTuSsl68nnZNlQICEd/jRx7YwFUvNfKsnSBnSN6LHdq16/PZo35ja3T5sQ3RPUifJ5NUtsM25kpdZztCcopHJ/iT5rewx2v3xPk3ACmwkQO2fzrPh2u1y+416KLWBForraZaQCbQ== X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3468; 6:U3Q04cMAPGTucaiaTOuxcp5zkm6howrdrL/L4YyJ9dr2ZPy4tlszt/G0oJKfsPmFJr/Kf/EtW0dpkjqTJxOi7VVff9UR2LxeUI4k9Ean0GTfNsFjwAoP08Y/d++gU9c4cNPl6s5E6wam76R7ZxMeH7M+xK2vVguzqkAqAzfiGfJrIFs9aNP28ACWhFjEK9vxLv0niDuOX6K7i2WRA4oLAjHm0r55/SXgfUEjhdRl/COqRaRnnHbuqch/HAj1/yrFccueX6hD3WJ9KQHRrRxCAhklGkC3NY+xy+zuBQczJQb0eOQEfJM41d2tiWFJdtQkNH6A62WIVqMJEQ/SzpWD2PwVIGBgA+DLk7/+sNUvMRluv6rRTnN5y+PdFZ+id9GTXE4ryNuHRXuIONlRmGEbq6YKGrYVcwOjxm7THQsyZfwa2eDD+kZMMVj8ZUum7Q6GLMIILCYGh7iKKb+Cgwu1xA==; 5:y/KN6Pm88JwzFK4eENKdKP4W9/jwIQAcrq1XwoOUEZnWA2rvFdYB/KcRqSQ0K/ZwSy39FE2016gHL6/wPlRFgnTaTPb6aUnEd8vNm4jqx2bUEXTRP8fMmtkUgtUIjq5e5wZEkKhmZvgVd6A7fTpoR36+dJ7zQFFnhxjREF+AcKs=; 24:1jlkrQkA7vd4byFDQz23zk/WDRisTMUJWcq7+jRvJgVbFauPCMy3vjpLicHhA/xVVWnOfca+5mtiXGD0QLMIa6hQFtGli2KbKTjs2cMZ+9Q= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3468; 7:K8I4Uif8/oj1CYd/cMY4m4phc0N3rcrQv8fHnub/qKXItvcbCEytLgy5zdyobVMU9f/5gUKyakVW3k6bbUrr2NfuDbO3tCG/4sS7A90khVlPNVzDQOVodfklahNLvU0B8JZNd2XWYSgLFPNLKjc2SU1q9jGGvuOfTrFid9D0tsz9CWOI4oAftuMXkEXRzWMa7ckdol650IhwGE1OpecUVHHvcl9BGVa53auhr8sWzrXzvpUM0Bck9ozCk1rc5w/b X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2018 16:54:25.8804 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 26c60358-fe59-4517-0db1-08d5d797a682 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3468 Subject: Re: [dpdk-dev] [PATCH] examples: fix RSS hash function configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2018 16:57:05 -0000 Hi Ferruh, On Wed, Jun 20, 2018 at 04:01:22PM +0100, Ferruh Yigit wrote: > ethdev layer introduced checks for application requested RSS hash > functions and returns error for ones unsupported by hardware > > This check breaks some sample applications which blindly configures > RSS hash functions without checking underlying hardware support. > > Updated examples to mask out unsupported RSS has functions during device > configuration. > Prints a log if configuration values updated by this check. > > Fixes: aa1a6d87f15d ("ethdev: force RSS offload rules again") > > Signed-off-by: Ferruh Yigit > --- > Return error added in this release, so no need to backport the fix to > previous versions. > > Cc: David Hunt > Cc: Liang Ma > Cc: Xueming Li > --- > examples/bond/main.c | 12 ++++++++++ > examples/distributor/main.c | 11 ++++++++++ > examples/eventdev_pipeline/main.c | 11 ++++++++++ > examples/ip_pipeline/link.c | 8 +++++-- > examples/ip_reassembly/main.c | 12 ++++++++++ > examples/ipsec-secgw/ipsec-secgw.c | 12 ++++++++++ > examples/l3fwd-acl/main.c | 12 ++++++++++ > examples/l3fwd-power/main.c | 14 ++++++++++-- > examples/l3fwd-vf/main.c | 12 ++++++++++ > examples/l3fwd/main.c | 12 ++++++++++ > examples/load_balancer/init.c | 12 ++++++++++ > examples/multi_process/symmetric_mp/main.c | 12 ++++++++++ > .../performance-thread/l3fwd-thread/main.c | 12 ++++++++++ > examples/qos_meter/main.c | 22 +++++++++++++++++++ > examples/vmdq_dcb/main.c | 13 +++++++++++ > 15 files changed, 183 insertions(+), 4 deletions(-) > As we are fixing it for examples can we include fix for app/test-eventdev too? diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c index d00f91802..79d755b6f 100644 --- a/app/test-eventdev/test_perf_common.c +++ b/app/test-eventdev/test_perf_common.c @@ -706,6 +706,12 @@ perf_ethdev_setup(struct evt_test *test, struct evt_options *opt) } RTE_ETH_FOREACH_DEV(i) { + struct rte_eth_dev_info dev_info; + + memset(&dev_info, 0, sizeof(struct rte_eth_dev_info)); + rte_eth_dev_info_get(i, &dev_info); + port_conf.rx_adv_conf.rss_conf.rss_hf &= + dev_info.flow_type_rss_offloads; if (rte_eth_dev_configure(i, 1, 1, &port_conf) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c index 719518ff3..386ba14d1 100644 --- a/app/test-eventdev/test_pipeline_common.c +++ b/app/test-eventdev/test_pipeline_common.c @@ -249,6 +249,9 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt) rx_conf = dev_info.default_rxconf; rx_conf.offloads = port_conf.rxmode.offloads; + port_conf.rx_adv_conf.rss_conf.rss_hf &= + dev_info.flow_type_rss_offloads; + if (rte_eth_dev_configure(i, nb_queues, nb_queues, &port_conf) < 0) { Thanks, Pavan