From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 111A34C8E for ; Mon, 25 Jun 2018 08:40:36 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id p126-v6so7860441wmb.2 for ; Sun, 24 Jun 2018 23:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=MOLLNqJNaFzHQfz/0RcY5gVH+f1qhRMsJEv1HvQ5nmg=; b=U6FsM1AOgXs4lhC5OntCAx1lfQK/r7nARLcNIZDv6WWBUc90YeB9IKImxjTVzT3hAW CHbHQcNMeiJj578sMCT9J4RsYgak2glWPFIdXXQhlrEr0VJpH1R8dd3e6qSnsjwI7NdH 9IcwcV9o3N7y7dwKrJhuxT9SunJFw+A1Yuao+hPdq22koLrkJlbZLr5xK6VdAF9m+ifX 6fc+SFVIB99Px7CTN03X0d2YJKpjIDcthaAhPAvyHcDBW8EgsD+J15uJuzdKxj1CJYdf JyVKQkTAjnfk28/Ayd0U/CSBeS/e8HZXieW6Cc9yMXnAu5Ku8P7ugrdRRYbLmyA0zzTu B6JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=MOLLNqJNaFzHQfz/0RcY5gVH+f1qhRMsJEv1HvQ5nmg=; b=lVOdRaMx8tTe73qkMPSE3NFj6iJQ6dQuI3pg6+8iwZy/x5j6+Q1nf4sXwfbvZ2gU7s Gw+jjDcNsuEr2B/z92HHisiRDoUeh8cyf3DM/e/2GJera09wpcisHuiyMYVTIcPWQTwz uYLoiaTOhJEav12Dmco0bvuUR9dfAmiIlfyhJfDPdSBo9pMbp4v6TkkRYn24JCUAtoB5 XkNjtDfUoUfWtt/P0teHm9JYorUqCgrdHbsqWqKDC6HDAyARqJjudxRbQAjs7N+tTJYj 275/n74FCF+IhkXSA8swenwK7GXpQ0b3BgfMXC6fJUgkJnPIgGORpihWLhFPfUUyD6Lr tbQg== X-Gm-Message-State: APt69E34lkSvdYSLoS4Qwxkc0jDNKe8xT0hM8U+coUbjNj2MkKrdvuLb PfXf3kcXr2cpGvfVYKhdzHYl X-Google-Smtp-Source: AAOMgpfoUNmjl2jovAchdIUeEJxEZUP/VNzELXSF+WowjUorDq/zbbbYGG1hIxSB++N+6dc3cJjLBg== X-Received: by 2002:a1c:40d4:: with SMTP id n203-v6mr7953589wma.101.1529908835730; Sun, 24 Jun 2018 23:40:35 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id d7-v6sm15930318wrm.9.2018.06.24.23.40.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Jun 2018 23:40:34 -0700 (PDT) Date: Mon, 25 Jun 2018 08:40:57 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Shahaf Shuler Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20180625064057.xnebd6se6obogwn4@laranjeiro-vm.dev.6wind.com> References: <20180624062226.11507-1-shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180624062226.11507-1-shahafs@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: separate generic tunnel TSO from the standard one X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2018 06:40:36 -0000 On Sun, Jun 24, 2018 at 09:22:26AM +0300, Shahaf Shuler wrote: > The generic tunnel TSO was depended in the regular one capabilities to > be enabled. > > Cc: stable@dpdk.org > > Signed-off-by: Shahaf Shuler > Acked-by: Yongseok Koh > --- > drivers/net/mlx5/mlx5_txq.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c > index 068f36d99d..669b91319f 100644 > --- a/drivers/net/mlx5/mlx5_txq.c > +++ b/drivers/net/mlx5/mlx5_txq.c > @@ -113,15 +113,20 @@ mlx5_get_tx_port_offloads(struct rte_eth_dev *dev) > DEV_TX_OFFLOAD_TCP_CKSUM); > if (config->tso) > offloads |= DEV_TX_OFFLOAD_TCP_TSO; > + if (config->swp) { > + if (config->hw_csum) > + offloads |= DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM; > + if (config->tso) > + offloads |= (DEV_TX_OFFLOAD_IP_TNL_TSO | > + DEV_TX_OFFLOAD_UDP_TNL_TSO); > + } > + > if (config->tunnel_en) { > if (config->hw_csum) > offloads |= DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM; > if (config->tso) > offloads |= (DEV_TX_OFFLOAD_VXLAN_TNL_TSO | > DEV_TX_OFFLOAD_GRE_TNL_TSO); > - if (config->swp) > - offloads |= (DEV_TX_OFFLOAD_IP_TNL_TSO | > - DEV_TX_OFFLOAD_UDP_TNL_TSO); > } > return offloads; > } > @@ -707,7 +712,7 @@ txq_set_params(struct mlx5_txq_ctrl *txq_ctrl) > max_tso_inline); > txq_ctrl->txq.tso_en = 1; > } > - txq_ctrl->txq.tunnel_en = config->tunnel_en; > + txq_ctrl->txq.tunnel_en = config->tunnel_en | config->swp; > txq_ctrl->txq.swp_en = ((DEV_TX_OFFLOAD_IP_TNL_TSO | > DEV_TX_OFFLOAD_UDP_TNL_TSO | > DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) & > -- > 2.12.0 > Is not it a fix? Regards, -- Nélio Laranjeiro 6WIND