DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
	Yongseok Koh <yskoh@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: separate generic tunnel TSO from the standard one
Date: Mon, 25 Jun 2018 13:33:17 +0200	[thread overview]
Message-ID: <20180625113317.rd5y5d4izhuvx4ri@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <DB7PR05MB4426C93D11A0452FF21EDA75C34A0@DB7PR05MB4426.eurprd05.prod.outlook.com>

On Mon, Jun 25, 2018 at 11:23:22AM +0000, Shahaf Shuler wrote:
> Monday, June 25, 2018 9:41 AM , Nélio Laranjeiro:
> > Subject: Re: [PATCH] net/mlx5: separate generic tunnel TSO from the
> > standard one
> > 
> > On Sun, Jun 24, 2018 at 09:22:26AM +0300, Shahaf Shuler wrote:
> > > The generic tunnel TSO was depended in the regular one capabilities to
> > > be enabled.
> > >
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> > > Acked-by: Yongseok Koh <yskoh@mellanox.com>
> > > ---
> > >  drivers/net/mlx5/mlx5_txq.c | 13 +++++++++----
> > >  1 file changed, 9 insertions(+), 4 deletions(-)
> > >
> 
> [...]
> 
> > > -	txq_ctrl->txq.tunnel_en = config->tunnel_en;
> > > +	txq_ctrl->txq.tunnel_en = config->tunnel_en | config->swp;
> > >  	txq_ctrl->txq.swp_en = ((DEV_TX_OFFLOAD_IP_TNL_TSO |
> > >  				 DEV_TX_OFFLOAD_UDP_TNL_TSO |
> > >  				 DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) &
> > > --
> > > 2.12.0
> > >
> > 
> > Is not it a fix?
> 
> Well, more like optimization. To be less strict on when to enable the
> generic tunnel TSO.
> I can rephrase the title if you insist. 

I was asking due to the CC'ed stable, which is generally used when the
it is a fix.  I don't know how the stable maintainers trigger such
patch, that why I am asking.

I am not insisting in any thing here.

By the way: 
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

-- 
Nélio Laranjeiro
6WIND

  reply	other threads:[~2018-06-25 11:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-24  6:22 Shahaf Shuler
2018-06-25  6:40 ` Nélio Laranjeiro
2018-06-25 11:23   ` Shahaf Shuler
2018-06-25 11:33     ` Nélio Laranjeiro [this message]
2018-06-26 10:25       ` Shahaf Shuler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180625113317.rd5y5d4izhuvx4ri@laranjeiro-vm.dev.6wind.com \
    --to=nelio.laranjeiro@6wind.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=shahafs@mellanox.com \
    --cc=stable@dpdk.org \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).