From: Olivier Matz <olivier.matz@6wind.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>,
dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] eal/thread: fix return codes for rte_ctrl_thread_create()
Date: Mon, 25 Jun 2018 16:40:47 +0200 [thread overview]
Message-ID: <20180625144047.ktlcpstkfcmyhxcl@platinum> (raw)
In-Reply-To: <387954ec-779e-6f29-5966-f8d2a41945e1@intel.com>
On Mon, Jun 18, 2018 at 11:01:40AM +0100, Burakov, Anatoly wrote:
> On 08-Jun-18 1:37 PM, Dariusz Stojaczyk wrote:
> > This function returned positive error numbers instead
> > of negative ones as desbribed in the doc. What's worse,
> > multiple of its callers only check for (rc < 0) to detect
> > failure.
> >
> > It was incorrectly assumed that pthread_create
> > and pthread_setaffinity_np return negative errnos. They
> > always returns positive ones, so this patch negates their
> > return values before returning.
> >
> > Fixes: 9e5afc72c909 ("eal: add function to create control threads")
> > Cc: olivier.matz@6wind.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
> > ---
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
Thanks for the fix.
next prev parent reply other threads:[~2018-06-25 14:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 12:37 [dpdk-dev] [PATCH 1/2] eal/thread: fix return codes for rte_thread_setname() Dariusz Stojaczyk
2018-06-08 9:02 ` Stojaczyk, DariuszX
2018-06-08 12:37 ` [dpdk-dev] [PATCH 2/2] eal/thread: fix return codes for rte_ctrl_thread_create() Dariusz Stojaczyk
2018-06-18 10:01 ` Burakov, Anatoly
2018-06-25 14:40 ` Olivier Matz [this message]
2018-06-18 10:00 ` [dpdk-dev] [PATCH 1/2] eal/thread: fix return codes for rte_thread_setname() Burakov, Anatoly
2018-06-25 14:35 ` Olivier Matz
2018-06-25 16:58 ` Stojaczyk, DariuszX
2018-07-10 10:44 ` [dpdk-dev] [PATCH v2 1/3] eal/thread: ignore rte_thread_setname() failure in ctrl thread Dariusz Stojaczyk
2018-07-10 10:44 ` [dpdk-dev] [PATCH v2 2/3] eal/thread: fix return codes for rte_thread_setname() Dariusz Stojaczyk
2018-07-10 10:44 ` [dpdk-dev] [PATCH v2 3/3] eal/thread: fix return codes for rte_ctrl_thread_create() Dariusz Stojaczyk
2018-07-12 22:19 ` [dpdk-dev] [dpdk-stable] [PATCH v2 1/3] eal/thread: ignore rte_thread_setname() failure in ctrl thread Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180625144047.ktlcpstkfcmyhxcl@platinum \
--to=olivier.matz@6wind.com \
--cc=anatoly.burakov@intel.com \
--cc=dariuszx.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).