From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700069.outbound.protection.outlook.com [40.107.70.69]) by dpdk.org (Postfix) with ESMTP id 5E6DD1B550; Tue, 26 Jun 2018 11:57:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qdn8vljRE0BiHLolZB6Gnu/8ur2ndnR2hcc+Ocr4r8o=; b=WNrHirX0WDXJcVD4wHO6gAtZAsZjDAmXiBs6aGDYTwnGeoTI3NLrXFE+HEF7u2l7XkTIMXxp2Hl+/fYy3X1RMhtZexgjr+fIsOa6+G0coF7/QL2SwvRTM2qpYn8RyeXDw90f/0QvvnQQ0k1zg/Z0xzJqrBeSy1sTerfjX9JAD3Q= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (111.93.218.67) by SN2PR07MB2526.namprd07.prod.outlook.com (2603:10b6:804:6::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.22; Tue, 26 Jun 2018 09:52:17 +0000 Date: Tue, 26 Jun 2018 15:22:11 +0530 From: Jerin Jacob To: Ferruh Yigit Cc: Maciej Czekaj , dev@dpdk.org, stable@dpdk.org Message-ID: <20180626095208.GA7633@jerin> References: <20180621181450.91425-1-ferruh.yigit@intel.com> <20180624121723.GA7776@jerin> <609412c8-26c2-5263-5f6d-7e888228b885@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <609412c8-26c2-5263-5f6d-7e888228b885@intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BYAPR03CA0012.namprd03.prod.outlook.com (2603:10b6:a02:a8::25) To SN2PR07MB2526.namprd07.prod.outlook.com (2603:10b6:804:6::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bf514b2c-e995-4fe0-01d8-08d5db4a81a4 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:SN2PR07MB2526; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2526; 3:Ckh6CbL0lJ+qf0Y6HJvS+CWXGcINeKypdzh/u0MysWl8Qta7yDKTEZsSPSeV2nEH4VdMFFRTMMaCkENYwPjyKWSk5rV9AKI9yrW6QsFnS9YkI4BuloyNXsXXBc5ynzl5E+zshSM/W6BK5m8TW8tUgRiCaCnYmV238HMWjcJcsFGkC7O6B+XHeO31u4TkuEnAPEvvrPvYKcjNupO8V3hY+qXiuOaXNmxj/aYSMwUFwm2QEERshI/PGlINF231CaJ2; 25:+ub/qLvBPBND0wbF1jJLTADYnsC1RTwYu1cIsIQ4pJnGukgJnjmKUippDgRn2arm0oc+QyB+aLvSYZIAi1koi3vQjAKnMjINZ5MiaFqxArRIdV5d9wra5X+OQYx/Eg/A8b4VOfRE6mwMZHm2LPkBQpGxhWinfSSwmJq0pnKn5BzZG7u0MXt1TVjSYKTwtbSBr//JPKphGpdEoD9qLMtxQVqQ71M+01fXJtkmFmrULWxDvlL2T2eogzRqXblkoVwITRZIj6InfMP+eWUN8SM058mwyqiUJ/sNOpGaVgfvmTWaDQS8nJN7mVVtsdbfVZKHTDN0NNQ/U5VbghZH6DcXiw==; 31:lZKNjGaBpNWIHjc6CrVZo6/3kiykXNYsoAXCX5vlhpAcOWJmB0JMIkF6ToAyUtaSJwH+xkQf5xjKOZkO6Fvyl1tKO3r1Hx8/wr7XnTan1qGvq5BqAesYEefqW7UwLsKPvGSmssxHU3udVq9H6FDr2b5c8rupG0uGgbuP0V9rWtbxKNLsyLcdb2VckRiwVeq1YIleYLtqPDQZfqWp22BmgiPDmmwv0JWj6LhPuiMxzWk= X-MS-TrafficTypeDiagnostic: SN2PR07MB2526: X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2526; 20:MJzvcHrz9Av1jWyedtrZtbSn9oLw9D2F/JKgHw3HWOPkBAvdnJJhniANGEfRWh1cW37J2Qy+57pV0fQ8syXWvZcvFOqRYUrAnt+m1wD1UXc+R5x0ct71N3Xe1Isn7M7eln2hVapCOrOLKxp/Me7efMZESYArVOFpXrNz3h54qScHDwtUUw6FSaz773wgW2Mjq6U/01FnObDMi+2QitXuEOqxKOxaUzO6Uuor3YgELvEgUA4O9xyNUJhA/mrUPePTz0WAGvw6nT3YAS0/+sA6evMYR9uqem79N2AQjw2mqD7XIXZvh6bauBA1WlG4ezjXrLKmedwhdl5fvP/aEBLk3+KTQYyoE+Ldw8/lNSnQFEyZ/Zb80boSs+mJeFdOxtiCfTBARGoVouZNyZ93ExICf0yXWJR3Mlf1XDkszsBD/Zzf2W6VInZxCygZpnVbTDZsO8M8rxrqjBnfThZt//LxPzI+uyjd84GXqgP/vpcQ77rLcTtHAq5lkCrPRPxxI+ZktXHHUDcmuvX98Ahm9+1fpMQoZNZ6ZwSHJyFEa2hOzQbcQf5XdyS1/oIXDGEHpDDIGkHQBWsIEnczTaFO6qFFkuYojctEkdmOmC3EU+ImWnc=; 4:qC+IN7SAWO+1VdxMvvVo/3c6oo+ry07axbOzXEkRZpa3Qs+pC0R3T4Ewt4cFdf+JJDWmPHr4zGH3gqUlOVUimNZFZldX03tdHNcfXnkbboEUE6eLnhC473hZHhYcQ5d/YX29SI37RNJ6GrVEo7tTZaqtgU4b4XG1Isfm39pqIvG2uInovvPfxat9hYSx+IPFuplUnjr0MUs9+rYwWz/3OdkoGnH0IBjTz7GUDV8/o7/ObMOKP7nD1Ihp+fMZ+BcjmKXgyz3IyFShMi+z7+iDqFdLXtaM1ZRl7w1RG6LmNhhTvLrfLRdXiamRxQoYK3sM X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231254)(944501410)(52105095)(93006095)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:SN2PR07MB2526; BCL:0; PCL:0; RULEID:; SRVR:SN2PR07MB2526; X-Forefront-PRVS: 071518EF63 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(346002)(366004)(376002)(136003)(199004)(189003)(13464003)(23676004)(7736002)(476003)(2906002)(16526019)(106356001)(26005)(186003)(8676002)(6246003)(81156014)(2870700001)(5009440100003)(66066001)(6666003)(53936002)(76176011)(105586002)(305945005)(386003)(2486003)(6916009)(5660300001)(33896004)(52146003)(6496006)(53546011)(52116002)(42882007)(4326008)(55016002)(72206003)(9686003)(33656002)(229853002)(68736007)(956004)(58126008)(446003)(50466002)(47776003)(3846002)(6116002)(486006)(81166006)(11346002)(1076002)(97736004)(316002)(44832011)(33716001)(478600001)(25786009)(14444005)(8936002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2526; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjJQUjA3TUIyNTI2OzIzOlRqdFd6SXNxNW40Qm5YaUV6aXppVHUxcXVC?= =?utf-8?B?bzluSTI3anRTUmtjcmh5T2M0VWxSQXJNM1lQbzlJcTFsODhUazA2WloyQXR2?= =?utf-8?B?N09rK29OazZGTjFaY0pkSkRueWtGZGdhSm16SE9LcmpyQTZURUo5YjVMNDdI?= =?utf-8?B?ek0xRG80aE5VZkp4V29KWnpwcVlTSElveHlkNTIvZytsaVNJRlBoSjhPRUdV?= =?utf-8?B?SSs3NGZILzR1US82VVM5dGNyL2szTG9YNDE5N2FybmJ3ZElWbUx3Y041dXhG?= =?utf-8?B?elZTM0Z5TUhscGpYbXo1NVNjNjhOOFUyVzFUak1PYXl1K043cURoVWhqSzZ5?= =?utf-8?B?TEtsaWZ5MVJEV0FTZUdaVkdqQ3h0VThUZSt1U1g1VkF0cUtnaVdpMWEzSEpW?= =?utf-8?B?M2JkRHFMYUJyVVQrY0ZoVUtzRSs2T0JWeGlGeWlrUXhUeHQwd3YzQnRYV3o3?= =?utf-8?B?UXFMcVRuZUZ5bEYyeGFSWXo0MWFmUjVEcURjbGtobnY1YVJvNk9Ma3VUQjJz?= =?utf-8?B?RU9CclM0azVvOFZhSVNVVkxDOFpaRGRwUGJqdGQwYmQwK2F0d205RWVBUEN6?= =?utf-8?B?T1Jwc0FtV2xoSlc0eElTK09rb29VZkVWbzNjWGxZQnkvSG5lN3NLckdybUtk?= =?utf-8?B?RkhUZHU1SDlmcWdSV3Q0emhOK1V3SVNLNm5HMmxZYnhxd0RyWkZkV1NwQTMy?= =?utf-8?B?ZE9GdzZBVDNoWll4SldobGRraWpWM2JlVzJYL25HeXFTLy9NdER0Zlh3T3dK?= =?utf-8?B?Z0hXNUNOc2E1Z2NoZEQrREZySTVJNE15SE1Dc0phWXpWdkNUM3UyN3F3N2x1?= =?utf-8?B?NTZDU0FzeitUWEpSRk5HV0ZmLzdEZFova010OEJMNmNMOWtRY2R2bWVad1ow?= =?utf-8?B?ZmkzblJoWVNOcTVYZHROTVA3ZXh4bEl4ZC94TUJ2RVI2S3F2MlNURnpiNHdz?= =?utf-8?B?NnlTcUR5RjlEZ1JwYmJKdXhPVk9Dd3UxTDlTS2RINm5rNEtjSC85NkxyVlM5?= =?utf-8?B?L0ROWnJSb0RDRmgzRjQrdXFLdU5OYUY4V1VIUUFFSmNPY1k5R3FBdFM4VHN6?= =?utf-8?B?UUs0c2R1YmdYb0hBUDR4K25aUDJjNUhlUHdlL2oweHBQRWhLOEJMVlVRZHF3?= =?utf-8?B?eFByLzRGNm9ranhhblUyZVpScFlEQjcwdlRrVHNKT0x2WHdhOUFaZUR5RDNm?= =?utf-8?B?L0tqRUdFRU5pOEZxR2o1cTczSDN1ZGtlTzhub1pqcmZPNHFVcWc0L2ZEVFYv?= =?utf-8?B?eDdtT1NFRjQ5R0N0YXg0QnFGQ3RETDhja3BkUE5uY2N6RXBDY3FETlRuQlFr?= =?utf-8?B?THRFaTh4YjAvOTVPZ0U4cnJMT3hiUVpFbGx2MkVHczgvdWdIaTA4STFvenBw?= =?utf-8?B?cVdwZXhETFhlMGEyM2taTytzd1FINVAwbjhTaEFjdnI2TTNUcDNZTTRSQjRn?= =?utf-8?B?aitlRUNSTFRuN2hLbytkYUFvWHcvdmRzL040MWNWVjhqQWxPVnQrZndLczdv?= =?utf-8?B?MWxWYlFHNzJkUTB1S2c0TnFsbXZVQzJEeTN4SkwwYk9KaWcwYkxFK1R5VXlI?= =?utf-8?B?VVFPVEJsMWM0SmxEa0tzOUszUzhZcXlBbk1paHgzN1JWME9STUVKSmlXemZn?= =?utf-8?B?cEkwVWZwRDU0dWp1V0dxVTY5Q0x5YWtmWC9nWGlZZ0ZoWEE1a2Vmd3owRUtZ?= =?utf-8?B?eE5hdDQxNm5RL3Q0VzFIbjJHS29rYnRxaEd3U1VuS3FsZGFzQjc3bXN1RVo5?= =?utf-8?B?RC94cU5LUEhMK2x0YXYzU2NLRDhlWDR1bEpYQVhqR1BmV0lsRzl5NmxSUGhH?= =?utf-8?B?aThZd2lNTm1oRlpUV3Z0UUlTTE1uUHVZeEppT1VlRkpmdS9XekZyWTNya2tx?= =?utf-8?B?bzNVVDh5TC9zUUM1MmJFQnc0UXBVQnJaM2VGRTQ3ZlhKSXptTnhvQ3ZvdlNl?= =?utf-8?Q?Eciq59VxvM1PbMJaXDP7Aq+/Us98Mc=3D?= X-Microsoft-Antispam-Message-Info: CSXqaUDpC32vvrVbnbvT1gasCMiW23cmakBKG3oEcMhDgLc7UDz7douFZOpqFqEDM+WoOeZOPzMDQeDUFwWbkU0lKEBD7goPMoc7NtxY7oSbrpB47CFmgOAA48VW61fLG5LC/s9Y6QgPFc/aan801vwboVVI0YnPOETJpiCHvm5B4Sw2Ou2rQwtUahjCZk2hrbcFyQnJYITpk/OXj9MIJj4qpIa4g3iwn5CjVCNro+UN2CKRXqYI1MXGz8Pn0RgElSNng/e6CqWvOaBgsCSXdWDLi6GVp8CyXf8Ut8f5+Sp7WRk+MCpnfWUrhuzr7BkHkrr9VKBTZgocIMaVZI5aFSsGUZaZpcJx1wVY0iHdy1w= X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2526; 6:gPwAx5CKhoof3E1V/njdKqvT/q/HMYKrKF+fGUO3CxWBFZHfAIRtQ5EByeF8b3DipsgS5Y5NSy3V62pL+ujodGj35mtveRcM+jDE1ygBN/e8Y3z4xU7MCAT48ySx8e/NK/SYsJ25obaJh3sqKRf8bTrHyIBWoy8eJbhSA8+wxdSj+G1PeQ72yXDMWvVs7ia1u8YqIsiopYtEroyqwTELrDVBDu04CKvsm4CG1XriYeU9JfehppOHjuAMQMAUHtDIe/3Hqx4ICvt/phgDvEbE8ht7l1CoMtz/wDD+l/LviX6eCJQ3+0NQYfvWwQe8OwKx4xodWTgYa8Hy14fO78KZ7fgqivnXMq0cVKO8o6WFi+Wj2x3dtFtzeGGFTN0XCMXXB4pPqJic05uRJwVR99v9SpLDxZBAJG4VuaX0LFmVFjgWz8L8BzbC1M80uTHoJlZ3YnG8Eaws9GcUEXz9sxJQXw==; 5:7Gwcz1OBf5Nj+UIcpiDpjlrAkzpv/vP6UCO7jMJOwggmju3H1mAky6y0f4/4YFzofYsz5Ie2BLP7bGoEc3pEFobvH5rkA8sJ2CUYTDmDqhIeoJH3U/tGNLClrazZ1lhQCzjFtcH5YSlHE4C09u8kyf27MGHx6u0rCEekAASJ/Y8=; 24:+X3Z6LBH3r4Yah8rqb0hHpgotQZaokL6h0weRdVopmM2DRRhxkha3E7L00lKLfQFEzQ7Im/2xuvS/6WSDKQQ0SEZ3vLoTT5/h/rZSVlpOwQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2526; 7:gU5YdJ/uEMntvTszBXTwFmfOG3AB38SC/lHVZvDxosetWyIAO90+EL+t0VC6gIhqav+UyRpGvxOBUGWHMP2zjnzxAxYDaA5EPTXMCjaBjE7hiGzXYMfqTq/iMifOCc5crqx+be89+CCjvVUwVeYCeFV/jWqALu/KnM1b9WgUfoQvfeXZZ3c0oCuITNXey1YHjYO9JXRIQT6OWYQlboN/JOJEq2iqXaHYZ5rIf7hRo8ORN/FH8mz3kqLi/2KNjFrA X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2018 09:52:17.4610 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bf514b2c-e995-4fe0-01d8-08d5db4a81a4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2526 Subject: Re: [dpdk-dev] [PATCH] net/thunderx: fix build with gcc optimization on X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jun 2018 09:57:35 -0000 -----Original Message----- > Date: Tue, 26 Jun 2018 10:17:14 +0100 > From: Ferruh Yigit > To: Jerin Jacob > CC: Maciej Czekaj , dev@dpdk.org, > stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/thunderx: fix build with gcc > optimization on > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.8.0 > > > On 6/24/2018 1:17 PM, Jerin Jacob wrote: > > -----Original Message----- > >> Date: Thu, 21 Jun 2018 19:14:50 +0100 > >> From: Ferruh Yigit > >> To: Jerin Jacob , Maciej Czekaj > >> > >> CC: dev@dpdk.org, Ferruh Yigit , stable@dpdk.org > >> Subject: [PATCH] net/thunderx: fix build with gcc optimization on > >> X-Mailer: git-send-email 2.17.1 > >> > >> > >> build error gcc version 6.3.1 20161221 (Red Hat 6.3.1-1), > >> with EXTRA_CFLAGS="-O3": > >> > >> .../drivers/net/thunderx/nicvf_ethdev.c:907:9: > >> error: ‘txq’ may be used uninitialized in this function > >> [-Werror=maybe-uninitialized] > >> if (txq->pool_free == nicvf_single_pool_free_xmited_buffers) > >> ~~~^~~~~~~~~~~ > >> .../drivers/net/thunderx/nicvf_ethdev.c:886:20: > >> note: ‘txq’ was declared here > >> struct nicvf_txq *txq; > >> ^~~ > >> > >> Same error on function 'nicvf_eth_dev_init' and 'nicvf_dev_start', it > >> seems 'nicvf_set_tx_function' inlined when optimization enabled. > >> > >> Initialize the txq and add NULL check before using it to fix. > >> > >> Fixes: 7413feee662d ("net/thunderx: add device start/stop and close") > >> Cc: stable@dpdk.org > >> > >> Reported-by: Richard Walsh > >> Signed-off-by: Ferruh Yigit > > > > Acked-by: Jerin Jacob > > > >> --- > >> > >> Btw, no compiler optimization enabled, only nicvf_rxtx.c has -Ofast, > >> is this intentional? > > > > Yes. At least in our setup, -Ofast turns out to be super set of -O3. > > That is what gcc documents about -Ofast, but again it is only for single > nicvf_rxtx.c file. The problem seen with -O3 case with other file. OK. For other files, we intentionally kept non -03 as it is in slow path. >